Spec URL: http://dl.za.jsdaav.net/review/bgpq3.spec SRPM URL: http://dl.za.jsdaav.net/review/bgpq3-0.1.31-1.fc26.src.rpm Description: You are running BGP in your network and want to automate filter generation for your routers? Well, with BGPQ3 it's easy. Fedora Account System Username: benniej koji Scratch Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=22064206 This is my first package and would need a sponsor.
I can review
Offhand, I see 2 (more) issues in upstream's provided Makefile.in: 1. (MUST) CFLAGS=@CFLAGS@ @DEFS@ -g -Wall -I. -O0 This line disables optimization, either remove the -O0 or provide a good justification to keep it. 2. (MUST) ${INSTALL} -c -s -m 755 bgpq3 ${DESTDIR}@bindir@ the -s there strips the binary, which is why there is no -debuginfo, need to patch out the '-s' 3. (SHOULD) %install section does not need rm -rf $RPM_BUILD_ROOT 4. (SHOULD) patches usually should include a comment saying explicitly what they are for. in this case, it's pretty obvious though 5. (SHOULD) be careful overusing * globs in %files section. In this case, I'd recommend the files be listed explicitly (since the list is small and manageable) %files %{_bindir}/bgpq3 %{_mandir}/man8/bgpq3.8* Otherwise, package is pretty simple and clean, Naming: ok Sources: ok (md5sum verified), a1b8aa3f9d83aaac4c1edf7abeb2845a bgpq3-0.1.31.tgz Scriptlets: n/a License: ok Please address at least MUST items 1,2 and I'll approve your submission
Changes made: Updated: Spec URL: http://dl.za.jsdaav.net/review/bgpq3.spec Updated: SRPM URL: http://dl.za.jsdaav.net/review/bgpq3-0.1.31-1.fc26.src.rpm Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=22131509
Looks good, thanks! APPROVED. I'll sponsor you shortly. next steps, https://fedoraproject.org/wiki/Join_the_package_collection_maintainers?rd=PackageMaintainers/Join#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/bgpq3
bgpq3-0.1.31-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b979d242d6
bgpq3-0.1.31-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-1ecbeb8436
bgpq3-0.1.31-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b9bde87ea9
bgpq3-0.1.31-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-666fc07261
bgpq3-0.1.31-1.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-98c40bc9d7
bgpq3-0.1.31-1.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-98c40bc9d7
bgpq3-0.1.31-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-666fc07261
bgpq3-0.1.31-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-1ecbeb8436
bgpq3-0.1.31-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b979d242d6
bgpq3-0.1.31-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b9bde87ea9
bgpq3-0.1.31-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
bgpq3-0.1.31-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
bgpq3-0.1.31-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
bgpq3-0.1.31-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
bgpq3-0.1.31-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.