Spec URL: https://raw.githubusercontent.com/kyrofa/core-moos-rpm/master/moos.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/kyrofa/core-moos/fedora-26-x86_64/00607665-moos/moos-10.0.2.a-1.fc26.src.rpm Description: Light, fast, cross-platform middle-ware for robotics. CoreMOOS is the most fundamental layer, providing a very robust network based communications architecture (two libraries and a lightweight communications hub called MOOSDB) which for very little effort lets you build applications which communicate with each other. Fedora Account System Username: kyrofa
Taking this review. Will also handle sponsorship.
> Source0: https://github.com/themoos/core-moos/archive/%{version}-release.tar.gz I'd suggest making this URL a bit better, per the SourceURL guidelines[1]. [1]: https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Tags For example: Source0: https://github.com/themoos/core-moos/archive/%{version}-release/core-moos-%{version}-release.tar.gz This makes the ultimate tarball filename downloaded a little saner. :)
Ah yes, much better indeed. Done and pushed, building on copr now.
I don't see a license file marked as something to be installed. It looks like the license file is "Core/GPLCore.txt". It should be marked as "%license" and mark it to be installed. This would be done in the files section: > %license Core/GPLCore.txt C.f.: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text
Good catch. I added the license to moos-libs, as the others depend upon it.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* GPL (v2 or later) (with incorrect FSF address)", "Unknown or generated", "BSL", "GPL (v2 or later) (with incorrect FSF address)", "LGPL (v2.1 or later)", "CC by (v3.0)". 211 files have unknown license. Detailed output of licensecheck in /home/makerpm/1495207-moos/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in moos- devel , moos-libs , moos-debuginfo [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: moos-10.0.2.a-1.fc28.x86_64.rpm moos-devel-10.0.2.a-1.fc28.x86_64.rpm moos-libs-10.0.2.a-1.fc28.x86_64.rpm moos-debuginfo-10.0.2.a-1.fc28.x86_64.rpm moos-10.0.2.a-1.fc28.src.rpm moos.x86_64: W: only-non-binary-in-usr-lib moos.x86_64: W: no-documentation moos.x86_64: W: no-manual-page-for-binary MOOSDB moos.x86_64: W: no-manual-page-for-binary ktm moos.x86_64: W: no-manual-page-for-binary mqos moos.x86_64: W: no-manual-page-for-binary mtm moos.x86_64: W: no-manual-page-for-binary umm moos-devel.x86_64: W: only-non-binary-in-usr-lib moos-devel.x86_64: W: no-documentation moos-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libMOOS.so.10.0.2 exit.5 moos-libs.x86_64: W: no-documentation moos-debuginfo.x86_64: E: useless-provides debuginfo(build-id) 5 packages and 0 specfiles checked; 1 errors, 11 warnings. Rpmlint (debuginfo) ------------------- Checking: moos-libs-debuginfo-10.0.2.a-1.fc28.x86_64.rpm moos-debuginfo-10.0.2.a-1.fc28.x86_64.rpm moos-debuginfo.x86_64: E: useless-provides debuginfo(build-id) 2 packages and 0 specfiles checked; 1 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory moos.x86_64: W: spelling-error Summary(en_US) Mission -> Visionary moos.x86_64: W: spelling-error %description -l en_US Light -> Lightweight moos.x86_64: W: spelling-error %description -l en_US fast -> fascist moos.x86_64: W: spelling-error %description -l en_US cross -> crocks moos.x86_64: W: spelling-error %description -l en_US platform moos.x86_64: W: spelling-error %description -l en_US middle -> diddle, twiddle moos.x86_64: W: spelling-error %description -l en_US ware -> warez, wart, wetware moos.x86_64: W: spelling-error %description -l en_US for -> fora, foo moos.x86_64: W: spelling-error %description -l en_US robotics -> erotics moos.x86_64: W: spelling-error %description -l en_US is -> ii, iv, Cs moos.x86_64: W: spelling-error %description -l en_US the -> tee, theory moos.x86_64: W: spelling-error %description -l en_US most -> lost, post moos.x86_64: W: spelling-error %description -l en_US fundamental -> documentation moos.x86_64: W: spelling-error %description -l en_US layer -> lamer moos.x86_64: W: spelling-error %description -l en_US providing -> programming moos.x86_64: W: spelling-error %description -l en_US a -> h, N, T moos.x86_64: W: spelling-error %description -l en_US very -> server moos.x86_64: W: spelling-error %description -l en_US network -> nyetwork, notwork, netter moos.x86_64: W: spelling-error %description -l en_US based -> lased moos.x86_64: W: spelling-error %description -l en_US communications -> documentations moos.x86_64: W: spelling-error %description -l en_US architecture moos.x86_64: W: spelling-error %description -l en_US two -> won moos.x86_64: W: spelling-error %description -l en_US libraries -> visionaries moos.x86_64: W: spelling-error %description -l en_US and -> handle moos.x86_64: W: spelling-error %description -l en_US hub -> thumb moos.x86_64: W: spelling-error %description -l en_US called -> walled moos.x86_64: W: spelling-error %description -l en_US which -> whack moos.x86_64: W: spelling-error %description -l en_US little -> brittle moos.x86_64: W: spelling-error %description -l en_US effort moos.x86_64: W: spelling-error %description -l en_US lets -> TELNETs moos.x86_64: W: spelling-error %description -l en_US you moos.x86_64: W: spelling-error %description -l en_US build -> burbled moos.x86_64: W: spelling-error %description -l en_US applications -> incantations moos.x86_64: W: spelling-error %description -l en_US communicate moos.x86_64: W: spelling-error %description -l en_US with -> widget moos.x86_64: W: spelling-error %description -l en_US each -> roach moos.x86_64: W: spelling-error %description -l en_US other -> theory moos.x86_64: W: invalid-url URL: http://www.robots.ox.ac.uk/~mobile/MOOS/wiki/pmwiki.php/Main/HomePage <urlopen error [Errno -2] Name or service not known> moos.x86_64: W: only-non-binary-in-usr-lib moos.x86_64: W: no-documentation moos.x86_64: W: no-manual-page-for-binary MOOSDB moos.x86_64: W: no-manual-page-for-binary ktm moos.x86_64: W: no-manual-page-for-binary mqos moos.x86_64: W: no-manual-page-for-binary mtm moos.x86_64: W: no-manual-page-for-binary umm moos-libs-debuginfo.x86_64: W: invalid-url URL: http://www.robots.ox.ac.uk/~mobile/MOOS/wiki/pmwiki.php/Main/HomePage <urlopen error [Errno -2] Name or service not known> moos-devel.x86_64: W: spelling-error Summary(en_US) Development moos-devel.x86_64: W: spelling-error Summary(en_US) files -> profiles moos-devel.x86_64: W: spelling-error Summary(en_US) for -> fora, foo moos-devel.x86_64: W: spelling-error %description -l en_US Libraries -> Visionaries moos-devel.x86_64: W: spelling-error %description -l en_US and -> handle moos-devel.x86_64: W: spelling-error %description -l en_US header -> deader, thread moos-devel.x86_64: W: spelling-error %description -l en_US files -> profiles moos-devel.x86_64: W: spelling-error %description -l en_US for -> fora, foo moos-devel.x86_64: W: spelling-error %description -l en_US developing moos-devel.x86_64: W: spelling-error %description -l en_US applications -> incantations moos-devel.x86_64: W: spelling-error %description -l en_US that -> hat, path moos-devel.x86_64: W: spelling-error %description -l en_US use -> user moos-devel.x86_64: W: invalid-url URL: http://www.robots.ox.ac.uk/~mobile/MOOS/wiki/pmwiki.php/Main/HomePage <urlopen error [Errno -2] Name or service not known> moos-devel.x86_64: W: only-non-binary-in-usr-lib moos-devel.x86_64: W: no-documentation moos-libs.x86_64: W: spelling-error Summary(en_US) Libraries -> Visionaries moos-libs.x86_64: W: spelling-error Summary(en_US) for -> fora, foo moos-libs.x86_64: W: spelling-error %description -l en_US Libraries -> Visionaries moos-libs.x86_64: W: spelling-error %description -l en_US for -> fora, foo moos-libs.x86_64: W: spelling-error %description -l en_US running -> gunning, stunning moos-libs.x86_64: W: spelling-error %description -l en_US applications -> incantations moos-libs.x86_64: W: invalid-url URL: http://www.robots.ox.ac.uk/~mobile/MOOS/wiki/pmwiki.php/Main/HomePage <urlopen error [Errno -2] Name or service not known> moos-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libMOOS.so.10.0.2 exit.5 moos-libs.x86_64: W: no-documentation moos-debuginfo.x86_64: W: spelling-error Summary(en_US) Debug -> Bug moos-debuginfo.x86_64: W: spelling-error Summary(en_US) information -> incantation moos-debuginfo.x86_64: W: spelling-error Summary(en_US) for -> fora, foo moos-debuginfo.x86_64: W: spelling-error Summary(en_US) package moos-debuginfo.x86_64: W: spelling-error %description -l en_US This -> Thuds moos-debuginfo.x86_64: W: spelling-error %description -l en_US package moos-debuginfo.x86_64: W: spelling-error %description -l en_US provides -> profiles moos-debuginfo.x86_64: W: spelling-error %description -l en_US information -> incantation moos-debuginfo.x86_64: W: spelling-error %description -l en_US for -> fora, foo moos-debuginfo.x86_64: W: spelling-error %description -l en_US Debug -> Bug moos-debuginfo.x86_64: W: spelling-error %description -l en_US is -> ii, iv, Cs moos-debuginfo.x86_64: W: spelling-error %description -l en_US useful -> segfault moos-debuginfo.x86_64: W: spelling-error %description -l en_US when -> wheel moos-debuginfo.x86_64: W: spelling-error %description -l en_US developing moos-debuginfo.x86_64: W: spelling-error %description -l en_US applications -> incantations moos-debuginfo.x86_64: W: spelling-error %description -l en_US that -> hat, path moos-debuginfo.x86_64: W: spelling-error %description -l en_US use -> user moos-debuginfo.x86_64: W: spelling-error %description -l en_US this -> thuds moos-debuginfo.x86_64: W: spelling-error %description -l en_US or -> op, xor moos-debuginfo.x86_64: W: spelling-error %description -l en_US debugging -> chugging moos-debuginfo.x86_64: W: invalid-url URL: http://www.robots.ox.ac.uk/~mobile/MOOS/wiki/pmwiki.php/Main/HomePage <urlopen error [Errno -2] Name or service not known> moos-debuginfo.x86_64: E: useless-provides debuginfo(build-id) 5 packages and 0 specfiles checked; 1 errors, 91 warnings. Requires -------- moos (rpmlib, GLIBC filtered): libMOOS.so.10()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) moos-libs(x86-64) rtld(GNU_HASH) moos-devel (rpmlib, GLIBC filtered): cmake-filesystem(x86-64) libMOOS.so.10()(64bit) moos-libs(x86-64) moos-libs (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) moos-debuginfo (rpmlib, GLIBC filtered): Provides -------- moos: moos moos(x86-64) moos-devel: cmake(MOOS) moos-devel moos-devel(x86-64) moos-libs: libMOOS.so.10()(64bit) moos-libs moos-libs(x86-64) moos-debuginfo: debuginfo(build-id) moos-debuginfo moos-debuginfo(x86-64) Source checksums ---------------- https://github.com/themoos/core-moos/archive/10.0.2.a-release.tar.gz : CHECKSUM(SHA256) this package : 145b15107d8c5b9488bd6cb730057a6744b343e1f59580cfebd3993b1d066ec6 CHECKSUM(SHA256) upstream package : 145b15107d8c5b9488bd6cb730057a6744b343e1f59580cfebd3993b1d066ec6 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/bin/fedora-review -b 1495207 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Admittedly, this report is from the first build... With the issues resolved in newer versions of the spec and I see good COPR builds. PACKAGE APPROVED.
Thank you Neal, I appreciate your review!
I've sponsored Kyle as well.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/moos
moos-10.0.2.a-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-644fe4a42c
moos-10.0.2.a-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-fb81b42da5
moos-10.0.2.a-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-99dce188bb
moos-10.0.2.a-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-eee0aa3230
moos-10.0.2.a-1.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-19750524de
moos-10.0.2.a-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
moos-10.0.2.a-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
moos-10.0.2.a-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
moos-10.0.2.a-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
moos-10.0.2.a-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.