Description of problem:
zip -u is being used to update META-INF/MANIFEST.MF in jar files

zip -u will "Update existing entries if newer on the file system"

Unfortunately zip is only looking at the minute that a file is updated.  We are finding on fast test machines that the content of the jar, and the new META-INF/MANIFEST.MF, are being created in the same minute.  Thus when the zip -u is ran, the MANIFEST.MF isn't updated, zip returns a non 0 error code, and the build fails.

"zip -u" should be changed to "zip", which changes the zip command from "update" to "add"

zip (add) will "Update existing entries and add new files. ... This is the default mode."

If you can change your spec files to use just "zip" instead of "zip -u", that will solve this race condition

Version-Release number of selected component (if applicable):
xpp3-1.1.4-16.c.fc27

How reproducible:
5-95% - depending on the speed of the machine.

Steps to Reproduce:
1. koji build
2.
3.

Actual results:

+ zip -u build/lib/<jar-name>.jar META-INF/MANIFEST.MF
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.oh6WeU (%build)
    Bad exit status from /var/tmp/rpm-tmp.oh6WeU (%build)
Child return code was: 1


Expected results:

...
+ zip -u build/lib/<jar-name>.jar META-INF/MANIFEST.MF
updating: META-INF/MANIFEST.MF (deflated 56%)
...