Note: gofed didn't support this prefix, so the spec is not generated by gofed directly. It is copied from another Go project for which the spec was generated by gofed.

in ppc64, it says: No matching package to install: 'compiler(go-compiler)'. But I've used the ExclusiveArch used by gofed: ExclusiveArch:  %{?go_arches:%{go_arches}}%{!?go_arches:%{ix86} x86_64 aarch64 %{arm}}

(In reply to Hedayat Vatankhah from comment #1)
> Note: gofed didn't support this prefix, so the spec is not generated by
> gofed directly. It is copied from another Go project for which the spec was
> generated by gofed.
> 
> in ppc64, it says: No matching package to install: 'compiler(go-compiler)'.
> But I've used the ExclusiveArch used by gofed: ExclusiveArch: 
> %{?go_arches:%{go_arches}}%{!?go_arches:%{ix86} x86_64 aarch64 %{arm}}

If you are on F25 or F26, you need to update go-srpm-macros:

sudo dnf update --releasever 27 go-srpm-macros

Then regenerate your SRPM and do a scratch build again.

Thanks, fixed:
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=22077950

 - Why do you choose to package git commit 9b7a7002582f1060703aa85bbbe4a422447d0c6e, which corresponds to version 0.4 from 2015, instead of packaging version 0.7 from 6 months ago (git commit fcc1d072d63b3e843495d4af4c0f522ddbb9fefc https://gitweb.torproject.org/pluggable-transports/goptlib.git/tag/?h=0.7 )

   Do a normal release of 0.7:

%global commit          fcc1d072d63b3e843495d4af4c0f522ddbb9fefc
%global shortcommit     %(c=%{commit}; echo ${c:0:7})
%global commitdate      20170331

Name:           golang-%{provider}-%{project}-%{repo}
Version:        0.7
Release:        1%{?dist}

   And the changelog:

* Mon Sep 25 2017 Hedayat Vatankhah <hedayat.fwd+rpmchlog> - 0.7-1

 - You've got leftover of siphash in this comment:


# The source for this package was pulled from upstream's vcs. Clone the
# repository and create archive using:
# git archive --format=tar --prefix=goptlib-<commit>/ HEAD | gzip > ***siphash***-<shortcommit>.tar.gz


I haven't yet formally reviewed it, but please fix this and I'll continue the review.

Oops, I'm really sorry. Using the wrong commit was a mistake (as I thought the github development mirror is identical to the original one). It is fixed now:

Spec: https://hedayat.fedorapeople.org/reviews/goptlib/golang-torproject-pluggable-transports-goptlib.spec
SRPM: https://hedayat.fedorapeople.org/reviews/goptlib/golang-torproject-pluggable-transports-goptlib-0.7-1.fc26.src.rpm

Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=22087639

Thank you for taking the review.

Two points:

 - You must include the license in the %license macro, not in %doc:

%if 0%{?with_devel}
%files devel -f devel.file-list
%doc README examples
%license COPYING
%dir %{gopath}/src/%{import_path}
%endif


 - /usr/share/gocode/src/git.torproject.org/pluggable-transports/goptlib is marked as listed twice, you should probably remove:

%dir %{gopath}/src/%{import_path}

   as it is already in devel.file-list.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package does not contain duplicates in %files.
  Note: warning: File listed twice:
  /usr/share/gocode/src/git.torproject.org/pluggable-transports/goptlib
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file COPYING is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 11 files have unknown license. Detailed
     output of licensecheck in /home/bob/packaging/review/golang-
     torproject-pluggable-transports-goptlib/review-golang-torproject-
     pluggable-transports-goptlib/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/gocode/src/git.torproject.org
     /pluggable-transports, /usr/share/gocode/src/git.torproject.org
[x]: Package must own all directories that it creates.
     Note: Directories without known owners:
     /usr/share/gocode/src/git.torproject.org/pluggable-transports,
     /usr/share/gocode/src/git.torproject.org, /usr/share/gocode,
     /usr/share/gocode/src
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 40960 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
     torproject-pluggable-transports-goptlib-devel , golang-torproject-
     pluggable-transports-goptlib-unit-test-devel
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: golang-torproject-pluggable-transports-goptlib-devel-0.7-1.fc28.noarch.rpm
          golang-torproject-pluggable-transports-goptlib-unit-test-devel-0.7-1.fc28.x86_64.rpm
          golang-torproject-pluggable-transports-goptlib-0.7-1.fc28.src.rpm
golang-torproject-pluggable-transports-goptlib.src: W: invalid-url Source0: goptlib-0.7.tar.gz
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

1. %license was fixed
2. Actually, the path was wrong. It is fixed now in the same URL as before.

All ok, package accepted.

Thanks again.

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-torproject-pluggable-transports-goptlib. You may commit to the branch "f27" in about 10 minutes.