Bug 1496131 - Remove dependency on net-tools
Summary: Remove dependency on net-tools
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: mariadb
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michal Schorm
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: deprecation, net-tools
TreeView+ depends on / blocked
 
Reported: 2017-09-26 14:24 UTC by James Hogarth
Modified: 2017-10-04 20:51 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-10-04 20:51:25 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description James Hogarth 2017-09-26 14:24:17 UTC
On linux the net-tools suite of utilities has been long since deprecated.

The relevant code that gets executed on Fedora and EPEL should be identified and patched out, with a suitable pull request upstream, to remove the dependency on any tool in the net-tools package and instead use suitable tools form iproute2.

Comment 1 Michal Schorm 2017-09-26 15:01:22 UTC
Hi,

MariaDB use 'net-tools' package for wsrep - in Galera replication.

I'll check what is used from that package and what can I do with it.

Comment 2 Michal Schorm 2017-10-03 23:28:09 UTC
Discussion with upstream: https://jira.mariadb.org/browse/MDEV-13993

Comment 3 Michal Schorm 2017-10-04 11:10:58 UTC
Hi,
as you can see in discussion with upstream (comment 2), it is believed, that just switching dependency should be sufficient.

However, can you please check the list (inside that discussion), if you spot something, that deserve more interest?

Comment 4 James Hogarth 2017-10-04 11:26:58 UTC
Looking at:

https://github.com/MariaDB/server/blob/10.2/scripts/wsrep_sst_rsync.sh#L105

it appears to me it switches over cleanly already for ifconfig to ip ... and looking further they already use ss rather than the older netstat.

Searching the repo the only other place I see is here... but that's build time tests and I don't know if you run them?

https://github.com/MariaDB/server/blob/8f643e2063c9890a353149f39ef85b2cf3151fd0/mysql-test/t/host_cache_size_functionality.test

So ... looks like it'll be simple to resolve this just removing net-tools from the requires and adding iproute

Comment 5 Michal Schorm 2017-10-04 20:45:16 UTC
The latest rawhide build has iproute requirement inside instead of net-tools.

mariadb build 3:10.2.9-2
  https://koji.fedoraproject.org/koji/taskinfo?taskID=22258567

Comment 6 James Hogarth 2017-10-04 20:51:25 UTC
 Excellent news. Thanks for getting that into place. 

We can safely mark this closed rawhide in that case I think :)


Note You need to log in before you can comment on or make changes to this bug.