Bug 1496272 - Perl's ccflags do not include a -Wformat option
Summary: Perl's ccflags do not include a -Wformat option
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: perl
Version: 26
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-09-26 21:09 UTC by Scott Baker
Modified: 2017-09-27 11:56 UTC (History)
13 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-09-27 11:56:11 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Scott Baker 2017-09-26 21:09:33 UTC
Description of problem:

Perl's ccflags do not include a -Wformat option. Attempting to compile Vim with Perl support I ran in to this bug: https://github.com/vim/vim/issues/2068

How reproducible:
Easily

Steps to Reproduce:
1. Run: perl -V:ccflags
2. Note the output includes "-Werror=format-security" but no corresponding -Wformat

Actual results:
bakers@yellow(~/github/vim)
:perl -V:ccflags
ccflags='-D_REENTRANT -D_GNU_SOURCE -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -fwrapv -fno-strict-aliasing -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64';

Expected results:
Some type of -Wformat would be included

Additional info:
Vim calls ExtUtils::Embed to get the cflags and it is also incorrect (I assume they're closely related).

bakers@yellow(~/github/vim)
:perl -Mlib=src/ -MExtUtils::Embed -e 'ccflags;perl_inc;print"\n"'
 -D_REENTRANT -D_GNU_SOURCE -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -fwrapv -fno-strict-aliasing -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64  -I/usr/lib64/perl5/CORE

Comment 1 Jitka Plesnikova 2017-09-27 07:25:25 UTC
I look at man page and there is mention "-Wformat is enabled by -Wall."

-Wall is included in ccflags.


Note You need to log in before you can comment on or make changes to this bug.