typo, change "After installation" to "After uninstallation" in Comment 0

same issue when undeploy openshift metrics hawkular agent, set openshift_metrics_install_hawkular_agent=false, openshift metrics hawkular agent can not be undeployed.

I think this is expected, eric can clarify.

This is expected, yes.

Due to logging and metrics installing by default, it made sense to update the logic such that install and uninstall should have separate flags.

To uninstall metrics you should set openshift_metrics_uninstall_metrics=True

(In reply to ewolinet from comment #4)
> This is expected, yes.
> 
> Due to logging and metrics installing by default, it made sense to update
> the logic such that install and uninstall should have separate flags.
> 
> To uninstall metrics you should set openshift_metrics_uninstall_metrics=True

Tested with openshift-ansible-playbooks-3.7.0-0.131.0, set openshift_metrics_uninstall_metrics=True, metrics still can not be uninstalled. We usually set openshift_metrics_install_metrics=false to uninstall metrics before, and it can uninstall successfully.

# parameters
openshift_metrics_uninstall_metrics=True
openshift_metrics_hawkular_hostname=hawkular-metrics.${SUB_DOMAIN}
openshift_metrics_project=openshift-infra
openshift_metrics_image_prefix=brew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888/openshift3/
openshift_metrics_image_version=v3.7

Created attachment 1331666 [details]
set openshift_metrics_uninstall_metrics=True to undeploy metrics

@Junqi,

I see this at the bottom of the play:

PLAY [OpenShift Metrics] ****************************************************************************************************************************************************************
skipping: no hosts matched


Can you please provide the full inventory you used for testing this?

(In reply to ewolinet from comment #8)
> @Junqi,
> 
> I see this at the bottom of the play:
> 
> PLAY [OpenShift Metrics]
> *****************************************************************************
> *****************************************************************************
> ******
> skipping: no hosts matched
> 
> 
> Can you please provide the full inventory you used for testing this?

[OSEv3:children]
masters
etcd

[masters]
${MASTER} openshift_public_hostname=${MASTER}

[etcd]
${ETCD} openshift_public_hostname=${ETCD}


[OSEv3:vars]
ansible_ssh_user=root
ansible_ssh_private_key_file="~/libra.pem"
deployment_type=openshift-enterprise
openshift_docker_additional_registries=brew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888/


# Metrics
openshift_metrics_uninstall_metrics=True
openshift_metrics_hawkular_hostname=hawkular-metrics.${SUB_DOMAIN}
openshift_metrics_project=openshift-infra
openshift_metrics_image_prefix=brew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888/openshift3/
openshift_metrics_image_version=v3.7

Tested with openshift-ansible-3.7.0-0.128.0, set openshift_metrics_uninstall_metrics=True, metrics could be undeployed, I used openshift-ansible-3.7.0-0.131 when this defect was reported, so there is something wrong with openshift-ansible-3.7.0-0.131

@ewolinet, will these parameters and the old ones co-exist in the same inventory file?  Currently, our automation tests use a common uninstall inventory with the following parameters set to:

openshift_logging_install_logging=false
openshift_metrics_install_metrics=false

QE needs to test older version of OCP, so it's vital that openshift-ansible can accept both parameters in the inventory and depending on the OCP version, it will pick the correct parameters w/o raising errors.  In short we want to be able to have the following in the inventory so the same inventory will work for all versions of OCP that accepts ansible installation.

### for OCP < 3.7
openshift_logging_install_logging=false
openshift_metrics_install_metrics=false

#### for OCP >= 3.7
openshift_logging_uninstall_logging=true
openshift_logging_uninstall_metrics=true

https://github.com/openshift/openshift-ansible/pull/5600

Tested with openshift-ansible-3.7.0-0.143.1, codes are reverted, set openshift_metrics_install_metrics=false can undeploy metrics successfully.

Installer version
# rpm -qa | grep openshift-ansible
openshift-ansible-docs-3.7.0-0.143.1.git.0.89248df.el7.noarch
openshift-ansible-filter-plugins-3.7.0-0.143.1.git.0.89248df.el7.noarch
openshift-ansible-3.7.0-0.143.1.git.0.89248df.el7.noarch
openshift-ansible-lookup-plugins-3.7.0-0.143.1.git.0.89248df.el7.noarch
openshift-ansible-roles-3.7.0-0.143.1.git.0.89248df.el7.noarch
openshift-ansible-callback-plugins-3.7.0-0.143.1.git.0.89248df.el7.noarch
openshift-ansible-playbooks-3.7.0-0.143.1.git.0.89248df.el7.noarch

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:3188