Bug 1496565 - Patch Thunderbird in Fedora 28+ to be compatible with NSS using sqlite
Summary: Patch Thunderbird in Fedora 28+ to be compatible with NSS using sqlite
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: thunderbird
Version: 28
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Gecko Maintainer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1496560
TreeView+ depends on / blocked
 
Reported: 2017-09-27 19:05 UTC by Kai Engert (:kaie) (inactive account)
Modified: 2019-05-28 23:05 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-05-28 23:05:30 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
sqlcompat-esr52-1-730495-backport (15.92 KB, patch)
2017-10-23 16:04 UTC, Kai Engert (:kaie) (inactive account)
no flags Details | Diff
sqlcompat-esr52-2-backport-1389664 (10.33 KB, patch)
2017-10-23 16:04 UTC, Kai Engert (:kaie) (inactive account)
no flags Details | Diff
sqlcompat-esr52-3-backport-1394871 (976 bytes, patch)
2017-10-23 16:05 UTC, Kai Engert (:kaie) (inactive account)
no flags Details | Diff
sqlcompat-esr52-4-backport-1329360 (5.48 KB, patch)
2017-10-23 16:05 UTC, Kai Engert (:kaie) (inactive account)
no flags Details | Diff
sqlcompat-esr52-5-backport-1382866 (15.26 KB, patch)
2017-10-23 16:05 UTC, Kai Engert (:kaie) (inactive account)
no flags Details | Diff
sqlcompat-esr52-6-fix-logins-decrypt-test (658 bytes, patch)
2017-10-23 16:06 UTC, Kai Engert (:kaie) (inactive account)
no flags Details | Diff

Description Kai Engert (:kaie) (inactive account) 2017-09-27 19:05:00 UTC
This is the equivalent Thunderbird bug for firefox bug 1496563.

Because Thunderbird is based on the 52.x and ESR branches, we'll require patches until we upgrade to Thunderbird 59.x

Comment 1 Kai Engert (:kaie) (inactive account) 2017-10-23 16:03:49 UTC
Thunderbird 52.x requires several backported patches:

  https://bugzilla.mozilla.org/show_bug.cgi?id=730495
    "Need to guarantee that sqlite3_config is called before 
    any other SQLite function"

  https://bugzilla.mozilla.org/show_bug.cgi?id=1389664
    "have PSM always initialize the user's pin to the empty string 
     if necessary at startup"

  https://bugzilla.mozilla.org/show_bug.cgi?id=1394871
    "profile migration code will need to know about key4.db"

  https://bugzilla.mozilla.org/show_bug.cgi?id=1329360
    "avoid some NSS functions that internally use PK11_GetInternalKeySlot"
    this one was necessary as a dependency of other patches

  https://bugzilla.mozilla.org/show_bug.cgi?id=1382866
    "CERT_ChangeCertTrust can fail if the user hasn't logged in to 
     softoken"

  portions of this bhug are contained in one of patches above:
    https://bugzilla.mozilla.org/show_bug.cgi?id=1324071

  for completeness, a test fix from
    https://bugzilla.mozilla.org/show_bug.cgi?id=1386955


Here is a scratch build with those patches backported:
  https://koji.fedoraproject.org/koji/taskinfo?taskID=22567078

Comment 2 Kai Engert (:kaie) (inactive account) 2017-10-23 16:04:29 UTC
Created attachment 1342279 [details]
sqlcompat-esr52-1-730495-backport

Comment 3 Kai Engert (:kaie) (inactive account) 2017-10-23 16:04:47 UTC
Created attachment 1342280 [details]
sqlcompat-esr52-2-backport-1389664

Comment 4 Kai Engert (:kaie) (inactive account) 2017-10-23 16:05:11 UTC
Created attachment 1342281 [details]
sqlcompat-esr52-3-backport-1394871

Comment 5 Kai Engert (:kaie) (inactive account) 2017-10-23 16:05:32 UTC
Created attachment 1342282 [details]
sqlcompat-esr52-4-backport-1329360

Comment 6 Kai Engert (:kaie) (inactive account) 2017-10-23 16:05:51 UTC
Created attachment 1342283 [details]
sqlcompat-esr52-5-backport-1382866

Comment 7 Kai Engert (:kaie) (inactive account) 2017-10-23 16:06:16 UTC
Created attachment 1342284 [details]
sqlcompat-esr52-6-fix-logins-decrypt-test

Comment 8 Kai Engert (:kaie) (inactive account) 2017-10-23 16:08:24 UTC
In case anyone wants to help testing that I've correctly backported these patches (they don't cause any regressions), I've also built a scratch build for Fedora 26 (I'm using this build on my local machine).
  https://koji.fedoraproject.org/koji/taskinfo?taskID=22649115

Comment 9 Kai Engert (:kaie) (inactive account) 2017-10-23 16:36:07 UTC
Jan, do you agree to this backport?

It will be necessary to carry these patches (only on Fedora 28) until we update Fedora 28 to Thunderbird 59.

Do you want me to submit an updated build, or would you like to submit it?
Thanks!

+Patch501:       sqlcompat-esr52-1-730495-backport
+Patch502:       sqlcompat-esr52-2-backport-1389664
+Patch503:       sqlcompat-esr52-3-backport-1394871
+Patch504:       sqlcompat-esr52-4-backport-1329360
+Patch505:       sqlcompat-esr52-5-backport-1382866
+Patch506:       sqlcompat-esr52-6-fix-logins-decrypt-test

+pushd mozilla
+%patch501 -p1 -b .sqlcompat-1
+%patch502 -p1 -b .sqlcompat-2
+%patch503 -p1 -b .sqlcompat-3
+%patch504 -p1 -b .sqlcompat-4
+%patch505 -p1 -b .sqlcompat-5
+%patch506 -p1 -b .sqlcompat-6
+popd

Comment 10 Kai Engert (:kaie) (inactive account) 2017-10-24 10:52:50 UTC
coordinated with Jan on IRC.

Rawhide build with the patch running here:
https://koji.fedoraproject.org/koji/taskinfo?taskID=22665438

Comment 11 Fedora End Of Life 2018-02-20 15:31:33 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle.
Changing version to '28'.

Comment 13 Ben Cotton 2019-05-02 20:31:16 UTC
This message is a reminder that Fedora 28 is nearing its end of life.
On 2019-May-28 Fedora will stop maintaining and issuing updates for
Fedora 28. It is Fedora's policy to close all bug reports from releases
that are no longer maintained. At that time this bug will be closed as
EOL if it remains open with a Fedora 'version' of '28'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 28 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 14 Ben Cotton 2019-05-28 23:05:30 UTC
Fedora 28 changed to end-of-life (EOL) status on 2019-05-28. Fedora 28 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.