Bug 1496687 - Confusing Bindings and Secrets on web console
Summary: Confusing Bindings and Secrets on web console
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OKD
Classification: Red Hat
Component: Management Console
Version: 3.x
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: ---
Assignee: Samuel Padgett
QA Contact: Yadan Pei
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-09-28 06:53 UTC by Yadan Pei
Modified: 2017-10-12 12:08 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-10-12 12:08:58 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
SecretsShowsInBindings (34.47 KB, image/png)
2017-10-11 09:35 UTC, Yadan Pei
no flags Details

Description Yadan Pei 2017-09-28 06:53:44 UTC
Description of problem:
In collapsed view for provisioned services on Overview page, secrets are shown under BINDINGS. While in expanded view, bindings name are displayed under SECRET

Version-Release number of selected component (if applicable):
v3.7.0-alpha.1+455ae1f-742
docker.io/openshift/origin                        latest              d0744e004177        7 hours ago         1.068 GB
docker.io/openshift/origin-service-catalog        latest              f0ecb9d8eb78        7 hours ago         361.3 MB


How reproducible:
Always

Steps to Reproduce:
1.Provision service and create Binding, take Jenkins (Persistent)as example
2.Check Binding info In collapsed view for provisioned services on Overview
3.Check Binding info column on Provisioned Service pages

Actual results:
2.Secrets created are shown in BINDINGS section
3.BINDINGS column lists secrets name

Expected results:
2-3. BINDINGS section should display binding name not secrets

Additional info:

Comment 1 Yadan Pei 2017-09-29 01:42:53 UTC
Hi Sam, any comments about this issue? There is another issue I plan to report, but that depends on this.

Comment 2 Samuel Padgett 2017-09-29 11:59:39 UTC
We definitely shouldn't show different names in collapsed row vs expanded.

https://github.com/openshift/origin-web-console/pull/2187

Comment 3 openshift-github-bot 2017-09-29 17:01:15 UTC
Commit pushed to master at https://github.com/openshift/origin-web-console

https://github.com/openshift/origin-web-console/commit/425e3f9df817d784ee910157c34f043594069fed
Bug 1496687 - Consistent binding names

* Show binding name rather than secret name in collapsed overview row to
  be consistent with what we show when expanded.
* Remove "Secret" heading above binding name to avoid confusion. We
  shouldn't label a ServiceBinding as a Secret since they're different
  resources.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1496687

Comment 4 Yadan Pei 2017-09-30 00:48:46 UTC
Thanks Sam, I need to change severity since it doesn't make sense of not accepting a card if only low severity bugs exists.

Comment 5 Yadan Pei 2017-10-11 09:34:23 UTC
Checked on oc v3.7.0-alpha.1+e610f2a-1003

docker.io/openshift/origin                   latest              e8ba5c99f837        9 hours ago         1.064 GB
docker.io/openshift/origin-service-catalog   latest              1a0dd1adae72        9 hours ago         352.2 MB

Secrets was shown in Bindings column at Provisioned Service page

Comment 6 Yadan Pei 2017-10-11 09:35:06 UTC
Created attachment 1337065 [details]
SecretsShowsInBindings

Comment 7 Yadan Pei 2017-10-11 09:38:11 UTC
Bindings display correctly on Overview page in both collapsed & expanded view

Comment 8 Yadan Pei 2017-10-11 09:39:32 UTC
Assign this back

Comment 10 openshift-github-bot 2017-10-11 14:00:30 UTC
Commit pushed to master at https://github.com/openshift/origin-web-console

https://github.com/openshift/origin-web-console/commit/9396acb3bb355f31c44c998487b5e9480acdbaa6
Bug 1496687: Consistent binding names

Use the binding name instead of the secret name in the service instances
table to be consistent with the overview and service instance details page.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1496687

Comment 11 Yadan Pei 2017-10-12 02:36:02 UTC
Checked on v3.7.0-alpha.1+572fb85-1047

Now Secrets and Bindings are shown correctly both on Overview and Provisioned Service page


Note You need to log in before you can comment on or make changes to this bug.