Bug 1496924 - Can not see custom reports in "Edit Report Menus" if Company Name does not contain a dash (-)
Summary: Can not see custom reports in "Edit Report Menus" if Company Name does not co...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.8.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.8.3
Assignee: Harpreet Kataria
QA Contact: Niyaz Akhtar Ansari
URL:
Whiteboard:
Depends On: 1489821
Blocks: 1480288
TreeView+ depends on / blocked
 
Reported: 2017-09-28 18:57 UTC by Satoe Imaishi
Modified: 2021-03-11 15:52 UTC (History)
14 users (show)

Fixed In Version: 5.8.3.5
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1489821
Environment:
Last Closed: 2018-05-15 18:03:22 UTC
Category: ---
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Comment 2 CFME Bot 2017-11-13 21:24:11 UTC
New commit detected on ManageIQ/manageiq-ui-classic/fine:
https://github.com/ManageIQ/manageiq-ui-classic/commit/a0ca93f5dae8fb9cd8bd2c5360ec5cae5ed6e9fc

commit a0ca93f5dae8fb9cd8bd2c5360ec5cae5ed6e9fc
Author:     Dan Clarizio <dclarizi>
AuthorDate: Mon Sep 25 15:58:51 2017 -0700
Commit:     Satoe Imaishi <simaishi>
CommitDate: Mon Nov 13 16:16:22 2017 -0500

    Merge pull request #2229 from h-kataria/custom_report_node_title_fix
    
    Fixed Custom Reports node text when there is "-" present in tenant name
    (cherry picked from commit 6c18b654cda9d0318fdec428b5f71a0c06e94787)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1496924

 app/controllers/application_controller.rb            |  2 +-
 spec/controllers/miq_report_controller/menus_spec.rb | 18 +++++-------------
 2 files changed, 6 insertions(+), 14 deletions(-)

Comment 3 Niyaz Akhtar Ansari 2017-12-18 09:04:49 UTC
The issue is still reproducible in Version 5.8.3.0

Comment 5 Harpreet Kataria 2018-02-15 20:18:50 UTC
https://github.com/ManageIQ/manageiq-ui-classic/pull/3412

Comment 6 CFME Bot 2018-03-12 20:12:29 UTC
New commit detected on ManageIQ/manageiq-ui-classic/fine:

https://github.com/ManageIQ/manageiq-ui-classic/commit/4b0a8958962648de539c976d926e99d38f0cfb73
commit 4b0a8958962648de539c976d926e99d38f0cfb73
Author:     Harpreet Kataria <hkataria>
AuthorDate: Thu Feb 15 15:05:59 2018 -0500
Commit:     Harpreet Kataria <hkataria>
CommitDate: Thu Feb 15 15:05:59 2018 -0500

    Show custom reports in menu editor as available reports.

    Fixed code to show Custom reports in Available Reports box in menu editor. Code has been refactored and fixed on Upstream and G release, this is a Fine specific fix.
    Fixed existing spec test
    backported fixes from https://github.com/ManageIQ/manageiq-ui-classic/pull/3245 to Fine

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1496924
    https://bugzilla.redhat.com/show_bug.cgi?id=1545441

 app/controllers/application_controller.rb | 112 +-
 app/controllers/report_controller/menus.rb | 6 +-
 app/controllers/report_controller/schedules.rb | 2 +-
 spec/controllers/miq_report_controller/menus_spec.rb | 14 +-
 spec/controllers/miq_report_controller/trees_spec.rb | 2 +-
 spec/controllers/report_controller_spec.rb | 52 +-
 6 files changed, 79 insertions(+), 109 deletions(-)


Note You need to log in before you can comment on or make changes to this bug.