Hide Forgot
Created attachment 1332457 [details] Proposed change I try to polish Platform module <https://github.com/fedora-modularity/hp/blob/master/README.md> for the modular Fedora and I found a problem in dbus-devel package. Platform module does not provide cmake, thus dbus-devel cannot be installed for building applications against dbus because currently there is a broken dependency from dbus-devel on cmake-filesystem. The attached patch adds a build-time condition that allows removing the dependency on cmake-filesystem when building for a module while it does not change anything when building for normal Fedora. If you have no objections I will apply it.
I'd submit patches as PRs on pagure; bugzilla is terrible for code review. Rather than omitting the dependency, shouldn't we just not ship the cmake rules at all in this situatoin?
It's also possible. But then cmake-driven package won't be able to build against dbus. On the other hand it would be cleaner. I will rework it for disabling the cmake rules. Then people maintaining Platform can freely decide whether to disable the support completely or keep it there and fix it on cmake packaging side.
https://src.fedoraproject.org/rpms/dbus/pull-request/1
dbus-1.11.20-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0d8f0e29e4
I went for a slightly different approach of simply removing the cmake files if cmake support is disabled. If you want to make the cmake support optional in the build system, I suggest submitting your patch upstream: https://bugs.freedesktop.org/enter_bug.cgi?product=dbus
dbus-1.11.20-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-0d8f0e29e4
dbus-1.11.20-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.