Hello,

 - BuildRoot: should not be used in Fedora. See https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

 - The whole systemd handling is wrong, we have macros for this that you should use. See https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Systemd

   First, instead of:

Requires(post): systemd-units
Requires(preun): systemd-units
Requires(postun): systemd-units
BuildRequires:  systemd-units

  Use:

%{?systemd_requires}
BuildRequires: systemd

 For all the daemons like this:

%post arbiter
if [ $1 -eq 1 ] ; then 
  /bin/systemctl daemon-reload >/dev/null 2>&1 || :
fi

%preun arbiter 
if [ $1 -eq 0 ] ; then
  /bin/systemctl --no-reload disable %{name}-arbiter.service > /dev/null 2>&1 || :
  /bin/systemctl stop %{name}-arbiter.service > /dev/null 2>&1 || :
fi

%postun arbiter
/bin/systemctl daemon-reload >/dev/null 2>&1 || :
if [ $1 -ge 1 ] ; then
  /bin/systemctl try-restart %{name}-arbiter.service >/dev/null 2>&1 || :
fi

  Use instead:

%post arbiter
%systemd_post %{name}-arbiter.service

%preun arbiter
%systemd_preun %{name}-arbiter.service

%postun arbiter
%systemd_postun_with_restart %{name}-arbiter.service


 - The license is wrongly installed. It must be in the %license tag' not in %doc, like this:

%files common
%{python_sitelib}/%{name}
%{python_sitelib}/alignak*.egg-info
%license LICENSE
%doc AUTHORS CONTRIBUTING.rst Changelog README.rst

 - Could you add a descriptive comment for the user that you are creating? With the -c switch. See https://fedoraproject.org/wiki/Packaging:UsersAndGroups#Dynamic_allocation

 - You could use %{py2_dist macros to handle your Python dependencies. See https://fedoraproject.org/wiki/Packaging:Python#Requires_and_BuildRequires_with_standardized_names

Hi,

New version with fix :

Spec URL: https://hvad.fedorapeople.org/fedora/alignak/alignak.spec

SRPM URL: https://hvad.fedorapeople.org/fedora/alignak/alignak-1.0.0-1.fc26.src.rpm

I must work on EPEL 7 compatibilities.

Best regard

I'm not familiar with EPEL 7 specificities, though I know %{py2_dist macros won't work.

 - You didn't remove BuildRoot:

 - systemd thingies are still wrong, you should not include 

if [ $1 -eq 1 ] ; then 
  ...
fi

   it's already included within the systemd macros.
   See for example how the %systemd_post is resolved by rpm:

$ rpm --eval "%systemd_post"

if [ $1 -eq 1 ] ; then 
        # Initial installation 
        systemctl --no-reload preset  >/dev/null 2>&1 || : 
fi

Hi,

New version with fix :

Spec URL: https://hvad.fedorapeople.org/fedora/alignak/alignak.spec

SRPM URL: https://hvad.fedorapeople.org/fedora/alignak/alignak-1.0.0-1.fc26.src.rpm

It's Ok for you ? 

Best regard

 - Use a more meaningful name for your archive, with:

Source0:        https://github.com/Alignak-monitoring/%{name}/archive/%{version}/%{name}-%{version}.tar.gz

 - There's a typo here:

Buildarch:      noarch

   It should be "BuildArch".

 - Your ini and cfg configuration files are marked as executable:

alignak-arbiter.noarch: E: executable-marked-as-config-file /etc/alignak/alignak.cfg
alignak-arbiter.noarch: E: script-without-shebang /etc/alignak/alignak.cfg
alignak-arbiter.noarch: E: executable-marked-as-config-file /etc/alignak/alignak.ini
alignak-arbiter.noarch: E: script-without-shebang /etc/alignak/alignak.ini
alignak-arbiter.noarch: E: executable-marked-as-config-file /etc/alignak/daemons/arbiterd.ini
alignak-arbiter.noarch: E: script-without-shebang /etc/alignak/daemons/arbiterd.ini
alignak-arbiter.noarch: E: executable-marked-as-config-file /etc/alignak/daemons/brokerd.ini
alignak-arbiter.noarch: E: script-without-shebang /etc/alignak/daemons/brokerd.ini
alignak-arbiter.noarch: E: executable-marked-as-config-file /etc/alignak/daemons/pollerd.ini
alignak-arbiter.noarch: E: script-without-shebang /etc/alignak/daemons/pollerd.ini
alignak-arbiter.noarch: E: executable-marked-as-config-file /etc/alignak/daemons/reactionnerd.ini
alignak-arbiter.noarch: E: script-without-shebang /etc/alignak/daemons/reactionnerd.ini
alignak-arbiter.noarch: E: executable-marked-as-config-file /etc/alignak/daemons/receiverd.ini
alignak-arbiter.noarch: E: script-without-shebang /etc/alignak/daemons/receiverd.ini
alignak-arbiter.noarch: E: executable-marked-as-config-file /etc/alignak/daemons/schedulerd.ini
alignak-arbiter.noarch: E: script-without-shebang /etc/alignak/daemons/schedulerd.ini
alignak-reactionner.noarch: E: executable-marked-as-config-file /etc/alignak/daemons/reactionnerd.ini
alignak-reactionner.noarch: E: script-without-shebang /etc/alignak/daemons/reactionnerd.in
alignak-scheduler.noarch: E: executable-marked-as-config-file /etc/alignak/daemons/schedulerd.ini
alignak-scheduler.noarch: E: script-without-shebang /etc/alignak/daemons/schedulerd.ini
alignak-poller.noarch: E: executable-marked-as-config-file /etc/alignak/daemons/pollerd.ini
alignak-poller.noarch: E: script-without-shebang /etc/alignak/daemons/pollerd.ini
alignak-broker.noarch: E: executable-marked-as-config-file /etc/alignak/daemons/brokerd.ini
alignak-broker.noarch: E: script-without-shebang /etc/alignak/daemons/brokerd.ini
alignak-receiver.noarch: E: executable-marked-as-config-file /etc/alignak/daemons/receiverd.ini
alignak-receiver.noarch: E: script-without-shebang /etc/alignak/daemons/receiverd.ini

  Remove the executable bits (i.e. chmod 0644) and notify upstream about this.

 - Remove the shebangs from your Python scripts:

alignak-common.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/alignak/bin/alignak_arbiter.py /usr/bin/env python
alignak-common.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/alignak/bin/alignak_arbiter.py 644 /usr/bin/env python
alignak-common.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/alignak/bin/alignak_broker.py /usr/bin/env python
alignak-common.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/alignak/bin/alignak_broker.py 644 /usr/bin/env python
alignak-common.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/alignak/bin/alignak_environment.py /usr/bin/env python
alignak-common.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/alignak/bin/alignak_environment.py 644 /usr/bin/env python
alignak-common.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/alignak/bin/alignak_poller.py /usr/bin/env python
alignak-common.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/alignak/bin/alignak_poller.py 644 /usr/bin/env python
alignak-common.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/alignak/bin/alignak_reactionner.py /usr/bin/env python
alignak-common.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/alignak/bin/alignak_reactionner.py 644 /usr/bin/env python
alignak-common.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/alignak/bin/alignak_receiver.py /usr/bin/env python
alignak-common.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/alignak/bin/alignak_receiver.py 644 /usr/bin/env python
alignak-common.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/alignak/bin/alignak_scheduler.py /usr/bin/env python
alignak-common.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/alignak/bin/alignak_scheduler.py 644 /usr/bin/env python

   See https://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_Python_libraries

  - Mark file in run as ghost:

alignak-common.noarch: W: non-ghost-in-run /run/alignak

A file or directory in the package is located in /run. Files installed in this
directory should be marked as %ghost and created at runtime to work properly
in tmpfs /run setups.

i.e.

%ghost %{_rundir}/%{name}

Hi,

New version with fix :

Spec URL: https://hvad.fedorapeople.org/fedora/alignak/alignak.spec

SRPM URL: https://hvad.fedorapeople.org/fedora/alignak/alignak-1.0.0-1.fc26.src.rpm

Sorry but the first remark is not of my own. Archive name is create by upstream. 

I open an issue for third remark.

It's OK ?

Best regard

> Sorry but the first remark is not of my own. Archive name is create by upstream. 

Github *does* support naming the archive like this:

Source0:        https://github.com/Alignak-monitoring/%{name}/archive/%{version}/%{name}-%{version}.tar.gz

Make the change in your SPEC, then run spectool -g on it: you will get the archive with a proper name.

Hi,

New version with last fix :

Spec URL: https://hvad.fedorapeople.org/fedora/alignak/alignak.spec

SRPM URL: https://hvad.fedorapeople.org/fedora/alignak/alignak-1.0.0-1.fc26.src.rpm

I didn't know "spectool -g".

Best regard

Ok, package accepted.

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/alignak

alignak-1.0.0-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b865f26dd9

alignak-1.0.0-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-5757f70cc9

alignak-1.0.0-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b865f26dd9

alignak-1.0.0-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-5757f70cc9

alignak-1.0.0-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

alignak-1.0.0-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.