Bug 1497520 – sos-report do not collect OVN logs

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1497520 - sos-report do not collect OVN logs

Summary:	sos-report do not collect OVN logs

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	sos (Show other bugs)
Sub Component:
Version:	7.4
Hardware:	Unspecified Unspecified

Priority	high Severity high
Target Milestone:	rc
Target Release:	7.5
Assigned To:	Pavel Moravec
QA Contact:	Jakub Heger
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2017-10-01 07:15 EDT by Eran Kuris
Modified:	2018-04-10 14:07 EDT (History)
CC List:	14 users (show)

See Also:
Fixed In Version:	sos-3.5-1.el7
Doc Type:	If docs needed, set a value
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2018-04-10 14:05:49 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
sos file for example (14.29 MB, application/x-xz) 2017-10-01 07:15 EDT, Eran Kuris	no flags	Details
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Github	sosreport/sos/pull/1116	None	None	None	2017-10-02 10:59 EDT
Red Hat Product Errata	RHEA-2018:0963	None	None	None	2018-04-10 14:07 EDT

Groups: None (edit)

Description Eran Kuris 2017-10-01 07:15:35 EDT

Created attachment 1332888 [details]
sos file for example

Description of problem:
sos-report do not collect OVN logs that located under 
/var/log/openstack/ 
[root@controller-1 ~]# ll /var/log/openvswitch/
total 1780
-rw-r--r--. 1 root root  98898 Oct  1 09:57 ovn-controller.log
-rw-r--r--. 1 root root    811 Oct  1 09:09 ovn-northd.log
-rw-r--r--. 1 root root    359 Oct  1 08:47 ovsdb-server.log
-rw-r--r--. 1 root root 686715 Oct  1 10:50 ovsdb-server-nb.log
-rw-r--r--. 1 root root 684991 Oct  1 10:50 ovsdb-server-sb.log
-rw-r--r--. 1 root root   4042 Oct  1 09:57 ovs-vswitchd.log

Version-Release number of selected component (if applicable):
12   -p 2017-09-28.1
[root@controller-1 ~]# rpm -qa |grep sos
sos-3.4-6.el7.noarch
[root@controller-1 ~]# rpm -qa |grep ovn
openvswitch-ovn-common-2.7.2-4.git20170719.el7fdp.x86_64
puppet-ovn-11.3.1-0.20170825135756.c03c3ed.el7ost.noarch
openvswitch-ovn-central-2.7.2-4.git20170719.el7fdp.x86_64
openvswitch-ovn-host-2.7.2-4.git20170719.el7fdp.x86_64
python-networking-ovn-3.0.1-0.20170906223255.c663db6.el7ost.noarch

How reproducible:
always


Steps to Reproduce:
Steps to Reproduce:
1. Deploy Director HA Pike with OVN
2. create netwrok& subnet 
3. check the log under  /var/log/openvswitch/ 
4. run sos report and check the file that created.
Actual results:
ovn logs do not collect by sos

Expected results:
all logs should collect by sos report

Additional info:

Comment 3 Pavel Moravec 2017-10-02 06:14:03 EDT

Thanks for report. Few questions before I submit upstream PR for this:

- (just to (silently) confirm): we should collect those log when 'openvswitch' or 'openvswitch-dpdk' packages are installed, I expect.

- whole /var/log/openvswitch/ directory should be collected? Or e.g. just /var/log/openvswitch/*log or some specific set of logfiles?

- some size limit constrains? (default is 10MB of newest logs, until --all-logs option is used, usually it is sufficient)

- could there be some secret data (passwords or so) that we should obfuscate? (usually not, but it could happen)

Comment 4 Eran Kuris 2017-10-02 07:31:25 EDT

(In reply to Pavel Moravec from comment #3)
> Thanks for report. Few questions before I submit upstream PR for this:
> 
> - (just to (silently) confirm): we should collect those log when
> 'openvswitch' or 'openvswitch-dpdk' packages are installed, I expect.
> 
> - whole /var/log/openvswitch/ directory should be collected? Or e.g. just
> /var/log/openvswitch/*log or some specific set of logfiles?
I expect to get OVN logs under sos report.

> - some size limit constraints? (default is 10MB of newest logs, until
> --all-logs option is used, usually, it is sufficient)
 cant answer about it.

> - could there be some secret data (passwords or so) that we should
> obfuscate? (usually not, but it could happen)
I don't think so but it better to ask OVN developers.
Maybe Numan can answer that...

Comment 5 Numan Siddique 2017-10-02 08:30:40 EDT

(In reply to Eran Kuris from comment #4)
> (In reply to Pavel Moravec from comment #3)
> > Thanks for report. Few questions before I submit upstream PR for this:
> > 
> > - (just to (silently) confirm): we should collect those log when
> > 'openvswitch' or 'openvswitch-dpdk' packages are installed, I expect.
> > 
> > - whole /var/log/openvswitch/ directory should be collected? Or e.g. just
> > /var/log/openvswitch/*log or some specific set of logfiles?
> I expect to get OVN logs under sos report.

I would prefer whole directory. All the OVN logs end with *.log though.

> 
> > - some size limit constraints? (default is 10MB of newest logs, until
> > --all-logs option is used, usually, it is sufficient)
>  cant answer about it.

That seems fine.

> 
> > - could there be some secret data (passwords or so) that we should
> > obfuscate? (usually not, but it could happen)
> I don't think so but it better to ask OVN developers.
> Maybe Numan can answer that...

I don't think there is any secret data in the logs.

Comment 6 Bryn M. Reeves 2017-10-02 08:35:17 EDT

> I would prefer whole directory. All the OVN logs end with *.log though.

Log collection needs to obey the standard --log-size=N and --all-logs switches; if those are given and log size limits are disabled then the whole directory will be collected.

Comment 7 Pavel Moravec 2017-11-02 11:14:59 EDT

Fixed via sos 3.5 rebase.

Comment 14 errata-xmlrpc 2018-04-10 14:05:49 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:0963

Note You need to log in before you can comment on or make changes to this bug.