Bug 1497633 - Review Request: mediaextract - Extract media files that are embedded within other files
Summary: Review Request: mediaextract - Extract media files that are embedded within o...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-NEEDSPONSOR FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2017-10-02 09:33 UTC by Ye Cheng
Modified: 2020-08-10 00:57 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-08-10 00:57:15 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Comment 1 Sergey Avseyev 2017-10-03 08:36:11 UTC
Would be better if you will use link, which can be resolved to the plain files/blobs. Your spec url should be http://copr-dist-git.fedorainfracloud.org/cgit/yecheng/mediaextract/mediaextract.git/plain/mediaextract.spec, instead of its HTML version

Comment 2 Sergey Avseyev 2017-10-03 08:46:09 UTC
Koji reports failed builds: https://koji.fedoraproject.org/koji/taskinfo?taskID=22233771

Comment 3 Ye Cheng 2017-10-04 13:27:12 UTC
Thanks. Fixed by removing -m64 and -m32 flags the upstream set in makefile, but I don't know how it will function on alternative architectures. I will test it in qemu.

Comment 4 Sergey Avseyev 2017-10-10 08:11:47 UTC
Not it compiles on koji https://koji.fedoraproject.org/koji/taskinfo?taskID=22361632

Looks good to me. Are you going to remove "NotReady" once you will check it working on other platforms? If you can write some test for that, which can be applied as a patch, you can execute it automatically in the %check section of the spec.

Comment 6 Ye Cheng 2017-11-04 12:02:59 UTC
The check section only check whether the built binary is runnable, but not whether it will run correctly. This program probably will not work correctly consistently on architectures that do not support unaligned memory access, according to upstream readme.

Comment 8 Michael Schwendt 2017-11-11 22:18:54 UTC
> %patch0
> %patch1

https://fedoraproject.org/wiki/Packaging:Guidelines#Patch_Guidelines


> %post
> if [ $1 = 1 ] ; then
>  mandb
> fi
> 
> %postun
> if [ $1 = 0 ] ; then
>   mandb
> fi

That's odd. First Fedora package ever I've seen that does.
https://fedoraproject.org/wiki/Packaging:Guidelines#Manpages

mandb is updated via systemd man-db.timer.

Comment 9 Package Review 2020-07-10 00:56:11 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 10 Package Review 2020-08-10 00:57:15 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.