Description: Development and debugging tools for GStreamer. SRPM: https://fedorapeople.org/~limb/review/gst-devtools/gst-devtools-1.12.3-1.fc28.src.rpm SPEC: https://fedorapeople.org/~limb/review/gst-devtools/gst-devtools.spec
Issues: ======= - Package contains BR: python2-devel or python3-devel - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc I checked https://fedoraproject.org/wiki/Packaging:Meson and noticed gcc is listed. BR: gcc can be omitted if possible. Please fix the following lines: gst-devtools.x86_64: W: no-documentation gst-devtools.x86_64: E: wrong-script-interpreter /usr/bin/gst-validate-launcher /usr/bin/env python3 gst-devtools.x86_64: E: wrong-script-interpreter /usr/lib64/gst-validate-launcher/python/launcher/RangeHTTPServer.py /usr/bin/env python3 gst-devtools.x86_64: E: non-executable-script /usr/lib64/gst-validate-launcher/python/launcher/RangeHTTPServer.py 644 /usr/bin/env python3 gst-devtools.x86_64: E: wrong-script-interpreter /usr/lib64/gst-validate-launcher/python/launcher/__init__.py /usr/bin/env python3 gst-devtools.x86_64: E: non-executable-script /usr/lib64/gst-validate-launcher/python/launcher/__init__.py 644 /usr/bin/env python3 gst-devtools.x86_64: E: wrong-script-interpreter /usr/lib64/gst-validate-launcher/python/launcher/apps/gstcheck.py /usr/bin/env python3 gst-devtools.x86_64: E: non-executable-script /usr/lib64/gst-validate-launcher/python/launcher/apps/gstcheck.py 644 /usr/bin/env python3 gst-devtools.x86_64: E: wrong-script-interpreter /usr/lib64/gst-validate-launcher/python/launcher/apps/gstvalidate.py /usr/bin/env python3 gst-devtools.x86_64: E: non-executable-script /usr/lib64/gst-validate-launcher/python/launcher/apps/gstvalidate.py 644 /usr/bin/env python3 gst-devtools.x86_64: E: wrong-script-interpreter /usr/lib64/gst-validate-launcher/python/launcher/baseclasses.py /usr/bin/env python3 gst-devtools.x86_64: E: non-executable-script /usr/lib64/gst-validate-launcher/python/launcher/baseclasses.py 644 /usr/bin/env python3 gst-devtools.x86_64: E: wrong-script-interpreter /usr/lib64/gst-validate-launcher/python/launcher/config.py /usr/bin/env python3 gst-devtools.x86_64: E: non-executable-script /usr/lib64/gst-validate-launcher/python/launcher/config.py 644 /usr/bin/env python3 gst-devtools.x86_64: E: wrong-script-interpreter /usr/lib64/gst-validate-launcher/python/launcher/httpserver.py /usr/bin/env python3 gst-devtools.x86_64: E: non-executable-script /usr/lib64/gst-validate-launcher/python/launcher/httpserver.py 644 /usr/bin/env python3 gst-devtools.x86_64: E: wrong-script-interpreter /usr/lib64/gst-validate-launcher/python/launcher/main.py /usr/bin/env python3 gst-devtools.x86_64: E: non-executable-script /usr/lib64/gst-validate-launcher/python/launcher/main.py 644 /usr/bin/env python3 gst-devtools.x86_64: E: wrong-script-interpreter /usr/lib64/gst-validate-launcher/python/launcher/reporters.py /usr/bin/env python3 gst-devtools.x86_64: E: non-executable-script /usr/lib64/gst-validate-launcher/python/launcher/reporters.py 644 /usr/bin/env python3 gst-devtools.x86_64: E: wrong-script-interpreter /usr/lib64/gst-validate-launcher/python/launcher/utils.py /usr/bin/env python3 gst-devtools.x86_64: E: non-executable-script /usr/lib64/gst-validate-launcher/python/launcher/utils.py 644 /usr/bin/env python3 gst-devtools.x86_64: E: wrong-script-interpreter /usr/lib64/gst-validate-launcher/python/launcher/vfb_server.py /usr/bin/env python3 gst-devtools.x86_64: E: non-executable-script /usr/lib64/gst-validate-launcher/python/launcher/vfb_server.py 644 /usr/bin/env python3 gst-devtools.x86_64: W: no-manual-page-for-binary gst-validate-1.0 gst-devtools.x86_64: W: no-manual-page-for-binary gst-validate-launcher gst-devtools.x86_64: W: no-manual-page-for-binary gst-validate-media-check-1.0 gst-devtools.x86_64: W: no-manual-page-for-binary gst-validate-transcoding-1.0 gst-devtools-devel.x86_64: W: only-non-binary-in-usr-lib 4 packages and 0 specfiles checked; 23 errors, 6 warnings. Suggestion: https://fedoraproject.org/wiki/Packaging_tricks?rd=PackageMaintainers/Packaging_Tricks#Remove_shebang_from_Python_libraries
Thanks! Almost all fixed. I think only-non-binary-in-usr-lib needs to be that way. SRPM: https://fedorapeople.org/~limb/review/gst-devtools/gst-devtools-1.12.3-2.fc28.src.rpm SPEC: https://fedorapeople.org/~limb/review/gst-devtools/gst-devtools.spec
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL", "LGPL (v2.1 or later)", "LGPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated". [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/gstreamer-1.0/validate [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gstreamer-1.0, /usr/lib64/gstreamer-1.0/validate [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/gtk-doc(harfbuzz- devel, gimp-devel, p11-kit-devel), /usr/share/gtk-doc/html(harfbuzz- devel, gimp-devel, p11-kit-devel), /usr/lib64/girepository-1.0(vte3, gspell, libgepub, gnome-autoar, libgee, libzapojit, libchamplain, gsound, gobject-introspection, libmypaint, libgnome-keyring, libgtop2, gmime30, libgdata, gcr, tracker, libxklavier, gdk-pixbuf2, gst- transcoder, at-spi2-core, gtk2, gtk3, GConf2, appstream, gnome- bluetooth-libs, libgdl, grilo, gfbgraph, atk, libpeas, vte291, gnome- online-accounts, gucharmap-libs), /usr/share/gir-1.0(gtk2-devel, at- spi2-core-devel, gtk3-devel, atk-devel, gdk-pixbuf2-devel) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 604160 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gst- devtools-debuginfo [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1105920 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gst-devtools-1.12.3-2.fc26.x86_64.rpm gst-devtools-devel-1.12.3-2.fc26.x86_64.rpm gst-devtools-debuginfo-1.12.3-2.fc26.x86_64.rpm gst-devtools-1.12.3-2.fc26.src.rpm gst-devtools.x86_64: W: no-manual-page-for-binary gst-validate-1.0 gst-devtools.x86_64: W: no-manual-page-for-binary gst-validate-launcher gst-devtools.x86_64: W: no-manual-page-for-binary gst-validate-media-check-1.0 gst-devtools.x86_64: W: no-manual-page-for-binary gst-validate-transcoding-1.0 gst-devtools-devel.x86_64: W: only-non-binary-in-usr-lib 4 packages and 0 specfiles checked; 0 errors, 5 warnings. Based on the review, this package is now APPROVED.
Excellent, thank you so much!
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gst-devtools. You may commit to the branch "f27" in about 10 minutes.
gst-devtools-1.12.3-2.fc27 pitivi-0.99-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-918116c57e
pitivi-0.99-1.fc26 gst-devtools-1.12.3-2.fc26 gstreamer1-1.12.3-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9099d5f81c
gst-devtools-1.12.3-2.fc26, gstreamer1-1.12.3-1.fc26, pitivi-0.99-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-9099d5f81c
gst-devtools-1.12.3-2.fc27, pitivi-0.99-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-918116c57e
gst-devtools-1.12.3-2.fc26 gst-editing-services-1.12.3-1.fc26 gstreamer1-1.12.3-1.fc26 gstreamer1-plugins-bad-free-1.12.3-1.fc26 gstreamer1-plugins-base-1.12.3-1.fc26 gstreamer1-plugins-good-1.12.3-1.fc26 pitivi-0.99-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9099d5f81c
gst-devtools-1.12.3-2.fc26, gst-editing-services-1.12.3-1.fc26, gstreamer1-1.12.3-1.fc26, gstreamer1-plugins-bad-free-1.12.3-1.fc26, gstreamer1-plugins-base-1.12.3-1.fc26, gstreamer1-plugins-good-1.12.3-1.fc26, pitivi-0.99-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-9099d5f81c
gst-devtools-1.12.3-2.fc27, pitivi-0.99-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
gst-devtools-1.12.3-2.fc26, gst-editing-services-1.12.3-1.fc26, gstreamer1-1.12.3-1.fc26, gstreamer1-plugins-bad-free-1.12.3-1.fc26, gstreamer1-plugins-base-1.12.3-1.fc26, gstreamer1-plugins-good-1.12.3-1.fc26, pitivi-0.99-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.