Spec URL: http://kinginuyasha.enanocms.org/downloads/appstream-generator.spec SRPM URL: http://kinginuyasha.enanocms.org/downloads/appstream-generator-0.6.7-0.fc26.1.src.rpm Description: appstream-generator is a tool to generate distribution metadata from package repositories. It will extract icons, download screenshots, validate and transform the metadata and return XML or YAML files that can be read by AppStream clients, such as software centers. It will also generate issue reports as JSON documents and HTML pages. Fedora Account System Username: ngompa
There are some issues: 1) The Release tag is wrong, it should be 1%{?dist}, not 0%{?dist}.1 - also fix it in the changelog entry. 2) There are rpmlint warnings that look suspicious. Are you sure the symlinks to js libraries are created successfully? The relative symlinks containng all those "../" parts look wrong. Why are those not absolute paths? And are they supposed to be dangling in the installed package? I don't think so. appstream-generator.x86_64: W: dangling-relative-symlink /usr/share/appstream/templates/default/static/js/flot ../../../../../../lib/node_modules/flot appstream-generator.x86_64: W: dangling-relative-symlink /usr/share/appstream/templates/default/static/js/highlight/highlight.pack.js ../../../../../../javascript/highlight.js/highlight.pack.js appstream-generator.x86_64: W: dangling-relative-symlink /usr/share/appstream/templates/default/static/js/jquery/jquery.min.js ../../../../../../javascript/jquery/jquery.min.js 3) One of the %description lines is too long: appstream-generator.x86_64: E: description-line-too-long C repositories. It will extract icons, download screenshots, validate and transform
(In reply to Fabio Valentini from comment #1) > There are some issues: > > 1) The Release tag is wrong, it should be 1%{?dist}, not 0%{?dist}.1 - also > fix it in the changelog entry. > This will be fixed on import. I always change it to 1%{?dist} on import. > 2) There are rpmlint warnings that look suspicious. Are you sure the > symlinks to js libraries are created successfully? The relative symlinks > containng all those "../" parts look wrong. Why are those not absolute > paths? And are they supposed to be dangling in the installed package? I > don't think so. > > appstream-generator.x86_64: W: dangling-relative-symlink > /usr/share/appstream/templates/default/static/js/flot > ../../../../../../lib/node_modules/flot > appstream-generator.x86_64: W: dangling-relative-symlink > /usr/share/appstream/templates/default/static/js/highlight/highlight.pack.js > ../../../../../../javascript/highlight.js/highlight.pack.js > appstream-generator.x86_64: W: dangling-relative-symlink > /usr/share/appstream/templates/default/static/js/jquery/jquery.min.js > ../../../../../../javascript/jquery/jquery.min.js > These symlinks are supposed to point to dependencies. They should be valid symlinks on install. > 3) One of the %description lines is too long: > appstream-generator.x86_64: E: description-line-too-long C repositories. It > will extract icons, download screenshots, validate and transform Will fix on import.
(In reply to Neal Gompa from comment #2) > (In reply to Fabio Valentini from comment #1) > > There are some issues: > > > > 1) The Release tag is wrong, it should be 1%{?dist}, not 0%{?dist}.1 - also > > fix it in the changelog entry. > > > > This will be fixed on import. I always change it to 1%{?dist} on import. OK. > > 2) There are rpmlint warnings that look suspicious. Are you sure the > > symlinks to js libraries are created successfully? The relative symlinks > > containng all those "../" parts look wrong. Why are those not absolute > > paths? And are they supposed to be dangling in the installed package? I > > don't think so. > > > > appstream-generator.x86_64: W: dangling-relative-symlink > > /usr/share/appstream/templates/default/static/js/flot > > ../../../../../../lib/node_modules/flot > > appstream-generator.x86_64: W: dangling-relative-symlink > > /usr/share/appstream/templates/default/static/js/highlight/highlight.pack.js > > ../../../../../../javascript/highlight.js/highlight.pack.js > > appstream-generator.x86_64: W: dangling-relative-symlink > > /usr/share/appstream/templates/default/static/js/jquery/jquery.min.js > > ../../../../../../javascript/jquery/jquery.min.js > > > > These symlinks are supposed to point to dependencies. They should be valid > symlinks on install. The first two do so correctly (no idea why rpmlint complains), but the "jquery.min.js" symlink is broken in the installed package, I just verified that in a rawhide mock root. > > 3) One of the %description lines is too long: > > appstream-generator.x86_64: E: description-line-too-long C repositories. It > > will extract icons, download screenshots, validate and transform > > Will fix on import. OK.
I think I've fixed js-jquery thing (I had a missing dependency for it)... Spec URL: http://kinginuyasha.enanocms.org/downloads/appstream-generator.spec SRPM URL: http://kinginuyasha.enanocms.org/downloads/appstream-generator-0.6.7-1.fc26.src.rpm
Hm. I suggest you take a look at the build logs of a koji scratch build I did just now (https://koji.fedoraproject.org/koji/taskinfo?taskID=22310584): - It looks like you'll need to add "ExcludeArch: s390x aarch64". Those don't have ldc, gir-to-d, and mustache-d. - The test suite fails on ppc64le. - There are compilation errors on ppc64. Another minor nit-pick: Don't start the Summary tag with "A fast ...", just use "Fast ...". The packaging itself looks good now.
Errk, I forgot to add the required "ExclusiveArch". Upstream only supports x86 and 32-bit ARM. Fixed it with the same URLs as before. Also adjusted the summary tag accordingly. Spec URL: http://kinginuyasha.enanocms.org/downloads/appstream-generator.spec SRPM URL: http://kinginuyasha.enanocms.org/downloads/appstream-generator-0.6.7-1.fc26.src.rpm
Looking good now, package approved.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/appstream-generator
appstream-generator-0.6.7-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-17353f1503
appstream-generator-0.6.7-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-5b15c20527
appstream-generator-0.6.7-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
appstream-generator-0.6.7-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.