Bug 1498579 - Collectd should have per plugin configuration
Summary: Collectd should have per plugin configuration
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: ovirt-engine-metrics
Classification: oVirt
Component: Generic
Version: 1.0.4.2
Hardware: All
OS: All
unspecified
medium
Target Milestone: ---
: ---
Assignee: Shirly Radco
QA Contact: Lukas Svaty
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-10-04 16:33 UTC by Lukas Svaty
Modified: 2022-06-27 08:31 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-10-29 16:57:28 UTC
oVirt Team: Metrics
Embargoed:
sbonazzo: ovirt-4.3-


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHV-46653 0 None None None 2022-06-27 08:31:57 UTC

Description Lukas Svaty 2017-10-04 16:33:32 UTC
Description of problem:
We need to add a file for each plugin loaded by collectd which we configure from the metrics side. This will make configuration of collectd easier, and plugins easier to navigate and enable/disable.

Based on BZ#1471949 comment#6

Version-Release number of selected component (if applicable):
ovirt-engine-metrics-1.1.1-0.0.master.20171001113530.el7.centos.noarch

How reproducible:
100%

Steps to Reproduce:
1. Check configuration files on collectd in /etc/collectd.d/


Actual results:
20-builtins-conf-for-ovirt-engine.conf

Expected results:
20-ovirt-postgresql.conf
20-ovirt-cpu.conf
20-ovirt-memory.conf
20-ovirt-interface.conf

Comment 1 Shirly Radco 2017-10-16 06:59:30 UTC
This has the advantage of a more organised conf.d and might allow an easier way for the user to figure out what plugins are loaded.

But the disadvantage is that if a certain plugin should not be used anymore, then we should remove the file.

That means adding another ansible role that deletes the required files.

Currently, for most of the plugins we only require updating 1 file.

Comment 2 Lukas Svaty 2017-10-16 07:40:03 UTC
Can you please explain why we need to remove the file?
I don't see any harm in just disabling the plugin inside the file and leaving the configuration untouched as admin can re-enable it later, or on demand.

Comment 3 Shirly Radco 2017-10-16 07:56:25 UTC
If the purpose is for a better user experience, to figure out what plugins are loaded, having files with disabled plugins will only add confusion and make this harder for the user to get the full list.

This RFE, in my opinion, is only a good to have.

Comment 4 Yaniv Lavi 2017-10-29 16:57:28 UTC
Not really critical in my opinion, it is common to have a single system conf.


Note You need to log in before you can comment on or make changes to this bug.