Bug 1498667 - [Regression] dnsmasq 2.78 breaks CNAMEs in config file
Summary: [Regression] dnsmasq 2.78 breaks CNAMEs in config file
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: dnsmasq
Version: 28
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Petr Menšík
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1557978
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-10-04 22:06 UTC by James
Modified: 2018-04-01 19:06 UTC (History)
7 users (show)

Fixed In Version: dnsmasq-2.79-1.fc27 dnsmasq-2.79-1.fc28
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-03-27 20:06:06 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Proposed patch (925 bytes, patch)
2018-02-26 19:09 UTC, Petr Menšík
no flags Details | Diff

Description James 2017-10-04 22:06:51 UTC
Description of problem:
dnsmasq 2.78 fails to start with a config that loads a bunch of cnames, for example:

dnsmasq: bad CNAME at line 1 of /etc/dnsmasq.d/dns/my-cnames

when /etc/dnsmasq.d/dns/my-cnames contains lines like

cname=alias.my.domain.,realname.my.domain.

This config works fine with dnsmasq 2.76.

Version-Release number of selected component (if applicable):
dnsmasq-2.78-1.fc28.x86_64.rpm

How reproducible:
Always.

Actual results:
Breakage.

Expected results:
dnsmasq doesn't break existing configs within a major version.

Comment 1 James 2017-11-09 22:28:15 UTC
Seems that 2.78 prefers its cnames to be in the form:

cname=alias1.my.domain,alias2.my.domain,realname.my.domain.

Note the lack of .s at the end of teh aliases. So now I have functionality back but I'm still going to keep this bug open as there's no good reason to have broken my existing config.

Comment 2 Fedora End Of Life 2018-02-20 15:32:29 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle.
Changing version to '28'.

Comment 3 Petr Menšík 2018-02-26 18:48:59 UTC
Hi James,

you are absolutely right. This was broken when support for multiple cnames in single command were added. It was already fixed by commit [1] to fix space after comma. But case you have described is still not fixed.

[1] http://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=commitdiff;h=30858e3b9b12500825a5dc4cd67902c3201c1b25

Comment 4 Petr Menšík 2018-02-26 19:08:42 UTC
Postech patch: http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2018q1/012018.html

Comment 5 Petr Menšík 2018-02-26 19:09:27 UTC
Created attachment 1400987 [details]
Proposed patch

Comment 6 Petr Menšík 2018-03-22 16:43:53 UTC
Upstream accepted patch

http://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=commit;h=56f06239301b512d0af55fe98b6e57f86884fce7

Will be part of rebased 2.79 version

Comment 7 Fedora Update System 2018-03-22 19:21:58 UTC
dnsmasq-2.79-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-5a4d0ee124

Comment 8 Fedora Update System 2018-03-22 19:23:12 UTC
dnsmasq-2.79-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-bb556fd888

Comment 9 Fedora Update System 2018-03-23 14:44:36 UTC
dnsmasq-2.79-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-5a4d0ee124

Comment 10 Fedora Update System 2018-03-23 17:46:58 UTC
dnsmasq-2.79-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-bb556fd888

Comment 11 Fedora Update System 2018-03-27 20:06:06 UTC
dnsmasq-2.79-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2018-04-01 19:06:25 UTC
dnsmasq-2.79-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.