Bug 1499501 - Review Request: gocomplete - A tool for bash writing bash completion in Go (Golang)
Summary: Review Request: gocomplete - A tool for bash writing bash completion in Go (G...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1250466
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-10-08 05:09 UTC by Ed Marshall
Modified: 2017-11-21 04:22 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-11-21 04:22:27 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Ed Marshall 2017-10-08 05:09:49 UTC
Spec URL: https://fedorapeople.org/~logic/gocomplete/gocomplete.spec
SRPM URL: https://fedorapeople.org/~logic/gocomplete/gocomplete-0-0.1.20170908git88e5976.fc26.src.rpm
Description: A tool for bash writing bash completion in Go (Golang)
Fedora Account System Username: logic

Koji scratch build (with expected ppc64 arch failure): https://koji.fedoraproject.org/koji/taskinfo?taskID=22322498

Comment 1 Robert-André Mauchin 🐧 2017-10-08 11:13:30 UTC
This is a binary package, not used as a library, thus I don't think you need to generate the -devel and -unit-test-devel subpackages.

Either just flick the devel and unit-test switches in the header:

# Generate devel rpm
%global with_devel 0
# Build project from bundled dependencies
%global with_bundled 0
# Build with debug info rpm
%global with_debug 1
# Run tests in check section
%global with_check 1
# Generate unit-test rpm
%global with_unit_test 0

Or better remove the whole gofed cruft which isn't needed.

Comment 2 Ed Marshall 2017-10-08 19:49:33 UTC
Actually, while gocomplete is a standalone executable (which generates bash/zsh completion for the "go" executable), it mostly exists as a useful example of using the library (I built it because Vault has a dependency on the library).

I'd almost be inclined to go the other direction (drop the gocomplete executable entirely, and just build the library), but had the thought that someone might find it useful, and it's trivial to build as part of this.

Your thoughts? I'm completely flexible, as long as the end result includes the library. :)

Comment 3 Robert-André Mauchin 🐧 2017-10-08 20:32:34 UTC
Ok, I think you should keep the binary then, in case someone also needs it.

Package accepted.

Comment 4 Gwyn Ciesla 2017-10-09 02:16:04 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/gocomplete

Comment 5 Fedora Update System 2017-10-12 08:30:34 UTC
gocomplete-0-0.1.20170908git88e5976.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f74ce72ede

Comment 6 Fedora Update System 2017-10-12 08:31:05 UTC
gocomplete-0-0.1.20170908git88e5976.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-290e6893ec

Comment 7 Fedora Update System 2017-10-13 04:24:01 UTC
gocomplete-0-0.1.20170908git88e5976.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-290e6893ec

Comment 8 Fedora Update System 2017-10-13 06:24:13 UTC
gocomplete-0-0.1.20170908git88e5976.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f74ce72ede

Comment 9 Fedora Update System 2017-10-17 00:15:08 UTC
gocomplete-0-0.1.20170908git88e5976.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2017-10-18 21:22:30 UTC
gocomplete-0-0.2.20170908git88e5976.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-290e6893ec

Comment 11 Ed Marshall 2017-10-19 21:49:16 UTC
EPEL7 depends on #1250466.

Comment 12 Fedora Update System 2017-10-26 11:51:50 UTC
gocomplete-0-0.2.20170908git88e5976.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.