Bug 1499569 - Review Request: python-twilio - Python Twilio Helper Library
Summary: Review Request: python-twilio - Python Twilio Helper Library
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-10-08 18:49 UTC by Michael Cullen
Modified: 2017-11-11 02:58 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-11-07 22:15:19 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Michael Cullen 2017-10-08 18:49:13 UTC
Spec URL: https://mich181189.fedorapeople.org/python-twilio/python-twilio.spec
SRPM URL: https://mich181189.fedorapeople.org/python-twilio/python-twilio-6.7.1-1.fc26.src.rpm
Description: Helper library for interfacing with Twilio's REST API
Fedora Account System Username: mich181189

COPR build here: https://copr.fedorainfracloud.org/coprs/mich181189/python-twilio/build/620332/

This is my first attempt at packaging a Python library so do let me know if I've made any mistakes!

Comment 1 Robert-André Mauchin 🐧 2017-10-10 18:35:32 UTC
Hello,

 - Use a more meaningful name for your archive, with:

Source0:        https://github.com/twilio/twilio-python/archive/%{version}/%{name}-%{version}.tar.gz

 - I don't think this is necessary:

# sitelib for noarch packages, sitearch for others (remove the unneeded one)
%{!?__python2: %global __python2 %__python}
%{!?python2_sitelib: %global python2_sitelib %(%{__python2} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")}

python2_sitelib is already defined in Fedora.

 - Use the appropriate python macros:

%{__python2} setup.py build ⇒ %py2_build

%{__python3} setup.py build ⇒ %py3_build

%{__python3} setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT ⇒ %py3_install

%{__python2} setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT ⇒ %py2_install

 - add the examples directory to %doc:

%doc README.rst examples

 - python2-twilio.noarch: E: description-line-too-long C The Twilio REST SDK simplifies the process of making calls using the Twilio REST API.

Split your description to stay under 80 characters per line.

 - python-twilio.src:26: W: mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 26)

Use either spaces or tabs, not both.

 - You could use the %{py2_dist/%{py3_dist macros to handle your Python dependencies. See https://fedoraproject.org/wiki/Packaging:Python#Requires_and_BuildRequires_with_standardized_names

BuildRequires:  python2-devel
BuildRequires:  %{py2_dist nose}
BuildRequires:  %{py2_dist pytz}
BuildRequires:  %{py2_dist six}
BuildRequires:  %{py2_dist mock}
BuildRequires:  python2-jwt
BuildRequires:  %{py2_dist requests}

%if %{with python3}
BuildRequires:  python3-devel
BuildRequires:  %{py3_dist nose}
BuildRequires:  %{py3_dist pytz}
BuildRequires:  %{py3_dist six}
BuildRequires:  %{py3_dist mock}
BuildRequires:  python3-jwt
BuildRequires:  %{py3_dist requests}
%endif # with python3

%description
%{desc}

#python2 subpackage
%package -n python2-twilio
Summary:        %{sum}

Requires:   %{py2_dist six}
Requires:   %{py2_dist requests}
Requires:   python2-jwt
Requires:   %{py2_dist pytz}

%{?python_provide:%python_provide python2-twilio}

%description -n python2-twilio
%{desc}

#python3 subpackage
%if %{with python3}
%package -n python3-twilio
Summary:        %{sum}

Requires:   %{py3_dist six}
Requires:   %{py3_dist requests}
Requires:   python3-jwt
Requires:   %{py3_dist pytz}

Comment 2 Michael Cullen 2017-10-14 01:22:29 UTC
> python2_sitelib is already defined in Fedora.
Ah ok - I got that from the template created by newspec



Spec URL: https://mich181189.fedorapeople.org/python-twilio/python-twilio.spec
SRPM URL: https://mich181189.fedorapeople.org/python-twilio/python-twilio-6.8.0-1.fc26.src.rpm

Comment 3 Robert-André Mauchin 🐧 2017-10-14 10:15:35 UTC
All ok, package accepted.

Comment 4 Gwyn Ciesla 2017-10-17 19:58:27 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-twilio

Comment 5 Fedora Update System 2017-10-19 23:33:13 UTC
python-twilio-6.8.0-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-98f1a0a410

Comment 6 Fedora Update System 2017-10-21 19:27:24 UTC
python-twilio-6.8.0-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-98f1a0a410

Comment 7 Fedora Update System 2017-10-24 10:48:17 UTC
python-twilio-6.8.0-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-36f9e309ec

Comment 8 Fedora Update System 2017-11-07 22:15:19 UTC
python-twilio-6.8.0-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2017-11-11 02:58:57 UTC
python-twilio-6.8.0-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.