Description of problem: Can't create snapshot with memory. There's no warning or error in UI, error is thrown in evm.log. Version-Release number of selected component (if applicable): 5.9.0.2.20171010190026_0413a06 How reproducible: Always Steps to Reproduce: 1. Have a VM on infrastructure provider, powered on 2. Go to Snapshots on that VM 3. Choose 'Create a new snapshot for this VM' button 4. Input some VM name and choose 'Snapshot VM memory' checkbox 5. Click Create Actual results: Everything seems like the snapshot is being created in the UI, but it never appears; error is thrown in evm.log Expected results: Snapshot gets created; no error Additional info: From evm.log: [----] E, [2017-10-12T06:50:24.971876 #12996:53113c] ERROR -- : MIQ(MiqQueue#m_callback) Message id: [2877]: uninitialized constant VmOrTemplate::Operations::Snapshot::MiqVmSnapshotError [----] E, [2017-10-12T06:50:24.972063 #12996:53113c] ERROR -- : [NameError]: uninitialized constant VmOrTemplate::Operations::Snapshot::MiqVmSnapshotError Method:[block in method_missing] [----] E, [2017-10-12T06:50:24.972176 #12996:53113c] ERROR -- : /var/www/miq/vmdb/app/models/vm_or_template/operations/snapshot.rb:54:in `rescue in raw_create_snapshot' /var/www/miq/vmdb/app/models/vm_or_template/operations/snapshot.rb:51:in `raw_create_snapshot' /var/www/miq/vmdb/app/models/mixins/miq_policy_mixin.rb:115:in `check_policy_prevent_callback' /var/www/miq/vmdb/app/models/miq_queue.rb:474:in `m_callback' /var/www/miq/vmdb/app/models/miq_queue.rb:443:in `delivered' /var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:116:in `deliver_queue_message' /var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:134:in `deliver_message' /var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:152:in `block in do_work' /var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:146:in `loop' /var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:146:in `do_work' /var/www/miq/vmdb/app/models/miq_worker/runner.rb:331:in `block in do_work_loop' /var/www/miq/vmdb/app/models/miq_worker/runner.rb:328:in `loop' /var/www/miq/vmdb/app/models/miq_worker/runner.rb:328:in `do_work_loop' /var/www/miq/vmdb/app/models/miq_worker/runner.rb:155:in `run' /var/www/miq/vmdb/app/models/miq_worker/runner.rb:129:in `start' /var/www/miq/vmdb/app/models/miq_worker/runner.rb:22:in `start_worker' /var/www/miq/vmdb/app/models/miq_worker.rb:354:in `block in start_runner_via_fork' /opt/rh/cfme-gemset/gems/nakayoshi_fork-0.0.3/lib/nakayoshi_fork.rb:24:in `fork' /opt/rh/cfme-gemset/gems/nakayoshi_fork-0.0.3/lib/nakayoshi_fork.rb:24:in `fork' /var/www/miq/vmdb/app/models/miq_worker.rb:352:in `start_runner_via_fork' /var/www/miq/vmdb/app/models/miq_worker.rb:346:in `start_runner' /var/www/miq/vmdb/app/models/miq_worker.rb:380:in `start' /var/www/miq/vmdb/app/models/miq_worker.rb:263:in `start_worker' /var/www/miq/vmdb/app/models/miq_worker.rb:150:in `block in sync_workers' /var/www/miq/vmdb/app/models/miq_worker.rb:150:in `times' /var/www/miq/vmdb/app/models/miq_worker.rb:150:in `sync_workers' /var/www/miq/vmdb/app/models/miq_server/worker_management/monitor.rb:53:in `block in sync_workers' /var/www/miq/vmdb/app/models/miq_server/worker_management/monitor.rb:50:in `each' /var/www/miq/vmdb/app/models/miq_server/worker_management/monitor.rb:50:in `sync_workers' /var/www/miq/vmdb/app/models/miq_server.rb:139:in `start' /var/www/miq/vmdb/app/models/miq_server.rb:231:in `start' /var/www/miq/vmdb/lib/workers/evm_server.rb:27:in `start' /var/www/miq/vmdb/lib/workers/evm_server.rb:48:in `start' /var/www/miq/vmdb/lib/workers/bin/evm_server.rb:4:in `<main>'
Looks like when the exceptions were moved to manageiq-gems-pending we didn't prefix the exceptions with the new module.
https://github.com/ManageIQ/manageiq/pull/16186
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/e9ab821b681091487ea41bb94ba5ebcdaf6585bc commit e9ab821b681091487ea41bb94ba5ebcdaf6585bc Author: Adam Grare <agrare> AuthorDate: Thu Oct 12 12:24:41 2017 -0400 Commit: Adam Grare <agrare> CommitDate: Thu Oct 12 12:24:41 2017 -0400 Add MiqException prefix to vm snapshot exceptions The MiqVm* exceptions need to be prefixed with MiqException:: ``` [----] E, [2017-10-12T12:22:39.387424 #19551:2b22230730d0] ERROR -- : MIQ(MiqQueue#deliver) Message id: [611], Error: [uninitialized constant VmOrTemplate::Operations::Snapshot::MiqVmError] [----] E, [2017-10-12T12:22:39.387587 #19551:2b22230730d0] ERROR -- : [NameError]: uninitialized constant VmOrTemplate::Operations::Snapshot::MiqVmError Method:[block in method_missing] [----] E, [2017-10-12T12:22:39.387650 #19551:2b22230730d0] ERROR -- : /home/agrare/workspace/redhat/manageiq/app/models/vm_or_template/operations/snapshot.rb:62:in `raw_remove_snapshot' /home/agrare/workspace/redhat/manageiq/app/models/vm_or_template/operations/snapshot.rb:86:in `remove_snapshot' ``` https://bugzilla.redhat.com/show_bug.cgi?id=1501306 app/models/vm_or_template/operations/snapshot.rb | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
Verified with 5.9.0.4.