Description of problem:
In Pike puppet runs are triggered differently than before, and they currently fail to report failure code to the callers.
Unless puppet is called with --detailed-exitcodes, it may fail to report error code when puppet Resources go in error .
The error is not catch and the deployment continues unexpectedly and fails much later for unrelated reasons.
The overcloud deployment should fail if any resource fail unexpectedly during the puppet run.
Specifically the impact for OSP is that the docker-puppet.py script was not properly using --detailed-exitcodes like the heat agent does.
Adding blocker - as this Bz is blocking #1494455 , which blocks OSP12 scenario for : "Controller replacement" .
what is the rationale for assigning this bug back to PIDONE? this is a generic framework issue.
BTW it´s not the first I notice this ping pong with bugs towards PIDONE. I would like to remind that when you reassign a but to another DFG, you need to explain why you believe that it is somebody else problem.
similar to you as comment #4, why was the bug bounced to DFG:Containers without any explanation?
After talking to Michele and Damien, this is an issue with the framework in general and not specific to PIDONE. While PIDONE is helping already fixing the problem (as Michele mentioned on IRC) the bug is DF responsibility as originally identified by Mike Burns.
(In reply to Fabio Massimo Di Nitto from comment #4)
> what is the rationale for assigning this bug back to PIDONE? this is a
> generic framework issue.
> BTW it´s not the first I notice this ping pong with bugs towards PIDONE. I
> would like to remind that when you reassign a but to another DFG, you need
> to explain why you believe that it is somebody else problem.
Thanks Fabio, Sure will do for next time.
So I moved it to DFG:Containers because the issue is with docker-puppet.py (as indicated in comment #2) and this was created by the containers team and is only necessary for the container effort so it was a bug in their feature. So moving it back once again. The DFG is the default assignee for THT but all DFGs have some elements they own within this component. TripleO components are special such that it may not always be DFG:DF but we end up with it by default.
So here is a current recap of the reviews needed here:
https://review.openstack.org/#/c/513261/ puppet-tripleo - tuned-adm fix (merged in pike)
https://review.openstack.org/#/c/512033/ tht - swift xined (merged in pike)
https://review.openstack.org/#/c/512082/ puppet-pacemaker rule order revert (merged and no stable branches)
https://review.openstack.org/#/c/511509/ tht - Add --detailed-exitcodes not merged yet because we are trying to fix all the additional CI breakages that this is causing
Quick status update, almost all reviews have merged in pike upstream
We still need 511509 backport  to merge in pike upstream, then we'll be good to move to MODIFIED.
Quick explanation for all the tracked reviews
https://review.openstack.org/517022 has just landed in pike and is the main fix for this bugzilla.
The other tracked reviews are all the fixes in pike for the bugs that are uncovered once the main fix is in use.
Here is a recap of all the reviews:
https://review.openstack.org/#/c/517022 - tht - Add --detailed-exitcodes when running puppet via ansible (stable/pike)
https://review.openstack.org/#/c/515326 - tht - Run containerized mistral-api eventlet (stable/pike)
https://review.openstack.org/#/c/514728 - puppet-tripleo - Add option to disable running mistral-api via wsgi (stable/pike)
https://review.openstack.org/#/c/514727 - tht - Disable MongoDB in scenario002 (stable/pike)
https://review.openstack.org/#/c/513261 - puppet-tripleo - Make sure tuned package is installed before calling tuned-adm (stable/pike)
https://review.openstack.org/#/c/513244 - tht - Disable SwiftDispersion when using docker (stable/pike)
https://review.openstack.org/#/c/513242 - tht - Disable xinetd class when creating swift-storage puppet configuration (stable/pike)
Note that we already ship puppet-pacemaker-0.6.1-0.20171024215340.9a46ecd.el7ost.src.rpm so the revert at
I607927c2ee5c29b605e18e9294b0f91d37337680 is not needed, hence we're not even linking it.
Moving this one to POST now.
I see that all of patches from https://bugzilla.redhat.com/show_bug.cgi?id=1501852#c14 was merge
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.