Spec URL: https://tc01.fedorapeople.org/ocaml/opam/opam.spec SRPM URL: https://tc01.fedorapeople.org/ocaml/opam/opam-2.0.0-0.2.beta4.fc26.src.rpm Description: Opam is a source-based package manager for OCaml. It supports multiple simultaneous compiler installations, flexible package constraints, and a Git-friendly development workflow. Fedora Account System Username: tc01 This replaces the previous (dead) review for opam. The only dependency currently missing from Fedora Rawhide is ocaml-cmdliner. The unit tests didn't run when I built the package in copr, so I've turned them off for now. (They worked fine when I built locally using rpmbuild).
*** Bug 1185099 has been marked as a duplicate of this bug. ***
*** Bug 1060436 has been marked as a duplicate of this bug. ***
I've updated to the latest upstream release, and decided to split opam-installer out into a subpackage. This way packages that want to be built using jbuilder only have to BR opam-installer instead of the full opam package. Spec URL: https://tc01.fedorapeople.org/ocaml/opam/opam.spec SRPM URL: https://tc01.fedorapeople.org/ocaml/opam/opam-2.0.0-0.3.beta5.fc26.src.rpm
I noticed there are two files licensed in LGPLv3+ instead of LGPLv2+. I asked upstream to upgrade everything to LGPLv3+ https://github.com/ocaml/opam/issues/3125 I think it is good to change the spec License field to LGPLv3+ anyway since v3+ is valid for v2+. For %check, I can reproduce the `make tests` failure in mock. I've also dump the test log at https://gist.github.com/andyli/39c567d847439ebb752ca3d14e91d037 I can't tell why did it fail either. Would you check to see if the tests pass outside mock? If not, we have to ask upstream. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL", "LGPL (v2.1)", "Unknown or generated". 322 files have unknown license. Detailed output of licensecheck in /home/andy/Documents/1501992-opam/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/ocaml [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/.build-id(cups- client, efivar-libs, rsyslog, policycoreutils-python-utils, lz4-libs, qemu-block-gluster, rpm-plugin-selinux, abrt, libmediaart, libimagequant, giflib, libreoffice-graphicfilter, trousers, libdb- utils, tracker-miners, xorg-x11-font-utils, PackageKit-command-not- found, perl-Sys-Syslog, libcom_err, libseccomp, p11-kit, libabw, gtkspell, libvirt-daemon-driver-storage-iscsi, libmodman, argyllcms, parted, gnome-disk-utility, libdvdread, zstd, bluez-libs, libwebp, libxslt, system-config-printer-udev, perl-Encode, elfutils, python2-cryptography, libevdev, libgpg-error, lvm2-libs, perl-Digest- SHA, libzstd, gtk-murrine-engine, libdazzle, avahi, lua-lpeg, symlinks, libcdr, mate-sensors-applet, e2fsprogs-libs, pulseaudio- libs, usermode-gtk, lcms2, qemu-guest-agent, ntfs-3g, libxcb, libyubikey, sssd-common-pac, python3-brlapi, openconnect, rtkit, xcb- util-keysyms, sushi, libgphoto2, xcb-util, libwmf-lite, python3-coverage, anaconda-widgets, http-parser, pulseaudio-utils, libeot, systemd-bootchart, perl-Time-Piece, dbusmenu-qt, ncurses-libs, polkit, ldns, libreport-plugin-logger, gnome-color-manager, fcoe- utils, libyui-mga-ncurses, xorg-x11-xkb-utils, ibus-hangul, NetworkManager-openvpn, libxkbfile, hplip-libs, libwvstreams, xmlrpc-c-client, cheese, python3-hawkey, libwpd, libvirt-daemon- driver-qemu, mbedtls, perl-Time-HiRes, qemu-block-ssh, libwps, gssdp, gnome-calendar, sssd-ldap, libacl, xorg-x11-drv-ati, libSM, policycoreutils, mcelog, abrt-plugin-bodhi, libmusicbrainz5, pptp, gnote, sane-backends-drivers-scanners, libXxf86misc, foomatic, colord- gtk, libpath_utils, libicu-devel, rpm-build, libvirt-daemon-driver- storage-sheepdog, pygtk2, libglvnd-gles, rpm-plugin-systemd-inhibit, setroubleshoot, gstreamer1, gom, python2-krbv, dbus-libs, libreoffice- gtk3, libreoffice-gtk2, cairo-gobject, gnome-screenshot, gutenprint, usermode, qpdf-libs, linux-atm-libs, libedit, openssh, libvirt- gconfig, python3-cairo, accountsservice, isl, hfsplus-tools, ImageMagick, perl-IPC-SysV, gssproxy, mesa-libGLU, libblockdev-btrfs, libatomic_ops, gupnp-av, caja-extensions, libmpcdec, gtk-update-icon- cache, python3-iscsi-initiator-utils, libyui-ncurses, libvirt-daemon- driver-interface, NetworkManager, liblangtag, NetworkManager-glib, NetworkManager-l2tp-gnome, libdatrie, glade-libs, setuptool, gstreamer-plugins-good, guile, pcre-utf16, tree, isdn4k-utils, gvfs- goa, pipewire, gnupg, cronie-anacron, xfsprogs, libcroco, NetworkManager-iodine, telepathy-glib, plymouth-plugin-label, colord- libs, perl-Unicode-Collate, totem-pl-parser, gpgmepp, libgcab1, libzhuyin, gvnc, hypervfcopyd, cronie, caja-image-converter, rpm-libs, libreport, nettle, libcacard, libverto-libev, colord, libpipeline, pkcs11-helper, accountsservice-libs, gnome-system-monitor, findutils, popt, python2-xpyb, qt5-qtx11extras, libsss_idmap, imsettings- gsettings, libraw1394, folks, gnome-clocks, python3-dbus, iproute-tc, isomd5sum, gamin, spice-glib, woff2, coolkey, dotconf, luajit, libXfont, PackageKit-glib, patch, sqlite-libs, lttng-ust, enchant, libXxf86dga, rhash, xdg-user-dirs-gtk, libwayland-client, pinentry- gnome3, libsmbios, libXres, mdadm, xl2tpd, device-mapper, python2-librepo, libXtst, python2-setproctitle, irqbalance, gnome- terminal, GeoIP, libsigc++20, python2-talloc, opencc, libXrandr, newt, liba52, hplip, python2-libuser, cyrus-sasl-scram, crda, libical, sheepdog, qt5-qtdeclarative, libofa, libXfont2, libblockdev-loop, libssh2, NetworkManager-adsl, open-vm-tools-desktop, samba-dc-libs, libXcursor, iio-sensor-proxy, bridge-utils, webkitgtk4-plugin-process- gtk2, procps-ng, plymouth-core-libs, telnet, simple-scan, libXpm, xorg-x11-drv-nouveau, bluez-obexd, mate-screenshot, libpeas, pam_krb5, gutenprint-cups, grub2-tools-efi, xdg-desktop-portal-gtk, libselinux, libassuan, expat, cups-filters, iw, clutter-gtk, userspace-rcu, wavpack, python3-yui, ibus-libpinyin, setroubleshoot-server, make, python3-markupsafe, libnice, libsoup, libetpan, glusterfs-api, fuse, perl-Net-SSLeay, perl-Filter, cups-libs, mate-session-manager, libappstream-glib, libsepol, efivar, gzip, python3-cangjie, keyutils, libipa_hbac, libfdisk, libdmx, openssl-libs, corosynclib, dconf- editor, libreport-plugin-reportuploader, gavl, shotwell, ipset, mate- system-log, libyui-gtk, keybinder3, deltarpm, fuse-libs, xorg-x11-xauth, libglvnd-glx, gvfs-smb, gtkspell3, python2-caja, libcue, libXrender, json-glib, libX11-xcb, libfontenc, libicu, libgsf, xorg-x11-drv-vmware, sssd-common, NetworkManager-openconnect, libgtop2, btrfs-progs, tracker, wvdial, perl-Devel-PPPort, cogl, sni- qt, mesa-libglapi, glx-utils, evolution-data-server, PackageKit, libmateweather, perl-MIME-Base64, engrampa, wpa_supplicant, texlive- lib, ppp, git, perl-Compress-Raw-Bzip2, mpg123-libs, opus, git-core, libxklavier, traceroute, cyrus-sasl-plain, libblockdev-crypto, pcsc- lite-ccid, libreoffice-pdfimport, mate-notification-daemon, rp-pppoe, libtheora, attr, mtr, gtksourceview2, gtksourceview3, pugixml, libcanberra-gtk2, libcanberra-gtk3, gstreamer1-plugins-bad-free-gtk, mtdev, libmspack, systemd-udev, libXvMC, wmctrl, cheese-libs, libXmu, capstone, smartmontools, jasper-libs, librbd1, mate-screensaver, device-mapper-libs, xorg-x11-xinit, marisa, libogg, libffi, pcre- utf32, python2-hawkey, diffutils, chrony, time, checkpolicy, mpfr, caja-beesu, cyrus-sasl-md5, iputils, qt5-qtxmlpatterns, numactl-libs, mariadb-connector-c-devel, libvirt-daemon-driver-nwfilter, recode, gvfs-fuse, tigervnc-server-minimal, gpgme, ninja-build, hypervvssd, xorg-x11-drv-openchrome, libmcpp, libibverbs, gdb-headless, dleyna- core, qemu-block-nfs, libgovirt, libqmi-utils, libmbim-utils, psacct, lame-libs, gnome-bluetooth-libs, usbredir, iproute, iptables-libs, mate-dictionary, cryptsetup-libs, bind-libs, pygobject2, mesa- libwayland-egl, ghostscript-x11, lua-posix, libinput, libreport-cli, libpkgconf, python3-dmidecode, libyui-mga, abrt-gui-libs, libosinfo, corosync, im-chooser, qt5-qtsvg, libreoffice-calc, libqmi, gawk, dmraid-events, pcsc-lite-libs, adwaita-gtk2-theme, libbasicobjects, gdk-pixbuf2-devel, baobab, rdma-core, vte291, libgweather, sssd-krb5, qemu-block-iscsi, perl-Devel-Peek, brotli, filezilla, libgrss, httpd, libsmbclient, file-roller-nautilus, transmission-gtk, libvdpau, python2-cddb, compat-openssl10, abrt-addon-kerneloops, gnome-maps, mate-system-monitor, network-manager-applet, openCOLLADA, xcb-util- renderutil, sssd-ad, lightdm, libpinyin, freetype, logrotate, rdist, scl-utils, libdnet, atril-libs, ntfsprogs, abrt-libs, libgdither, samba-common-libs, libreswan, libpsl, python3-rpm, nautilus-sendto, fwupdate-libs, jimtcl, libuser, NetworkManager-libreswan, libnotify, abrt-retrace-client, opensc, boost-date-time, libglade2, satyr, caribou-gtk3-module, gnome-font-viewer, gtk2-immodule-xim, xorg-x11 -drv-vesa, libbluray, brltty, libstdc++, libbabeltrace, vpnc, psmisc, net-snmp-libs, xorg-x11-drv-libinput, libsss_certmap, libblockdev- mpath, cairo, libgcc, gdisk, ilmbase, perl-Compress-Bzip2, poppler, libstemmer, djvulibre-libs, marco-libs, claws-mail, ibus-libzhuyin, fftw-libs-double, net-tools, ModemManager, abrt-gui, ibus-m17n, qemu- img, qt5-qtbase-gui, sgpio, orc, libidn2, libuuid, ocaml, libarchive, libfreehand, ibus-gtk3, ibus-gtk2, python2-libselinux, cryptsetup, udisks2, clucene-contribs-lib, paps-libs, tcp_wrappers, xz, libXcomposite, caja-sendto, vconfig, mtools, beesu, vim-minimal, harfbuzz-icu, libplist, gstreamer-tools, xdg-user-dirs, glusterfs- libs, spice-server, gdk-pixbuf2, gupnp, authconfig, libevent, redland, python2-cccolutils, tcpdump, gnome-characters, control-center, libblockdev-kbd, imsettings-qt, libblockdev, librdmacm, lua-socket, dconf, xz-libs, dbus-glib, PackageKit-gtk3-module, libdvdnav, libcap, libvirt-daemon-driver-storage-zfs, libwbclient, libvirt-daemon-driver- storage-gluster, numad, mod_http2, libthai, fakeroot, gnome-session, nss-tools, adcli, libtirpc, python2-gpg, libsmartcols, gsound, fakeroot-libs, sane-backends-drivers-cameras, pluma, xfburn, os- prober, ethtool, libreofficekit, libfprint, systemd-libs, cpio, libfdt, util-linux, libburn, imsettings, OpenEXR-libs, krb5-libs, gnome-online-accounts, libconfig, enca, libblockdev-part, libpciaccess, clucene-core, libsss_autofs, kmod, NetworkManager-ssh- gnome, NetworkManager-pptp, libetonyek, plymouth, gnome-user-share, sssd-client, libgxps, gnome-bluetooth, libpagemaker, highlight, libxkbcommon, device-mapper-multipath-libs, yajl, lockdev, cups- filters-libs, poppler-utils, lpsolve, gnome-terminal-nautilus, xorg-x11-server-utils, gnupg2, libstorj, evince-libs, libepubgen, libdnf, abrt-addon-pstoreoops, gnome-keyring, pulseaudio-libs-glib2, libnice-gstreamer1, nm-connection-editor, mate-disk-usage-analyzer, python3-pyparted, libudisks2, gstreamer1-plugins-bad-free, NetworkManager-libreswan-gnome, python3-setools, clutter, zenity, rhythmbox, chkconfig, libgnome-keyring, hostname, iscsi-initiator- utils, gparted, librados2, libvirt-daemon-driver-storage-mpath, pam, python2-gstreamer, liborcus, openldap, evince-nautilus, ipcalc, NetworkManager-team, speex, libvirt-daemon-driver-storage-logical, ibus-wayland, neon, rest, libsamplerate, python2-lxml, samba-libs, boost-iostreams, geocode-glib, samba, libwpg, zfs-fuse, imsettings- mate, libusbmuxd, perl-Unicode-Normalize, gperftools-libs, libimobiledevice, lzop, NetworkManager-wwan, polkit-pkla-compat, libmtp, compface, librevenge, hexchat, nspr, gjs, python3-gobject- base, gnome-settings-daemon, dnsmasq, geoclue2-libs, libXfixes, nekovm, libblkid, libcdio, NetworkManager-l2tp, rsync, rpm, webkitgtk4-jsc, lua-libs, abrt-addon-coredump-helper, soundtouch, xorg-x11-drv-evdev, libpeas-gtk, libXinerama, libteam, vim-enhanced, libcmis, elfutils-libs, acl, iodine-client, mate-panel-libs, libcangjie, libkadm5, ocaml-runtime, libphodav, gstreamer-plugins- base, libgee, libXxf86vm, mesa-libEGL, systemd-pam, libyui-mga-qt, perl-Storable, perl-Digest-MD5, gvfs-gphoto2, perl-Sort-Key, libvirt- daemon-driver-storage-rbd, libnfsidmap, nss-util, libsemanage, cracklib, mozjs52, systemd-container, libcomps, at, gtk3-immodule-xim, libblockdev-fs, java-1.8.0-openjdk-headless, libnma, gettext, pcre2-utf32, soxr, espeak, libvirt-gobject, libutempter, libmetalink, slang, gvfs-afp, gnome-keyring-pam, pulseaudio, e2fsprogs, libcdio- paranoia, grub2-tools-minimal, cpp, libksba, libwayland-server, virglrenderer, gmime30, gdbm, libpurple, osinfo-db-tools, libsndfile, libvisio, bzip2-libs, NetworkManager-iodine-gnome, sshpass, gnutls, libyui-mga-gtk, device-mapper-persistent-data, ykpers, libselinux- utils, mate-calc, perl-Scalar-List-Utils, dosfstools, rng-tools, gnome-abrt, libspectre, compat-openssl10-pkcs11-helper, nano, keyutils-libs, libproxy, libreoffice-math, libtimezonemap, audit-libs- python3, perl-Data-Dumper, glusterfs-fuse, plymouth-graphics-libs, pidgin, anaconda-core, libmatemixer, libatasmart, fortune-mod, mlocate, file-libs, grub2-tools, avahi-glib, mokutil, libblockdev- swap, libnetfilter_conntrack, python3-gobject, libev, frei0r-plugins, fprintd-pam, gmime, libusbx, NetworkManager-openvpn-gnome, qrencode- libs, libICE, libgexiv2, drpm, createrepo_c-libs, grilo, perl- Compress-Raw-Zlib, speexdsp, upower, p7zip, libreoffice-x11, nautilus, xcb-util-wm, gtk2-devel, atk, dbxtool, alsa-lib, libwnck3, python2-gobject, gtkmm24, libvirt-daemon-driver-storage-disk, brasero- libs, mesa-dri-drivers, pyliblzma, python3-abrt, libgnomekbd, NetworkManager-ssh, ocaml-ocamlbuild, ibus-rawcode, pciutils, libini_config, openssh-clients, libX11, mate-desktop-libs, celt051, kyotocabinet-libs, python3-pwquality, gvfs-mtp, python3-cryptography, systemd, u2f-hidraw-policy, libnl3, libnatpmp, libidn, grubby, python3-libreport, epiphany-runtime, libbytesize, samba-common-tools, qemu-block-rbd, python3-systemd, mate-panel, libnl3-cli, ibus-libs, python2-libcomps, audit-libs, cyrus-sasl-devel, bluez, gettext-libs, python2-cffi, cups, libref_array, gvfs-afc, switcheroo-control, fwupd, raptor2, libyui, libcrypt-nss, plymouth-plugin-two-step, sbc, qt-x11, libsane-hpaio, libhangul, bash, poppler-glib, libgpod, seahorse, libblockdev-lvm, lvm2, harfbuzz, caja-open-terminal, dmraid, python3-wrapt, gvfs-client, NetworkManager-libnm, python2-libs, ibus- qt, gnome-boxes, ocaml-findlib, lrzsz, libglvnd-egl, libunwind, unbound-libs, dhcp-libs, libtalloc, libtar, hypervkvpd, libepoxy, perl-Variable-Magic, man-db, python2-dbus, gedit, libvirt-daemon- driver-storage-core, libzapojit, mesa-libgbm, boost-locale, liblogging-stdlog, timedatex, fltk, xdg-desktop-portal, python3-pycurl, sssd-nfs-idmap, rasqal, wireless-tools, libdb, passwd, cups-pk-helper, quota, kmod-libs, libdv, gutenprint-libs, lm_sensors- libs, libreoffice-writer, desktop-file-utils, libXdamage, xorg-x11-utils, libmwaw, libusal, libcryptui, dleyna-connector-dbus, gtkmm30, libxfce4ui, gobject-introspection, libpwquality, fontconfig, mate-applets, libblockdev-dm, python3-sip, meanwhile, perl-Math- BigInt-FastCalc, evince-djvu, grep, libdaemon, mariadb-connector-c, evince, flatpak, python3-librepo, pkgconf, vino, json-c, sed, sssd- ipa, pygtk2-libglade, perl-threads-shared, glib-networking, NetworkManager-vpnc-gnome, python3-qt5-base, kpartx, libpng, ghostscript-core, sane-backends-libs, python3-pillow, ostree-libs, cyrus-sasl, hardlink, libcollection, pakchois, libgcrypt, libXNVCtrl, cairomm, perl-Unicode-UTF8, nss-softokn, geoclue2, lsof, binutils, libreoffice-impress, gnome-online-miners, gucharmap, adwaita-qt4, adwaita-qt5, xorg-x11-server-Xorg, usbmuxd, libmbim, perl-IO, libverto, glibmm24, libXScrnSaver, realmd, libmspub, ncurses, nfs- utils, graphite2, python3-kerberos, perl-version, libreport-plugin- kerneloops, gstreamer-plugins-bad-free, gmp, sssd-krb5-common, volume_key-libs, b43-fwcutter, farstream02, mate-settings-daemon, alsa-plugins-pulseaudio, perl-interpreter, bluez-cups, libcurl, coreutils, libcap-ng, gvfs, dbus-x11, pinentry, libvirt-daemon-driver- storage-scsi, librepo, nautilus-extensions, qemu-common, gsm, libuv, boost-filesystem, libtevent, libchamplain, libglvnd, gnome-documents- libs, boost-system, libpcap, wxBase3, im-chooser-common, snappy, marco, libgadu, clutter-gst2, clutter-gst3, cyrus-sasl-lib, atril, libdrm, genisoimage, mate-applet-softupd, pcre2, mate-control-center, xmlrpc-c, jsoncpp, perl-TermReadKey, protobuf-c, rygel, libpng-devel, python3-PyYAML, libvirt-glib, telepathy-logger, libssh, GConf2, glibc, flatpak-libs, fipscheck, bc, gtk-vnc2, gnome-calculator, wget, openssl, libreport-web, libgomp, libexif, libvirt-daemon-driver- secret, tigervnc, libgusb, glib2, python2-libxml2, qemu- system-x86-core, ImageMagick-libs, startup-notification, pcre2-utf16, libmnl, libzmf, libmng, nss, pcre, libchamplain-gtk, tcp_wrappers- libs, sane-backends, gstreamer1-plugins-base, speech-dispatcher, pciutils-libs, libiptcdata, libmpc, libXi, file-roller, openjpeg2, flac-libs, libXt, libXv, libexttextcat, info, libnfnetlink, libiec61883, gstreamer, device-mapper-event, exo, libreport-plugin- bugzilla, qt5-qtbase, libpskc, linux-atm, ibus, jwhois, qemu-block- dmg, libsss_sudo, curl, yelp-libs, cmake, libdmapsharing, gcc-gdb- plugin, caja-actions, fipscheck-lib, pilot-link-libs, mate-search- tool, python2-pycurl, dos2unix, python3-setproctitle, paps, libstaroffice, abrt-tui, ustr, abrt-addon-xorg, libdhash, gucharmap- libs, mate-power-manager, caribou, sssd-proxy, imsettings-libs, totem, gd, gc, python3-cups, libxshmfence, libreport-plugin-systemd-journal, gstreamer1-plugins-ugly-free, unzip, gtk2, gtk3, libmatekbd, libv4l, atkmm, npth, perl-Params-Util, libyaml, gspell, xcb-util-image, m17n- lib, mozjs17, libfilezilla, libblockdev-mdraid, glusterfs, exiv2-libs, libunistring, dleyna-server, qgnomeplatform, gstreamer1-plugins-good, python2-rpm, libasyncns, qemu-block-curl, device-mapper-multipath, c-ares, xmlsec1-openssl, python2-cairo, gfbgraph, NetworkManager-pptp- gnome, jansson, bind-utils, librsvg2, firefox, apr, libsss_nss_idmap, gupnp-dlna, trousers-lib, zip, webrtc-audio-processing, bcache-tools, libproxy-mozjs, python3-psutil, mate-menus-libs, libqxp, harfbuzz- devel, bubblewrap, libtasn1, jbigkit-libs, libe-book, alsa-utils, sqlite, tar, sudo, speech-dispatcher-espeak, dhcp-client, fprintd, pinentry-gtk, gcc, dwz, xorg-x11-drv-qxl, gcr, ebtables, libyui-qt, avahi-libs, pigz, libquvi, gvfs-archive, libao, perl-libs, lz4, kbd, libreoffice-core, gupnp-igd, libwayland-cursor, openvpn, libwacom, python2-kerberos, pango, libss, krb5-devel, mod_dnssd, dbus, polkit- libs, perl-threads, perl-Params-Validate, python2-newt, pangomm, mesa- libxatracker, nss-sysinit, LibRaw, nss-mdns, python3-cffi, pygtksourceview, at-spi2-core, libvirt-daemon-driver-network, glibc- common, liblockfile, gnome-autoar, python3-libxml2, libnfs, stoken- libs, gnome-contacts, libiscsi, groff-base, python-pwquality, libusb, atril-caja, mesa-libGL, abrt-addon-ccpp, libldb, bind-libs-lite, NetworkManager-vpnc, libvirt-daemon-driver-nodedev, libipt, libcanberra, pcsc-lite, mate-media, PackageKit-gstreamer-plugin, libgudev, xorg-x11-drv-wacom, libsrtp, perl-Package-Stash-XS, samba- client-libs, which, boost-chrono, zlib, samba-client, libaio, lua- expat, gstreamer-plugins-espeak, libxfce4util, libshout, brlapi, createrepo_c, libreport-gtk, liboauth, xmlsec1, isns-utils-libs, libwsman1, krb5-workstation, mcpp, nmap-ncat, lksctp-tools, libgltf, usb_modeswitch, mythes, evolution, NetworkManager-wifi, qt, libfastjson, kexec-tools, mate-desktop, mate-terminal, libpeas-loader- python, caja-wallpaper, teamd, libvorbis, lightdm-gobject, NetworkManager-openconnect-gnome, rpcbind, pcre-cpp, python3-libselinux, libodfgen, liblouis, exiv2, iptables, libestr, lua, caja, hunspell, libpeas-loader-python3, llvm-libs, gnome-logs, pulseaudio-module-bluetooth, libvirt-libs, passwdqc, libXft, libattr, hyphen, p7zip-plugins, gnupg2-smime, webkitgtk4, caja-share, gnome- software, bind99-libs, iptstate, glib2-devel, libreport-plugin- ureport, radvd, python3-lxml, python3-libs, glusterfs-cli, perl- PathTools, ipset-libs, perl-Devel-Size, bluez-tools, mozjs38, gnome- menus, glusterfs-client-xlators, libreoffice-pyuno, file, libxml2, libgepub, libreoffice-ure, iscsi-initiator-utils-iscsiuio, slick- greeter, cyrus-sasl-gssapi, mpage, libargon2, libnm-gtk, mousetweaks, libvirt-daemon, libsecret, gtk2-engines, p11-kit-trust, NetworkManager-bluetooth, augeas-libs, libsysfs, audit, abrt-dbus, gnome-desktop3, gdk-pixbuf2-modules, at-spi2-atk, xfconf, xen-libs, libisofs, nss-pem, vim-common, lzo, less, cifs-utils, libvpx, tcl, rpm-build-libs, libnghttp2, util-linux-user, totem-nautilus, libsolv, exempi, libxkbcommon-x11, libtdb, python3-gpg, libXdmcp, perl-Socket, apr-util, libvisual, python3, python2, gpm-libs, minicom, xorg-x11 -server-Xwayland, perl-DB_File, shared-mime-info, httpd-tools, SDL2, libsigsegv, boost-thread, caribou-gtk2-module, grilo-plugins, shadow- utils, boost-random, libcgroup, libXau, netcf-libs, libgdata, pulseaudio-module-x11, dmidecode, python3-libcomps, libjpeg-turbo, spice-gtk3, libmount, spice-vdagent, xorg-x11-drv-fbdev, libqb, libavc1394, lldpad, libtiff, python3-libsemanage, sg3_utils-libs, ima- evm-utils, mate-polkit, ed, libmx, python2-gobject-base, grub2-tools- extra, transmission-common, openssh-server, mutter, taglib, libXext, libblockdev-utils, ModemManager-glib, dracut, ostree, device-mapper- event-libs, initscripts, cdparanoia-libs, libieee1284, wxGTK3, libndp, usbutils, bzip2, elfutils-libelf, nss-softokn-freebl, open-vm-tools, evolution-ews, libtool-ltdl, readline, eog, yelp, xorg-x11-drv-intel, eom, abrt-java-connector, passwdqc-lib, parole), /usr/lib/.build-id/c0 (alsa-utils, virglrenderer, qemu-block-iscsi, file-libs, sed, rsyslog, trousers-lib, libreoffice-core, xorg-x11-server-Xorg, httpd, systemd, grilo-plugins, glibc, python2-cryptography, python3-qt5-base, glib2-devel, pam, iptables, psacct, python3-libs, libXxf86misc, ncurses-libs, gstreamer-plugins-good, cifs-utils, gnome-keyring, isdn4k-utils, libnl3-cli, libselinux-utils), /usr/lib/.build- id/14(gstreamer1-plugins-bad-free, ImageMagick-libs, libcdio, grub2-tools, libgphoto2, xorg-x11-server-Xorg, rpm-plugin-selinux, grilo-plugins, samba-client-libs, atril-libs, shadow-utils, coreutils, folks, iptables, wireless-tools, systemd-udev, luajit, pulseaudio- module-bluetooth, fcoe-utils, libXfont, gstreamer, libnice-gstreamer1, libexif, pipewire, libksba, libical, binutils, qt5-qtbase) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in opam- installer , opam-debuginfo , opam-debugsource [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: opam-2.0.0-0.3.beta5.fc28.x86_64.rpm opam-installer-2.0.0-0.3.beta5.fc28.x86_64.rpm opam-debuginfo-2.0.0-0.3.beta5.fc28.x86_64.rpm opam-debugsource-2.0.0-0.3.beta5.fc28.x86_64.rpm opam-2.0.0-0.3.beta5.fc28.src.rpm opam.x86_64: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce opam.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/opam opam.x86_64: W: only-non-binary-in-usr-lib opam-installer.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/opam-installer opam-installer.x86_64: W: only-non-binary-in-usr-lib opam-installer.x86_64: W: ocaml-naming-policy-not-applied /usr/lib64/ocaml/opam-installer opam-debugsource.x86_64: W: no-documentation opam.src: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce opam.src:71: W: macro-in-comment %check 5 packages and 0 specfiles checked; 2 errors, 7 warnings. Rpmlint (debuginfo) ------------------- Checking: opam-installer-debuginfo-2.0.0-0.3.beta5.fc28.x86_64.rpm opam-debuginfo-2.0.0-0.3.beta5.fc28.x86_64.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory opam-installer-debuginfo.x86_64: W: invalid-url URL: https://github.com/ocaml/opam <urlopen error [Errno -2] Name or service not known> opam.x86_64: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce opam.x86_64: W: invalid-url URL: https://github.com/ocaml/opam <urlopen error [Errno -2] Name or service not known> opam.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/opam opam.x86_64: W: only-non-binary-in-usr-lib opam-debugsource.x86_64: W: invalid-url URL: https://github.com/ocaml/opam <urlopen error [Errno -2] Name or service not known> opam-debugsource.x86_64: W: no-documentation opam-installer.x86_64: W: invalid-url URL: https://github.com/ocaml/opam <urlopen error [Errno -2] Name or service not known> opam-installer.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/opam-installer opam-installer.x86_64: W: only-non-binary-in-usr-lib opam-installer.x86_64: W: ocaml-naming-policy-not-applied /usr/lib64/ocaml/opam-installer opam-debuginfo.x86_64: W: invalid-url URL: https://github.com/ocaml/opam <urlopen error [Errno -2] Name or service not known> 5 packages and 0 specfiles checked; 2 errors, 10 warnings. Requires -------- opam (rpmlib, GLIBC filtered): libc.so.6()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libz.so.1()(64bit) opam-installer(x86-64) rtld(GNU_HASH) opam-debugsource (rpmlib, GLIBC filtered): opam-installer (rpmlib, GLIBC filtered): libc.so.6()(64bit) libdl.so.2()(64bit) libm.so.6()(64bit) rtld(GNU_HASH) opam-debuginfo (rpmlib, GLIBC filtered): Provides -------- opam: opam opam(x86-64) opam-debugsource: opam-debugsource opam-debugsource(x86-64) opam-installer: opam-installer opam-installer(x86-64) opam-debuginfo: debuginfo(build-id) opam-debuginfo opam-debuginfo(x86-64) Source checksums ---------------- https://github.com/ocaml/opam/archive/2.0.0-beta5/opam-2.0.0-beta5.tar.gz : CHECKSUM(SHA256) this package : 08a924e4fe89be36c3f939dfdeabf028a62c1f0ea0455ecf9a1e9cd383f171ac CHECKSUM(SHA256) upstream package : 08a924e4fe89be36c3f939dfdeabf028a62c1f0ea0455ecf9a1e9cd383f171ac Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1501992 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Turn out there is reasons for using LGPLv2+. Let's wait for upstream's response in https://github.com/ocaml/opam/issues/3125
Alright, resolved. Please apply https://github.com/ocaml/opam/commit/e3b5576d2cab0b44ec146f5da706b762bcb538b4.patch as patch and keep the license field as v2.
Hm... the tests were passing previously for beta4 on F26, but I just attempted to run them locally on Fedora 27 (since ocaml-re is only available for Rawhide at the moment, I have a build of it and dose3 here: https://copr.fedorainfracloud.org/coprs/tc01/ocaml-utils/), and now they also fail. https://paste.fedoraproject.org/paste/5NyR0-5GGvaxZRa0ZHt9FQ I'll have to look into more detail later, but at first glance it looks like something to do with the internal solver is broken.
Oh, nevermind. The build of ocaml-mccs on F27 is also out of date, that appeared to have been the issue. (I guess I should set up a Rawhide VM, or something). When I updated mccs, the unit tests all passed. make[2]: Entering directory '/home/bjr/rpmbuild/BUILD/opam-2.0.0-beta5/_build/default/tests' 00 init ..................................... [ OK ] 01 upload ..................................... [ OK ] 02 install-remove ..................................... [ OK ] 03 list ..................................... [ OK ] 04 install-opt ..................................... [ OK ] 05 list ..................................... [ OK ] 06 install ..................................... [ OK ] 07 list ..................................... [ OK ] 08 reinstall ..................................... [ OK ] 09 list ..................................... [ OK ] 10 upload-new ..................................... [ OK ] 11 list ..................................... [ OK ] 12 upgrade ..................................... [ OK ] 13 list ..................................... [ OK ] 14 downgrade ..................................... [ OK ] 15 list ..................................... [ OK ] 16 switch-alias ..................................... [ OK ] 17 list ..................................... [ OK ] 18 switch-env-packages ..................................... [ OK ] 19 repo ..................................... [ OK ] 20 list ..................................... [ OK ] So it looks like some sort of mock-specific failure. I'll apply the license patch momentarily and upload a new SRPM.
Spec URL: https://tc01.fedorapeople.org/ocaml/opam/opam.spec SRPM URL: https://tc01.fedorapeople.org/ocaml/opam/opam-2.0.0-0.4.beta5.fc27.src.rpm - Add upstream patch correctly indicating LGPLv2 license of a few files.
Package accepted. Thanks for the testing! Be aware that there is a OCaml 4.06 update going on, and there are some packages need to be rebuilt on rawhide, so building opam may fail if a dep hasn't rebuilt yet. Just make sure to do a scratch build before the actual build.
(In reply to Ben Rosser from comment #8) > (I guess I should set up a Rawhide VM, or > something). This would be a good idea actually, since Rawhide is now on OCaml 4.06 which has significant changes due to the safe-string default. You don't actually need to set up a full VM however. In practice you can just pick the Rawhide packages for Fedora 27: # dnf install feora-repos-rawhide Make sure that ‘enabled=0’ everywhere in /etc/yum.repos.d/fedora-rawhide.repo, otherwise you'll get Rawhide packages for everything which you don't usually want. Then do: # dnf update --best ocaml\* --enablerepo=rawhide Make sure you check the package selection before confirming installation, in case you accidentally upgrade major Rawhide components which (depending on your tolerance for the bleeding edge) might not be a good idea.
Thanks for the review! I've imported and built the package in Rawhide.
Ben, would you submit opam to f26 and f27 as well? I have a few packages that want to be made available there.
Unfortunately it's not quite that simple. First, ocaml-re would need to be built for earlier Fedora versions; it's currently only in master (https://src.fedoraproject.org/rpms/ocaml-re). Rich would need to do this; I don't have ACLs on the package. (dose3 would also need to be built for the earlier releases, once re is available). After that... I wasn't able to compile the latest opam release on F26, so I think I would need to build a slightly older version (beta3 or beta4). I think there's a similar situation on Fedora 27 but I'm not sure.
(In reply to Ben Rosser from comment #14) > Unfortunately it's not quite that simple. First, ocaml-re would need to be > built for earlier Fedora versions; it's currently only in master > (https://src.fedoraproject.org/rpms/ocaml-re). Rich would need to do this; I > don't have ACLs on the package. (dose3 would also need to be built for the > earlier releases, once re is available). > > After that... I wasn't able to compile the latest opam release on F26, so I > think I would need to build a slightly older version (beta3 or beta4). I > think there's a similar situation on Fedora 27 but I'm not sure. Is it just ocaml-re or other packages? I'll send a request for branches for ocaml-re only for now.
I see you mentioned ocaml-dose3 too. I have requested f26 & f27 branches for both packages, but AFAIK it may take some time for those requests to be processed.
I have now created ocaml-re & ocaml-dose3 branches for f26 & f27 and done all 4 builds: https://bodhi.fedoraproject.org/updates/FEDORA-2018-c56b4822b3 https://bodhi.fedoraproject.org/updates/FEDORA-2018-043eee3c5e https://bodhi.fedoraproject.org/updates/FEDORA-2018-8ad6a42912 https://bodhi.fedoraproject.org/updates/FEDORA-2018-88034d4413 If you want to build against these packages before they go into stable, you will need to request build overrides via https://bodhi.fedoraproject.org/overrides/new
Thanks, Richard! Ben: It would be great to have opam on at least f27. If there is any build issue, upstream need to be notified too.
Great, thanks Richard! I'll look into building opam sometime this evening. The failures seemed to have something to do with a combination of jbuilder + ocaml versions. Or at least, this was my assumption given that things still worked on Rawhide.
opam-2.0.0-0.5.beta6.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-9248f0bdff
opam is built for F27. Building for F26 may take a bit longer as the updates for dose3 and re only just got pushed to testing.
opam-2.0.0-0.5.beta6.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-9248f0bdff
While we appreciate Fedora packaging opam, please do note that the opam2 beta series is still subject to backwards-incompatible changes until we release opam 2.0.0. When do you anticipate Fedora 27 being released? We would rather not have to support opam2 betas in the long term, so perhaps a warning message in the RPM to this effect might be appropriate?
F27 was released in November 2017. F28 will be released in May. We can push updates including complete new versions to Fedora 27 until EOL so I don't think there's any problem here.
> We can push updates including complete new versions to Fedora 27 until EOL so I don't think there's any problem here. Oh that's perfect, thanks! We're working hard on getting opam2 out of the door :-)
opam-2.0.0-0.5.beta6.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.