Bug 1502639 - Enable unit tests for libvirt-glib
Summary: Enable unit tests for libvirt-glib
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: libvirt-glib
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Daniel Berrangé
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-10-16 11:33 UTC by Marek Kašík
Modified: 2017-10-30 17:00 UTC (History)
3 users (show)

Fixed In Version: libvirt-glib-1.0.0-5.fc28
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-10-30 17:00:11 UTC
Type: Bug


Attachments (Terms of Use)

Description Marek Kašík 2017-10-16 11:33:09 UTC
libvirt-glib package has unit tests which can be evaluated as a part of build in koji. It is generally recommended to run these tests so that some problems can be cought soon enough before the package gets to the users.
Please, enable these tests in your package.
I can enable the tests for this package if you want and do the first build with them.

I've tested this package with local mock and the build passes as well as the tests (I will perform scratch build in Koji before pushing this change).

Comment 1 Christophe Fergeau 2017-10-16 13:04:49 UTC
Sure, would be great if you can enable them!

Comment 2 Daniel Berrangé 2017-10-16 13:06:05 UTC
NB, any spec file changes should be upstream first, or they're liable to be lost on next rebase.

Comment 3 Marek Kašík 2017-10-16 13:42:58 UTC
Thank you both, I'll prepare a patch and will post him to libvir-list then.

Comment 4 Marek Kašík 2017-10-30 17:00:11 UTC
The patch was accepted so I've pushed the same change to rawhide's spec file and done a new build of libvirt-glib.
Thanks.


Note You need to log in before you can comment on or make changes to this bug.