Created attachment 1339809 [details] expected Description of problem: Jenkins DeploymentConfig in the templates are missing the label `app=jenkins`, which as of 3.6 is used to change the way the app is displayed in the web console Version-Release number of selected component (if applicable): OCP v3.6.173.0.21 Templates don't appear to have a version? How reproducible: 100% Steps to Reproduce: 1. apply the template 2. look at the web console 3. Actual results: Expected results: see expected attachment Additional info:
Created attachment 1339810 [details] actual
added attachments for expected vs actual screenshots
the app label is not the responsibility of the template, the oc new-app command and web console will add it to all resources in a template, when provisioning a template. How did you instantiate the template?
Ansible automation that calls `oc process | oc apply`. We'll look to update that automation if you do not believe this information should be kept in the template itself. Thanks Ben.
Let me discuss it w/ Sam Padgett. Historically that label has been something that was applied by the tooling, but it's possible it would make sense to just hardcode it into the templates so that provisoning via oc process will still get the label (and also the template service broker which likely does not apply the app label today). I'm not sure if we want to codify that label into our templates or not.
Ben anything further here? We need to make a decision on our side whether to add this to our automation
we're going to add the label, but it's not my top priority. you're welcome to submit a PR.
I'll take you up on that offer. What is the proper location to make a PR? I see: https://github.com/openshift/openshift-ansible/tree/master/roles/openshift_examples/files/examples and https://github.com/openshift/origin/blob/master/examples/jenkins
the ones you need to change are in: https://github.com/openshift/origin/blob/master/examples/jenkins but you'll also need to run hack/update-generated-bindata.sh in origin when you change the files. (the ansible repo will pick up from the origin repo)
low hanging fruit for you, gabe.
Ben / Gabe: I'm starting to realize this is bigger than just Jenkins. All the out of the box templates need to be able to set the app label. Another example: PostgreSQL being used for an app. It's nice to group them in the UI, so that an app and its DB are presented together. Right now, this isn't possible. How would you like this bigger item tracked?
I can update the other templates in https://github.com/openshift/origin/blob/master/examples/quickstarts and db-templates Note, the analogous location in the openshift ansible repo has dotnet repos. I suspect that comes from the scl team. If so, I think Justin needs to work with them to get that updated. Also, the cfme and xpaas templates are managed by those respective teams as well. I would similarly propose Justin would need to work with them as well. Thoughts?
PR https://github.com/openshift/origin/pull/17224 has been opened to address this bug currently PR only targeted to origin/master; advise if addition targets needed
Ben, I think you may have been off cc: and were not initially advised of comments 11 and 12
The PR from #Comment 13 has merged and per discussion with Ben we are simply targeting to 3.8. Per process marking this OCP bug modified
Ben - do you think this bug requires a doc update ?
if you mean doc text in the bug, yes. if you mean product docs, no.
Meant the former, thanks.
I am good with the changes that have merged. Thanks Gabe and Ben. (Commenting to clear the need info flag.)
The updates take effect on openshift cluster v3.9.0-0.19.0 Can't reproduce this bug
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2018:0489