Bug 1503269 - User without permissions on destination SD can move disk
Summary: User without permissions on destination SD can move disk
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: AAA
Version: 4.2.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.2.2
: 4.2.2.2
Assignee: Idan Shaby
QA Contact: Radim Hrazdil
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-10-17 17:19 UTC by Gonza
Modified: 2018-03-29 11:07 UTC (History)
5 users (show)

Fixed In Version: ovirt-engine-4.2.2
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-03-29 11:07:28 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.2+
rule-engine: blocker+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 87003 0 master MERGED backend: require user permissions on target SD when moving a disk 2018-02-01 14:19:12 UTC

Description Gonza 2017-10-17 17:19:59 UTC
Description of problem:
A user with UserVMManager role on a VM and StorageAdmin role on source SD can move it's disk to an SD without permissions.

Version-Release number of selected component (if applicable):
ovirt-engine-4.2.0-0.0.master.20171012160334.git6fb4578.el7.centos.noarch

How reproducible:
100%

Steps to Reproduce:
1. Create VM from blank template and grant UserVMManager permissions to 'user1'
2. Grant StorageAdmin permission on source SD to 'user1'
3. With 'user1', move disk from source SD to destination SD without permissions

Actual results:
'user1' is able to move disk

Expected results:
'user1' should not be able to move disk to an SD without permissions

Comment 1 Red Hat Bugzilla Rules Engine 2017-12-14 12:28:46 UTC
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 2 Radim Hrazdil 2018-03-07 08:25:08 UTC
Verified that after following steps in the description, the user 'test1' with UserVMManager permission to a VM and StorageAdmin permission to source SD cannot move disk to another SD. Message 'Error while executing action: User is not authorized to perform this action.' is displayed.

Software Version:4.2.2.1-0.1.el7

Comment 3 Radim Hrazdil 2018-03-07 08:41:53 UTC
Also verified for Software Version:4.2.2.2-0.1.el7.

Comment 4 Sandro Bonazzola 2018-03-29 11:07:28 UTC
This bugzilla is included in oVirt 4.2.2 release, published on March 28th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.