Spec URL: https://raw.githubusercontent.com/siwinski/rpms/3eb4f4323f283cbfe6d1b9d45a285c2aabec2189/php-goaop-parser-reflection/php-goaop-parser-reflection.spec SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-goaop-parser-reflection-1.4.0-1.fc26.src.rpm Description: Provides reflection information, based on raw source Fedora Account System Username: siwinski
F26 scratch build OK /dev/shm/extras/SRPMS/php-goaop-parser-reflection-1.4.0-1.fc25.remi.src.rpm F28 scratch build OK https://koji.fedoraproject.org/koji/taskinfo?taskID=22780170 I have tons of failure with fedora-review build (rawhide), strangely this one pull phpparser v1...
Running local bulid with phpparser 3 is ok Running local bulid with phpparser 2 is KO 1) Go\ParserReflection\ReflectionFileTest::testIsStrictType with data set "/Stub/FileWithClasses71.php" ('/Stub/FileWithClasses71.php', true) PhpParser\Error: Syntax error, unexpected '?', expecting T_VARIABLE on line 20 Running local bulid with phpparser 1 is KO 1) Go\ParserReflection\ReflectionClassTest::testGetModifiers with data set "PHP7.0" ('/dev/shm/extras/BUILD/parser-...70.php') PhpParser\Error: Syntax error, unexpected '{', expecting T_STRING on line 15 2) Go\ParserReflection\ReflectionClassTest::testGetModifiers with data set "PHP7.1" ('/dev/shm/extras/BUILD/parser-...71.php') PhpParser\Error: Syntax error, unexpected '{', expecting T_STRING on line 14 - What do you think of raising minimal build dependency on phpparser ? - What do you think of raising minimal runtime dependency on phpparser ? Is this a problem in the drupal stack (ie, is there other package which require another version of phpparser) ?
(In reply to Remi Collet from comment #2) > - What do you think of raising minimal build dependency on phpparser ? > > - What do you think of raising minimal runtime dependency on phpparser ? > Is this a problem in the drupal stack (ie, is there other package which > require another version of phpparser) ? I should be able to do this. I'll verify and update this pkg.
(In reply to Shawn Iwinski from comment #3) > (In reply to Remi Collet from comment #2) > > - What do you think of raising minimal build dependency on phpparser ? > > > > - What do you think of raising minimal runtime dependency on phpparser ? > > Is this a problem in the drupal stack (ie, is there other package which > > require another version of phpparser) ? > > I should be able to do this. I'll verify and update this pkg. Raised Diff: https://github.com/siwinski/rpms/commit/8f37187d6698b443af57cb05b1051feecb625323 Spec URL: https://raw.githubusercontent.com/siwinski/rpms/8f37187d6698b443af57cb05b1051feecb625323/php-goaop-parser-reflection/php-goaop-parser-reflection.spec SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-goaop-parser-reflection-1.4.0-2.fc27.src.rpm
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.