Bug 1505527 - Posix compliance rename test fails on fuse subdir mount
Summary: Posix compliance rename test fails on fuse subdir mount
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: fuse
Version: 3.12
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
Assignee: Amar Tumballi
QA Contact:
URL:
Whiteboard:
Depends On: 1505473
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-10-23 19:21 UTC by Amar Tumballi
Modified: 2017-12-08 17:44 UTC (History)
4 users (show)

Fixed In Version: glusterfs-3.13.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1505473
Environment:
Last Closed: 2017-11-22 10:46:06 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Comment 1 Amar Tumballi 2017-10-23 19:23:43 UTC
Description of problem:
rename/00.t and rename/10.t tests in Posix compliance test suit are failing for fuse subdir mount

Version-Release number of selected component (if applicable):
glusterfs-3.12.2

How reproducible:
2/2

Steps to Reproduce:
1.Create 4*3 Distributed-Replicate volume
2.Mount the volume to fuse client
3.Create a directory inside the mount point
4.Set auth allow permission on the volume for that subdir
5.Mount the subdir to same fuse client
6.Run posix compliance test suit on the subdir

Chown and rename test fails for subdir.
Chown test is a known failure for fuse volume mount (Fails on volume mounted via fuse as well)

Rename test pass on fuse volume mount but fails for fuse sub-dir mount

=================
Test Summary Report
-------------------
/opt/qa/tools/posix-testsuite/tests/rename/00.t  (Wstat: 0 Tests: 79 Failed: 8)
  Failed tests:  6, 11, 13, 20, 26, 31, 33, 44
/opt/qa/tools/posix-testsuite/tests/rename/10.t  (Wstat: 0 Tests: 188 Failed: 27)
  Failed tests:  11, 14, 19, 26, 29, 34, 41, 44, 49, 87
                90, 95, 102, 105, 110, 117, 120, 125, 139
                142, 147, 154, 157, 162, 169, 172, 177
Files=185, Tests=1962, 96 wallclock secs ( 0.78 usr  0.31 sys +  9.14 cusr 13.06 csys = 23.29 CPU)
Result: FAIL
end: 21:24:33
removed posix compliance directories
1
Total 1 tests were successful
Switching over to the previous working directory
Removing /mnt/fuse_mount1/run16899/
rmdir: failed to remove ‘/mnt/fuse_mount1/run16899/’: Directory not empty
rmdir failed:Directory not empty

===================

Actual results:
Rename test of posix compliance test suit fails for subdir

Expected results:
Rename test of posix compliance test suit should pass for subdir as well

Comment 2 Worker Ant 2017-10-23 19:29:52 UTC
REVIEW: https://review.gluster.org/18558 (protocol/server: fix the comparision logic in case of subdir mount) posted (#1) for review on master by Amar Tumballi (amarts)

Comment 3 Worker Ant 2017-10-24 12:21:31 UTC
COMMIT: https://review.gluster.org/18558 committed in master by Jeff Darcy (jeff.us) 
------
commit 2ade36cd98ea0f5bd2a8f619a19c20438318afaf
Author: Amar Tumballi <amarts>
Date:   Mon Oct 23 21:17:52 2017 +0200

    protocol/server: fix the comparision logic in case of subdir mount
    
    without the fix, the stat entry on a file would return inode==1 for
    many files, in case of subdir mount
    
    This happened with the confusion of return value of 'gf_uuid_compare()',
    it is more like strcmp, instead of a gf_boolean return value, and hence
    resulted in the bug.
    
    Change-Id: I31b8cbd95eaa3af5ff916a969458e8e4020c86bb
    BUG: 1505527
    Signed-off-by: Amar Tumballi <amarts>

Comment 4 Worker Ant 2017-10-30 17:41:51 UTC
REVIEW: https://review.gluster.org/18585 (protocol/server: fix the comparision logic in case of subdir mount) posted (#1) for review on release-3.12 by Amar Tumballi

Comment 5 Worker Ant 2017-11-06 11:44:05 UTC
COMMIT: https://review.gluster.org/18585 committed in release-3.12 by  

------------- protocol/server: fix the comparision logic in case of subdir mount

without the fix, the stat entry on a file would return inode==1 for
many files, in case of subdir mount

This happened with the confusion of return value of 'gf_uuid_compare()',
it is more like strcmp, instead of a gf_boolean return value, and hence 
resulted in the bug.

Change-Id: I31b8cbd95eaa3af5ff916a969458e8e4020c86bb
BUG: 1505527
Signed-off-by: Amar Tumballi <amarts>
(cherry picked from commit 2ade36cd98ea0f5bd2a8f619a19c20438318afaf)

Comment 6 Amar Tumballi 2017-11-22 10:46:06 UTC
glusterfs-3.12.3 has the fix

Comment 7 Jiffin 2017-11-29 05:52:32 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-glusterfs-3.12.3, please open a new bug report.

glusterfs-glusterfs-3.12.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-devel/2017-November/053983.html
[2] https://www.gluster.org/pipermail/gluster-users/

Comment 8 Shyamsundar 2017-12-08 17:44:30 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.13.0, please open a new bug report.

glusterfs-3.13.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-December/000087.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.