Bug 1505532 - Error launching hardware dialog: 'NoneType' object is not iterable
Summary: Error launching hardware dialog: 'NoneType' object is not iterable
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: virt-manager
Version: 27
Hardware: Unspecified
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Cole Robinson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1508715 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-10-23 19:40 UTC by Paul Whalen
Modified: 2018-06-26 14:44 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1544479 (view as bug list)
Environment:
Last Closed: 2018-06-26 14:44:08 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Paul Whalen 2017-10-23 19:40:37 UTC
Description of problem:
Attempt to add hardware to an aarch64 guest fails with "Error launching hardware dialog: 'NoneType' object is not iterable"

Version-Release number of selected component (if applicable):
virt-manager-1.4.3-1.fc27.noarch

How reproducible:
Always, reproducible on any arch with an aarch64 guest. 

Steps to Reproduce:
1. Attempt to add hardware to an existing aarch64 guest using virt-manager

Actual results:

Error launching hardware dialog: 'NoneType' object is not iterable

Traceback (most recent call last):
  File "/usr/share/virt-manager/virtManager/details.py", line 1407, in add_hardware
    self.addhw = vmmAddHardware(self.vm, self.is_customize_dialog)
  File "/usr/share/virt-manager/virtManager/addhardware.py", line 120, in __init__
    self._set_initial_state()
  File "/usr/share/virt-manager/virtManager/addhardware.py", line 320, in _set_initial_state
    self._build_panic_models(combo)
  File "/usr/share/virt-manager/virtManager/addhardware.py", line 980, in _build_panic_models
    for m in virtinst.VirtualPanicDevice.get_models(self.vm.get_xmlobj().os):
TypeError: 'NoneType' object is not iterable

Expected results:
Add hardware dialog.

Comment 1 Cole Robinson 2017-10-26 07:44:35 UTC
Thanks for the report, please provide the affected VMs XML. sudo virsh dumpxml $VM-NAME

Comment 2 Paul Whalen 2017-10-26 13:49:56 UTC
The vm didnt get created due to the error. To reproduce, use Virt-Manager to create an AArch64 guest, selecting the "Customize configuration before install." option, then click on "Add Hardware" and you will see the error. It isnt specific to aarch64 and will fail for an armhfp guest as well. x86_64 works as expected.

Comment 3 Cole Robinson 2017-10-27 08:06:25 UTC
Hmm that's an unfortunate bug. Fixed upstream now, I'll do builds next week:

commit f7c8cf9f667f2b0122f5689009d74c94c38c7316
Author: Cole Robinson <crobinso>
Date:   Fri Oct 27 09:42:54 2017 +0200

    devicepanic: Don't return empty model list (bz #1505532)

Comment 4 Jeremy Linton 2017-11-02 16:54:48 UTC
*** Bug 1508715 has been marked as a duplicate of this bug. ***

Comment 5 Sean McNeil 2017-11-17 07:16:44 UTC
This error also occurs for sparc architecture:

New VM ->
Architecture -> sparc
Machine Type -> SS-5
OS Type -> Solaris
Version -> Solaris 9
RAM -> 256
Select customize configuration before install
Click on "+ Add Hardware"

Comment 6 Paul Whalen 2017-11-21 15:32:36 UTC
(In reply to Cole Robinson from comment #3)
> Hmm that's an unfortunate bug. Fixed upstream now, I'll do builds next week:
> 
> commit f7c8cf9f667f2b0122f5689009d74c94c38c7316
> Author: Cole Robinson <crobinso>
> Date:   Fri Oct 27 09:42:54 2017 +0200
> 
>     devicepanic: Don't return empty model list (bz #1505532)

Any update on this?

Comment 7 Cole Robinson 2017-11-21 15:49:23 UTC
Sorry for the delay, I'll do a build today

Comment 8 Fedora Update System 2017-11-22 21:40:02 UTC
virt-manager-1.4.3-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-c617798fcc

Comment 9 Jeremy Linton 2017-11-28 16:13:17 UTC
Verifed that on rawhide/aarch64/hikey I can add devices without this error using:

virt-manager-1.4.3-2.fc28.noarch


Thanks!

Comment 10 Paul Whalen 2017-11-28 16:34:50 UTC
Add hardware working for aarch64 guests using virt-manager-1.4.3-2.fc27. Thanks Cole!

Comment 11 Fedora Update System 2017-12-04 19:03:40 UTC
virt-manager-1.4.3-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.