Bug 1505546 - [EUWE] HTML5 Console Does Not Display From SSUI/OPS UI VMWare
Summary: [EUWE] HTML5 Console Does Not Display From SSUI/OPS UI VMWare
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - Service
Version: 5.7.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.7.4
Assignee: Allen W
QA Contact: Kedar Kulkarni
URL:
Whiteboard: ssui:html5:console
Depends On: 1471158
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-10-23 20:25 UTC by Satoe Imaishi
Modified: 2022-07-09 08:59 UTC (History)
20 users (show)

Fixed In Version: 5.7.4.2
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1471158
Environment:
Last Closed: 2017-12-18 20:30:46 UTC
Category: ---
Cloudforms Team: VMware
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2017:3484 0 normal SHIPPED_LIVE Important: Red Hat CloudForms security, bug fix, and enhancement update 2017-12-19 01:24:16 UTC

Comment 3 Chris Kacerguis 2017-10-26 14:35:08 UTC
New PR to fix: https://github.com/ManageIQ/manageiq-ui-service/pull/1163

Comment 4 CFME Bot 2017-11-14 16:51:09 UTC
New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/1d615385ac898ff205e16db36970e64cd8ef3acb

commit 1d615385ac898ff205e16db36970e64cd8ef3acb
Author:     Jillian Tullo <jtullo>
AuthorDate: Wed Nov 1 13:21:29 2017 -0400
Commit:     Jillian Tullo <jtullo>
CommitDate: Wed Nov 1 13:21:29 2017 -0400

    Add decorator for VNC Console
    
    SUI requires a check on VNC console because the existing decorators lead to a false positive about console enablement for VMWare consoles.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1505546

 app/decorators/vm_or_template_decorator.rb | 4 ++++
 1 file changed, 4 insertions(+)

Comment 5 CFME Bot 2017-11-20 19:11:27 UTC
New commit detected on ManageIQ/manageiq/fine:
https://github.com/ManageIQ/manageiq/commit/23a349555e1205b0db97f6163744ef410d72e5eb

commit 23a349555e1205b0db97f6163744ef410d72e5eb
Author:     Jillian Tullo <jtullo>
AuthorDate: Thu Nov 2 08:36:05 2017 -0400
Commit:     Jillian Tullo <jtullo>
CommitDate: Fri Nov 3 14:50:41 2017 -0400

    Add decorator for VNC Console
    
    SUI requires a check on VNC console because the existing decorators lead to a false positive about console enablement for VMWare consoles.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1505546

 app/controllers/api/subcollections/vms.rb |  3 +++
 spec/requests/api/services_spec.rb        | 12 ++++++++----
 2 files changed, 11 insertions(+), 4 deletions(-)

Comment 6 Kedar Kulkarni 2017-11-27 18:05:59 UTC
On 5.7.4.1,  SSUI, I could still see HTML5 Console button and clicking it resulted in failure to connect to VM Console. This button should be disabled with appropriate error message.

Comment 7 Allen W 2017-11-27 20:01:31 UTC
Okie dokie, so we have a really real fix api side, as mentioned above, and client side (sui) coming soon, the master, g, f, branches will be fixed here: https://github.com/ManageIQ/manageiq-ui-service/pull/1280

with an E fix, once the above is confirmed

Comment 8 Allen W 2017-11-28 15:02:43 UTC
Heres the aforementioned pr: https://github.com/ManageIQ/manageiq-ui-service/pull/1283

Comment 9 Chris Kacerguis 2017-11-30 15:39:15 UTC
PR for Euwe: 
https://github.com/ManageIQ/manageiq-ui-service/pull/1283

Cannot be merged until this is backported: 
https://github.com/ManageIQ/manageiq/pull/16519

Comment 11 CFME Bot 2017-12-06 18:21:31 UTC
New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/aa404c599509112b5046296e35cd444e91a69c25

commit aa404c599509112b5046296e35cd444e91a69c25
Author:     Jillian Tullo <jtullo>
AuthorDate: Mon Dec 4 09:26:10 2017 -0500
Commit:     Jillian Tullo <jtullo>
CommitDate: Wed Dec 6 12:42:03 2017 -0500

    Add supported_consoles to VM
    
    Euwe version of https://github.com/ManageIQ/manageiq/pull/16519
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1505546

 app/models/container_group.rb                    |   2 +
 app/models/mixins/cockpit_support_mixin.rb       |  31 ++++
 app/models/mixins/supports_feature_mixin.rb      |   9 ++
 app/models/vm.rb                                 |  58 +++++++
 app/models/vm/operations.rb                      |  58 ++++++-
 spec/models/mixins/cockpit_support_mixin_spec.rb |  93 ++++++++++++
 spec/models/vm/operations_spec.rb                | 184 +++++++++++++++++++++++
 spec/models/vm_spec.rb                           |   8 +
 8 files changed, 440 insertions(+), 3 deletions(-)
 create mode 100644 app/models/mixins/cockpit_support_mixin.rb
 create mode 100644 spec/models/mixins/cockpit_support_mixin_spec.rb
 create mode 100644 spec/models/vm/operations_spec.rb

Comment 12 Allen W 2017-12-07 15:59:49 UTC
https://github.com/ManageIQ/manageiq-ui-service/pull/1283

made it in! moving this to post

Comment 15 Kedar Kulkarni 2017-12-08 15:10:55 UTC
Verified in 5.7.4.2
Buttons were disabled in OPS UI and hidden in SUI where applicable.

Comment 18 errata-xmlrpc 2017-12-18 20:30:46 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:3484


Note You need to log in before you can comment on or make changes to this bug.