Description of problem: [UI] - Can't approve operation with 'enter' keyboard button in the setup networks dialog. Pressing the 'OK" button with the 'enter' keyboard in the setup networks dialog does nothing on the latest master. This is a very new regression. Version-Release number of selected component (if applicable): 4.2.0-0.0.master.20171023193344.gitc3b23f6.el7.centos How reproducible: 100% Steps to Reproduce: 1. Try approve any setup networks operation with 'enter' keyboard button only. Actual results: Nothing happens Expected results: Must work
The power management configuration approve dialog doesn't work as well with the 'enter' key board when adding host.
@Vojtech, any chance this is related to the recent infra change? https://gerrit.ovirt.org/#/c/82944/
New VM's network interface dialog affected as well
This regression seems to affect all dialogs, not just the Network ones. What I have found out: - Esc key (dismiss): Chromium 62: Does not work at all. Firefox 56: Works only when some input widget in the dialog has focus. - Enter key (submit): Works only when some input widget in the dialog has focus (both browsers).
This bug report has Keywords: Regression or TestBlocker. Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.
(In reply to Greg Sheremeta from comment #2) > @Vojtech, any chance this is related to the recent infra change? > https://gerrit.ovirt.org/#/c/82944/ Yes, looks like that patch caused this regression. (In reply to Pavel Novotny from comment #4) > This regression seems to affect all dialogs, not just the Network ones. > > What I have found out: > - Esc key (dismiss): > Chromium 62: Does not work at all. > Firefox 56: Works only when some input widget in the dialog has focus. > - Enter key (submit): Works only when some input widget in the dialog has > focus (both browsers). Thanks Pavel for the detailed info. Looks like OVirtBootstrapModal key press handler code isn't picking up key press events when the dialog (one of its child elements) doesn't have focus. When a dialog is opened but not focused, it doesn't work. Working on a fix.
Fix verified on following scenarios: * Hosts / Network Interfaces / Setup Host Networks dialog -> Enter & Escape keys work as expected (regardless if the dialog is focused or not) * Networks / New dialog -> type some name and press Enter key, new network with given name is created as expected [1] [1] previously reported as bug 1485927
Hi Vojtech, Is it going to fix the power management configuration approve dialog when adding host?
Verified in ovirt-engine-4.2.0-0.0.master.20171102200841.gitb7e2bf5.el7.centos.noarch ovirt-engine-webadmin-portal-4.2.0-0.0.master.20171102200841.gitb7e2bf5.el7.centos.noarch The Enter and Esc keys work again as expected. Verified on dialogs with input elements (New VM, New Network, Edit Host, host Setup Networks) as well as on dialogs without any (confirming host PM Configuration). The focus of input elements does not matter. Tested in browsers: Firefox 52.4 ESR Firefox 56 Chromium 62
(In reply to Michael Burman from comment #8) > Hi Vojtech, > > Is it going to fix the power management configuration approve dialog when > adding host? Hi Michael, yes, it's a UI infra fix so it covers all dialogs. Verification scenarios listed in comment #7 are just two specific instances: first one applies to dialog where no input is focused, second one applies to dialog where some input is focused.
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017. Since the problem described in this bug report should be resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report.