Bug 1506327 (qqc2-desktop-style) - Review Request: qqc2-desktop-style - QtQuickControls2 style for consistency between QWidget and QML apps
Summary: Review Request: qqc2-desktop-style - QtQuickControls2 style for consistency b...
Keywords:
Status: CLOSED RAWHIDE
Alias: qqc2-desktop-style
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Grulich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2017-10-25 17:41 UTC by Rex Dieter
Modified: 2017-11-15 22:28 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-11-15 22:28:50 UTC
Type: ---
Embargoed:
jgrulich: fedora-review+


Attachments (Terms of Use)

Description Rex Dieter 2017-10-25 17:41:58 UTC
Spec URL: https://rdieter.fedorapeople.org/rpms/kf5/qqc2-desktop-style.spec
SRPM URL: https://rdieter.fedorapeople.org/rpms/kf5/qqc2-desktop-style-5.39.0-1.fc27.src.rpm
Description: 
This is a style for QtQuickControls 2 that uses QWidget's QStyle for
painting, making possible to achieve an higher degree of consistency
between QWidget-based and QML-based apps.

Fedora Account System Username: rdieter

Scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=22695648

Comment 1 Raphael Groner 2017-10-25 17:59:33 UTC
I can take this in favor of a review swap, maybe.

Comment 2 Jan Grulich 2017-11-13 12:01:58 UTC
1) Naming: ok
2) License: I'm not sure the license is correct. In the plugin I see GPLv2 or GPLv3 and any later version so it should perhaps be (LGPLv3 or GPLv2+) and LGPLv2+.
3) URL: ok
4) Scriptlets: ok, not used and not needed
5) Files section: ok, license file installed

Rpmlint doesn't report any error.

Comment 3 Rex Dieter 2017-11-13 18:20:39 UTC
thanks, branches requested

Comment 4 Gwyn Ciesla 2017-11-13 18:25:20 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/qqc2-desktop-style

Comment 5 Rex Dieter 2017-11-15 22:28:50 UTC
Thanks, imported, will release as part of kf5-5.40.0 set of packages


Note You need to log in before you can comment on or make changes to this bug.