Bug 1506399 - Installer ignores missing overlay
Summary: Installer ignores missing overlay
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Installer
Version: 3.7.0
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
: 3.7.0
Assignee: Steve Milner
QA Contact: Gan Huang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-10-25 21:55 UTC by Chris Evich
Modified: 2017-11-28 22:19 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
undefined
Clone Of:
Environment:
Last Closed: 2017-11-28 22:19:38 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2017:3188 0 normal SHIPPED_LIVE Moderate: Red Hat OpenShift Container Platform 3.7 security, bug, and enhancement update 2017-11-29 02:34:54 UTC

Description Chris Evich 2017-10-25 21:55:06 UTC
Description of problem:
The installer reports missing overlay module (from lsmod | grep overlay).  However, nothing's actually used it yet (fresh reboot) so the module is simply not loaded.  I did a 'modprobe overlay' and now the playbook sees it properly.

Version-Release number of selected component (if applicable):
openshift-installer repo (commit 2055aa066d8219393db64f42afc384c8123f48f2)

How reproducible:
Trivial

Steps to Reproduce:
1. Install RHEL 7.4 VM, fully updated.  Follow pre-setup instructions
2. Clone upstream openshift-installer from github
3. Setup inventory
4. Run the installer playbook

Actual results:
    TASK [docker : Ensure runc is installed] ****************************************************************
    Wednesday 25 October 2017  17:28:34 -0400 (0:00:15.673)       0:08:30.333 *****
    ok: [rhel7-4-a]
     
    TASK [docker : Check that overlay is in the kernel] *****************************************************
    Wednesday 25 October 2017  17:28:49 -0400 (0:00:14.303)       0:08:44.637 *****
    fatal: [rhel7-4-a]: FAILED! => {"changed": true, "cmd": "lsmod | grep overlay", "delta": "0:00:00.006407", "end": "2017-10-25 17:28:48.104876", "failed": true, "rc": 1, "start": "2017-10-25 17:28:48.098469", "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}
    ...ignoring
     
    TASK [docker : Add overlay to modprobe.d] ***************************************************************
    Wednesday 25 October 2017  17:28:49 -0400 (0:00:00.340)       0:08:44.977 *****
    changed: [rhel7-4-a]


Expected results:
    It should find overlay available

Description of problem:

Version-Release number of the following components:
rpm -q openshift-ansible
rpm -q ansible
ansible --version

How reproducible:

Steps to Reproduce:
1.
2.
3.

Actual results:
Please include the entire output from the last TASK line through the end of output if an error is generated

Expected results:

Additional info:
Please attach logs from ansible-playbook with the -vvv flag

Comment 1 Giuseppe Scrivano 2017-10-26 08:07:51 UTC
this is needed by CRI-O.  We noticed that CRI-O would fail if the overlay module is not already loaded.

Comment 2 Steve Milner 2017-10-26 15:42:03 UTC
Speaking with the reporter on IRC it looks like this was a misunderstanding. It's true that this is an 'ignored error' but that is so a variable can be registered and then used to load and configure loading overlay.

If this bit of logic for some reason DOESN'T load and configure auto loading of overlay please reopen the bug with log attached.

Comment 3 Chris Evich 2017-10-26 15:43:44 UTC
Discussed this at length...the playbook is operating as expected.  Though IMHO, "Ignored Errors" scare the hell out of Ansible-n00bs.  Better to put that and related logic into a script and call it with the ansible 'script' module.

Comment 4 Scott Dodson 2017-10-26 16:58:27 UTC
If this is just a status check test then we should set a failed_when so that the playbook exits with returncode of 0.

Comment 5 Steve Milner 2017-10-26 18:10:40 UTC
PR: https://github.com/openshift/openshift-ansible/pull/5901

Just adds ``failed_when: false``.

Comment 7 Gan Huang 2017-10-31 03:20:38 UTC
Verified in openshift-ansible-3.7.0-0.184.0.git.0.d407445.el7.noarch.rpm


TASK [docker : Check that overlay is in the kernel] ****************************
Tuesday 31 October 2017  03:14:47 +0000 (0:00:00.045)       0:00:59.410 ******* 
changed: [qe-ghuang-master-etcd-1.1031-uqb.qe.rhcloud.com] => {"changed": true, "cmd": "lsmod | grep overlay", "delta": "0:00:00.005766", "end": "2017-10-31 03:14:49.093520", "failed": false, "failed_when_result": false, "msg": "non-zero return code", "rc": 1, "start": "2017-10-31 03:14:49.087754", "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}

Comment 10 errata-xmlrpc 2017-11-28 22:19:38 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:3188


Note You need to log in before you can comment on or make changes to this bug.