Spec URL: https://ankursinha.fedorapeople.org/python-rstcheck/python-rstcheck.spec SRPM URL: https://ankursinha.fedorapeople.org/python-rstcheck/python-rstcheck-3.1-1.fc27.src.rpm Description: Checks syntax of reStructuredText and code blocks nested within it Fedora Account System Username: ankursinha
I maintain a copr here from which built rpm's can be tested: https://copr.fedorainfracloud.org/coprs/ankursinha/python-rstcheck/
What's the point of having py2 and py3 binary?
Thanks for taking up the review! Ah, yeh - no need for that here. Updated to only ship py3 binary, spec/srpm: https://ankursinha.fedorapeople.org/python-rstcheck/python-rstcheck.spec https://ankursinha.fedorapeople.org/python-rstcheck/python-rstcheck-3.1-2.fc27.src.rpm
> BuildRequires: python2-devel python3-devel > BuildRequires: python2-docutils python3-docutils > Requires: python2-docutils python3-docutils Move those to appropriate subpackages. > %global sum Checks syntax of reStructuredText and code blocks nested within it you can define Summary and use text using %{summary}. > %{python2_sitelib}/* > %{python3_sitelib}/* Be more specific, by this you start owning some subdirectories you shouldn't.
Updated as per above comments: https://ankursinha.fedorapeople.org/python-rstcheck/python-rstcheck.spec https://ankursinha.fedorapeople.org/python-rstcheck/python-rstcheck-3.1-3.fc27.src.rpm Cheers!
* Missing BuildRequires: pythonX-setuptools > URL: https://github.com/myint/%{srcname} My personal preference to have URL clickable > %{python2_sitelib}/%{srcname}-%{version}-py2.?.egg-info > %{python3_sitelib}/%{srcname}-%{version}-py3.?.egg-info %{python2_sitelib}/%{srcname}-*.egg-info/ %{python3_sitelib}/%{srcname}-*.egg-info/ (note slash at the end) > %{python3_sitelib}/%{srcname}.py* %{python3_sitelib}/%{srcname}.py > %{python3_sitelib}/__pycache__/%{srcname}.cpython*pyc %{python3_sitelib}/__pycache__/%{srcname}.* --- This is trivial to fix during the import. APPROVED.
Thanks for the review! Updated as per above comments: https://ankursinha.fedorapeople.org/python-rstcheck/python-rstcheck.spec https://ankursinha.fedorapeople.org/python-rstcheck/python-rstcheck-3.1-4.fc27.src.rpm Proceeding with fedrepo-req now. Cheers!
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-rstcheck
python-rstcheck-3.1-4.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-81ca3751bc
python-rstcheck-3.1-4.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-49d1798ba8
python-rstcheck-3.1-4.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-49d1798ba8
python-rstcheck-3.1-4.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-81ca3751bc
python-rstcheck-3.1-4.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
python-rstcheck-3.1-4.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.