Hello,

 - Did you forget to put the Version and Release infos?

Version:        XXX
Release:        XXX

⇒

Version:        1.1.0
Release:        1%{?dist}

 - There is no %changelog entry either!

* Thu Oct 26 2017 Carlos Goncalves <cgoncalves> - 1.1.0-1
- Initial RPM release

 - No need to complicate things, use version instead of upstream_version and remove upstream_version definition

%autosetup -n %{name}-%{version}

 - You could use the %{py2_dist/%{py3_dist macros to handle your BR and R. See https://fedoraproject.org/wiki/Packaging:Python#Requires_and_BuildRequires_with_standardized_names

 - BuildRequires:  openstack-macros

There is no package openstack-macros in Fedora repositories. You'll have to package it beforehand.

Carlos,

Initial review:

1. In other packages we have, URL points to a launchpad URL. since Octavia migrated to storyboard, perhaps the URL should be: https://storyboard.openstack.org/#!/project/911

2. You should end up with a separate RPM for tests, see the python-neutronclient spec for reference: https://github.com/rdo-packages/neutronclient-distgit/blob/26310d84ea59c383c928be5d01d350f0e21291cd/python-neutronclient.spec#L65-L130

3. Another reference can use to learn how to handle the tests deletion from the main rpm: https://github.com/rdo-packages/neutronclient-distgit/commit/296abb5e9aee5019ea22b4f2235f12fae2916a43

(In reply to Robert-André Mauchin from comment #1)

>  - Did you forget to put the Version and Release infos?

Done.

>  - There is no %changelog entry either!

Done.

>  - No need to complicate things, use version instead of upstream_version and
> remove upstream_version definition

Template client spec suggests using upstream_version [1]. Couple of existing OpenStack clients specs also defining macro upstream_version [2][3][4][5].
 

>  - You could use the %{py2_dist/%{py3_dist macros to handle your BR and R.
> See
> https://fedoraproject.org/wiki/Packaging:
> Python#Requires_and_BuildRequires_with_standardized_names

Yes, although:

a) Easier to maintain dependencies with BR and R explicitly thanks to '$ rdopkg reqcheck'.
b) Consistency with other OpenStack client specs.
c) Straightforward to support RDO and RHOSP, because EL7 does not support such macros AFAIK.


> There is no package openstack-macros in Fedora repositories. You'll have to
> package it beforehand.

Replaced macro %py_req_cleanup by "rm -f {,test-}requirements.txt" as it's also not used in existing OpenStack client specs for Fedora.



(In reply to Nir Magnezi from comment #2)

> 1. In other packages we have, URL points to a launchpad URL. since Octavia
> migrated to storyboard, perhaps the URL should be:
> https://storyboard.openstack.org/#!/project/911

Good point! Indeed [1] suggests linking to launchpad. I think that is because launchpad project pages have been considered good landing pages. Would project-specific storyboard pages be a good replacement? I'd rather point to somewhere providing users with more info such as [6], [7] or [8] (because of the HTML-rendered README).

 
> 2. You should end up with a separate RPM for tests, see the
> python-neutronclient spec for reference:
> https://github.com/rdo-packages/neutronclient-distgit/blob/
> 26310d84ea59c383c928be5d01d350f0e21291cd/python-neutronclient.spec#L65-L130

Yes, although python-stestr is a dependency and happens that the python-stestr RPM has a dependency issue (rhbz #1507995). Either we wait for a fix or disable -tests subpackage.


[1] https://github.com/openstack-packages/openstack-example-spec/blob/master/python-exampleclient.spec
[2] http://pkgs.fedoraproject.org/cgit/rpms/python-neutronclient.git/tree/python-neutronclient.spec
[3] http://pkgs.fedoraproject.org/cgit/rpms/python-novaclient.git/tree/python-novaclient.spec
[4] http://pkgs.fedoraproject.org/cgit/rpms/python-congressclient.git/tree/python-congressclient.spec
[5] http://pkgs.fedoraproject.org/cgit/rpms/python-aodhclient.git/tree/python-aodhclient.spec
[6] https://docs.openstack.org/python-octaviaclient/latest/
[7] https://docs.openstack.org/octavia/latest/
[7] https://github.com/openstack/python-octaviaclient

Care to point us toward the updated SPEC and SRPM?

Updated to version 1.2.0


Spec URL: http://cgoncalves.pt/trash/openstack/python-octaviaclient.spec
SRPM URL: http://cgoncalves.pt/trash/openstack/python-octaviaclient-1.2.0-1.fc27.src.rpm
Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=23282172

Everything seems good, package accepted.

Repo request: https://pagure.io/releng/fedora-scm-requests/issue/3223

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-octaviaclient

This is my first package and thus I need sponsoring. Could you please sponsor?

I'm sponsoring Carlos, he will be working with RDO project to maintain this package and he will get our support when he needs to.
FAS: hguemar (yeah, too lazy to switch to my fp.o account on RHBZ :o) )

Removing FE-NEEDSPONSOR as I sponsored Carlos in the packager group

python-octaviaclient file sources successfully push to http://pkgs.fedoraproject.org/cgit/rpms/python-octaviaclient.git/

It was also successfully built for f28 (rawhide): http://koji.fedoraproject.org/koji/buildinfo?buildID=1004381