Bug 1506931 - request to add some retires for "Create credentials for docker cli registry auth"
Summary: request to add some retires for "Create credentials for docker cli registry a...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Installer
Version: 3.7.0
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ---
: 3.7.0
Assignee: Michael Gugino
QA Contact: Johnny Liu
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-10-27 08:09 UTC by Johnny Liu
Modified: 2017-11-28 22:19 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-11-28 22:19:38 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2017:3188 0 normal SHIPPED_LIVE Moderate: Red Hat OpenShift Container Platform 3.7 security, bug, and enhancement update 2017-11-29 02:34:54 UTC

Description Johnny Liu 2017-10-27 08:09:38 UTC
Description of problem:
Refer to https://bugzilla.redhat.com/show_bug.cgi?id=1500642#c8, recently QE encounter such issue for several times, just as the explanation in https://bugzilla.redhat.com/show_bug.cgi?id=1500642#c10, it is caused by network flake or unstable registry server.

It is possible to add some more retires for this steps, so that make the whole installation more stable, less noise for qe's testing.

Version-Release number of selected component (if applicable):
openshift-ansible-3.7.0-0.178.1.git.0.43f8486.el7.noarch

How reproducible:
Always

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Michael Gugino 2017-10-30 14:48:21 UTC
PR Created: https://github.com/openshift/openshift-ansible/pull/5932

Comment 3 Johnny Liu 2017-11-01 12:00:14 UTC
This PR is not merged into penshift-ansible-3.7.0-0.188.0.git.0.aebb674.el7.noarch yet.

Set wrong password on purpose, no retry happen.

TASK [docker : Create credentials for docker cli registry auth] ****************
Wednesday 01 November 2017  11:25:42 +0000 (0:00:00.453)       0:03:12.842 **** 
fatal: [host-8-245-100.host.centralci.eng.rdu2.redhat.com]: FAILED! => {"changed": true, "cmd": ["docker", "--config=/root/.docker", "login", "-u", "aos-qe-xxx", "-p", "xxx", "registry.reg-aws.openshift.com:443"], "delta": "0:00:00.208195", "end": "2017-11-01 07:25:42.305713", "failed": true, "msg": "non-zero return code", "rc": 1, "start": "2017-11-01 07:25:42.097518", "stderr": "Error response from daemon: Get https://registry.reg-aws.openshift.com:443/v2/: unauthorized: authentication required", "stderr_lines": ["Error response from daemon: Get https://registry.reg-aws.openshift.com:443/v2/: unauthorized: authentication required"], "stdout": "", "stdout_lines": []}

Comment 4 Michael Gugino 2017-11-01 14:34:51 UTC
(In reply to Johnny Liu from comment #3)
> This PR is not merged into
> penshift-ansible-3.7.0-0.188.0.git.0.aebb674.el7.noarch yet.
> 
> Set wrong password on purpose, no retry happen.
> 
> TASK [docker : Create credentials for docker cli registry auth]
> ****************
> Wednesday 01 November 2017  11:25:42 +0000 (0:00:00.453)       0:03:12.842
> **** 
> fatal: [host-8-245-100.host.centralci.eng.rdu2.redhat.com]: FAILED! =>
> {"changed": true, "cmd": ["docker", "--config=/root/.docker", "login", "-u",
> "aos-qe-xxx", "-p", "xxx", "registry.reg-aws.openshift.com:443"], "delta":
> "0:00:00.208195", "end": "2017-11-01 07:25:42.305713", "failed": true,
> "msg": "non-zero return code", "rc": 1, "start": "2017-11-01
> 07:25:42.097518", "stderr": "Error response from daemon: Get
> https://registry.reg-aws.openshift.com:443/v2/: unauthorized: authentication
> required", "stderr_lines": ["Error response from daemon: Get
> https://registry.reg-aws.openshift.com:443/v2/: unauthorized: authentication
> required"], "stdout": "", "stdout_lines": []}

Are you sure you're using the latest code from master?  I tried this locally, I can confirm it retries.

TASK [Create credentials for docker cli registry auth] *******************************************************************************************
FAILED - RETRYING: Create credentials for docker cli registry auth (3 retries left).
FAILED - RETRYING: Create credentials for docker cli registry auth (2 retries left).
FAILED - RETRYING: Create credentials for docker cli registry auth (1 retries left).
fatal: [localhost]: FAILED! => {"attempts": 3, "changed": true, "cmd": ["docker", "--config=xx", "login", "-u", "some-user", "-p", "some-password", "some-registry.com:443"], "delta": "0:00:00.297752", "end": "2017-11-01 10:28:24.907621", "failed": true, "msg": "non-zero return code", "rc": 1, "start": "2017-11-01 10:28:24.609869", "stderr": "Error response from daemon: Get https://some-registry.com:443/v2/: unauthorized: authentication required", "stderr_lines": ["Error response from daemon: Get https://some-registry:443/v2/: unauthorized: authentication required"], "stdout": "", "stdout_lines": []}

Comment 5 Johnny Liu 2017-11-01 14:41:51 UTC
QE should NOT use github master branch for verification, only when testing is passed on openshift-ansible rpm package, then this verification is done. This could make sure the PR is really merged into rpm package which will be delivered to customer. This is our work flow.
I was saying the PR is not merged into the openshift-ansible-3.7.0-0.188.0.git.0.aebb674.el7.noarch. Moved this bug to ON_QA bug again, I will keep an eye on once newer openshift-ansible rpm package is available, I will re-run testing.

Comment 6 Johnny Liu 2017-11-02 06:08:43 UTC
Verified this bug with openshift-ansible-3.7.0-0.189.0.git.0.d497c5e.el7.noarch, and PASS.


TASK [docker : Create credentials for docker cli registry auth] ****************
Thursday 02 November 2017  06:03:15 +0000 (0:00:00.421)       0:03:06.040 ***** 
FAILED - RETRYING: Create credentials for docker cli registry auth (3 retries left).

FAILED - RETRYING: Create credentials for docker cli registry auth (2 retries left).

FAILED - RETRYING: Create credentials for docker cli registry auth (1 retries left).

fatal: [host-8-245-30.host.centralci.eng.rdu2.redhat.com]: FAILED! => {"attempts": 3, "changed": true, "cmd": ["docker", "--config=/root/.docker", "login", "-u", "aos-qe-pull36", "-p", "xxx", "registry.reg-aws.openshift.com:443"], "delta": "0:00:00.182415", "end": "2017-11-02 02:03:32.742895", "failed": true, "msg": "non-zero return code", "rc": 1, "start": "2017-11-02 02:03:32.560480", "stderr": "Error response from daemon: Get https://registry.reg-aws.openshift.com:443/v2/: unauthorized: authentication required", "stderr_lines": ["Error response from daemon: Get https://registry.reg-aws.openshift.com:443/v2/: unauthorized: authentication required"], "stdout": "", "stdout_lines": []}

Comment 9 errata-xmlrpc 2017-11-28 22:19:38 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:3188


Note You need to log in before you can comment on or make changes to this bug.