Description of problem: See the following details Version-Release number of the following components: openshift-ansible-3.7.0-0.178.1.git.0.43f8486.el7.noarch.rpm How reproducible: 100% Steps to Reproduce: 1. set the following parameters in inventory host file osm_use_cockpit=true osm_cockpit_plugins=['cockpit-kubernetes'] 2.trigger a rpm install on RHEL host 3. Actual results: cockpit role is skipped: TASK [cockpit : Add iptables allow rules] ************************************** Friday 27 October 2017 06:30:53 +0000 (0:00:01.532) 0:01:58.114 ******** skipping: [qe-jialiutest3-master-etcd-1.1027-oex.qe.rhcloud.com] => (item={u'port': u'9090/tcp', u'service': u'cockpit-ws'}) => {"changed": false, "item": {"port": "9090/tcp", "service": "cockpit-ws"}, "skip_reason": "Conditional result was False", "skipped": true} TASK [cockpit : Remove iptables rules] ***************************************** Friday 27 October 2017 06:30:53 +0000 (0:00:00.032) 0:01:58.147 ******** TASK [cockpit : Add firewalld allow rules] ************************************* Friday 27 October 2017 06:30:53 +0000 (0:00:00.020) 0:01:58.167 ******** skipping: [qe-jialiutest3-master-etcd-1.1027-oex.qe.rhcloud.com] => (item={u'port': u'9090/tcp', u'service': u'cockpit-ws'}) => {"changed": false, "item": {"port": "9090/tcp", "service": "cockpit-ws"}, "skip_reason": "Conditional result was False", "skipped": true} TASK [cockpit : Remove firewalld allow rules] ********************************** Friday 27 October 2017 06:30:53 +0000 (0:00:00.025) 0:01:58.193 ******** TASK [cockpit : Install cockpit-ws] ******************************************** Friday 27 October 2017 06:30:53 +0000 (0:00:00.020) 0:01:58.213 ******** skipping: [qe-jialiutest3-master-etcd-1.1027-oex.qe.rhcloud.com] => (item=cockpit-ws) => {"changed": false, "item": "cockpit-ws", "skip_reason": "Conditional result was False", "skipped": true} skipping: [qe-jialiutest3-master-etcd-1.1027-oex.qe.rhcloud.com] => (item=cockpit-system) => {"changed": false, "item": "cockpit-system", "skip_reason": "Conditional result was False", "skipped": true} skipping: [qe-jialiutest3-master-etcd-1.1027-oex.qe.rhcloud.com] => (item=cockpit-bridge) => {"changed": false, "item": "cockpit-bridge", "skip_reason": "Conditional result was False", "skipped": true} skipping: [qe-jialiutest3-master-etcd-1.1027-oex.qe.rhcloud.com] => (item=cockpit-docker) => {"changed": false, "item": "cockpit-docker", "skip_reason": "Conditional result was False", "skipped": true} skipping: [qe-jialiutest3-master-etcd-1.1027-oex.qe.rhcloud.com] => (item=cockpit-kubernetes) => {"changed": false, "item": "cockpit-kubernetes", "skip_reason": "Conditional result was False", "skipped": true} TASK [cockpit : Enable cockpit-ws] ********************************************* Friday 27 October 2017 06:30:54 +0000 (0:00:00.048) 0:01:58.262 ******** skipping: [qe-jialiutest3-master-etcd-1.1027-oex.qe.rhcloud.com] => {"changed": false, "skip_reason": "Conditional result was False", "skipped": true} Expected results: cockpit role should be run. Additional info: Check code, find the when judgment for this role have some problems: - role: cockpit when: - openshift.common.is_atomic - deployment_type == 'openshift-enterprise' - osm_use_cockpit is undefined or osm_use_cockpit | bool - openshift.common.deployment_subtype != 'registry' Obviously, "- openshift.common.is_atomic" should be correct to "- not openshift.common.is_atomic". 3.6 install does not have such issue, here is 3.6 code: - role: cockpit when: not openshift.common.is_atomic and ( deployment_type in ['atomic-enterprise','openshift-enterprise'] ) and (osm_use_cockpit | bool or osm_use_cockpit is undefined ) and ( openshift.common.deployment_subtype != 'registry' )
https://github.com/openshift/openshift-ansible/pull/5915
Verified this bug with openshift-ansible-3.7.0-0.188.0.git.0.aebb674.el7.noarch, and PASS. TASK [cockpit : Add iptables allow rules] ************************************** Wednesday 01 November 2017 06:06:26 +0000 (0:00:00.792) 0:06:46.503 **** changed: [host-8-244-7.host.centralci.eng.rdu2.redhat.com] => (item={u'port': u'9090/tcp', u'service': u'cockpit-ws'}) => {"changed": true, "failed": false, "item": {"port": "9090/tcp", "service": "cockpit-ws"}, "output": ["", "iptables: Saving firewall rules to /etc/sysconfig/iptables: [ OK ]\r\n"]} TASK [cockpit : Remove iptables rules] ***************************************** Wednesday 01 November 2017 06:06:27 +0000 (0:00:00.561) 0:06:47.064 **** TASK [cockpit : Add firewalld allow rules] ************************************* Wednesday 01 November 2017 06:06:27 +0000 (0:00:00.024) 0:06:47.089 **** skipping: [host-8-244-7.host.centralci.eng.rdu2.redhat.com] => (item={u'port': u'9090/tcp', u'service': u'cockpit-ws'}) => {"changed": false, "item": {"port": "9090/tcp", "service": "cockpit-ws"}, "skip_reason": "Conditional result was False", "skipped": true} TASK [cockpit : Remove firewalld allow rules] ********************************** Wednesday 01 November 2017 06:06:27 +0000 (0:00:00.136) 0:06:47.226 **** TASK [cockpit : Install cockpit-ws] ******************************************** Wednesday 01 November 2017 06:06:27 +0000 (0:00:00.024) 0:06:47.250 **** <--snipped--> TASK [cockpit : Enable cockpit-ws] ********************************************* Wednesday 01 November 2017 06:06:51 +0000 (0:00:24.532) 0:07:11.783 **** changed: [host-8-244-7.host.centralci.eng.rdu2.redhat.com] => {"changed": true, "enabled": true, "failed": false, "name": "cockpit.socket", "state": "started", "status": {"Accept": "no", "ActiveEnterTimestampMonotonic": "0", "ActiveExitTimestampMonotonic": "0", "ActiveState": "inactive", "After": "sysinit.target -.slice", "AllowIsolate": "no", "AmbientCapabilities": "0", "AssertResult": "no", "AssertTimestampMonotonic": "0", "Backlog": "128", "Before": "sockets.target cockpit.service shutdown.target", "BindIPv6Only": "default", "BlockIOAccounting": "no", "BlockIOWeight": "18446744073709551615", "Broadcast": "no", "CPUAccounting": "no", "CPUQuotaPerSecUSec": "infinity", "CPUSchedulingPolicy": "0", "CPUSchedulingPriority": "0", "CPUSchedulingResetOnFork": "no", "CPUShares": "18446744073709551615", "CanIsolate": "no", "CanReload": "no", "CanStart": "yes", "CanStop": "yes", "CapabilityBoundingSet": "18446744073709551615", "ConditionResult": "no", "ConditionTimestampMonotonic": "0", "Conflicts": "shutdown.target", "ControlPID": "0", "DefaultDependencies": "yes", "DeferAcceptUSec": "0", "Delegate": "no", "Description": "Cockpit Web Service Socket", "DevicePolicy": "auto", "DirectoryMode": "0755", "Documentation": "man:cockpit-ws(8)", "FragmentPath": "/usr/lib/systemd/system/cockpit.socket", "FreeBind": "no", "IOScheduling": "0", "IPTOS": "-1", "IPTTL": "-1", "Id": "cockpit.socket", "IgnoreOnIsolate": "no", "IgnoreOnSnapshot": "no", "IgnoreSIGPIPE": "yes", "InactiveEnterTimestampMonotonic": "0", "InactiveExitTimestampMonotonic": "0", "JobTimeoutAction": "none", "JobTimeoutUSec": "0", "KeepAlive": "no", "KeepAliveIntervalUSec": "0", "KeepAliveProbes": "0", "KeepAliveTimeUSec": "0", "KillMode": "control-group", "KillSignal": "15", "LimitAS": "18446744073709551615", "LimitCORE": "18446744073709551615", "LimitCPU": "18446744073709551615", "LimitDATA": "18446744073709551615", "LimitFSIZE": "18446744073709551615", "LimitLOCKS": "18446744073709551615", "LimitMEMLOCK": "65536", "LimitMSGQUEUE": "819200", "LimitNICE": "0", "LimitNOFILE": "4096", "LimitNPROC": "15076", "LimitRSS": "18446744073709551615", "LimitRTPRIO": "0", "LimitRTTIME": "18446744073709551615", "LimitSIGPENDING": "15076", "LimitSTACK": "18446744073709551615", "ListenStream": "[::]:9090", "LoadState": "loaded", "Mark": "-1", "MaxConnections": "64", "MemoryAccounting": "no", "MemoryCurrent": "18446744073709551615", "MemoryLimit": "18446744073709551615", "MountFlags": "0", "NAccepted": "0", "NConnections": "0", "Names": "cockpit.socket", "NeedDaemonReload": "no", "Nice": "0", "NoDelay": "no", "NoNewPrivileges": "no", "NonBlocking": "no", "OOMScoreAdjust": "0", "OnFailureJobMode": "replace", "PassCredentials": "no", "PassSecurity": "no", "PipeSize": "0", "Priority": "-1", "PrivateDevices": "no", "PrivateNetwork": "no", "PrivateTmp": "no", "ProtectHome": "no", "ProtectSystem": "no", "ReceiveBuffer": "0", "RefuseManualStart": "no", "RefuseManualStop": "no", "RemoveOnStop": "no", "RequiredBy": "cockpit.service", "Requires": "sysinit.target", "Result": "success", "ReusePort": "no", "RuntimeDirectoryMode": "0755", "SameProcessGroup": "no", "SecureBits": "0", "SendBuffer": "0", "SendSIGHUP": "no", "SendSIGKILL": "yes", "SocketMode": "0666", "StandardError": "inherit", "StandardInput": "null", "StandardOutput": "journal", "StartupBlockIOWeight": "18446744073709551615", "StartupCPUShares": "18446744073709551615", "StopWhenUnneeded": "no", "SubState": "dead", "SyslogLevelPrefix": "yes", "SyslogPriority": "30", "SystemCallErrorNumber": "0", "TTYReset": "no", "TTYVHangup": "no", "TTYVTDisallocate": "no", "TasksAccounting": "no", "TasksCurrent": "18446744073709551615", "TasksMax": "18446744073709551615", "TimeoutUSec": "1min 30s", "TimerSlackNSec": "50000", "Transient": "no", "Transparent": "no", "Triggers": "cockpit.service", "UMask": "0022", "UnitFilePreset": "disabled", "UnitFileState": "disabled", "Wants": "-.slice"}}