Created attachment 1344976 [details] logs Description of problem: Can't create bond modes 5 and 6 when trying to create with non-VM vlan tagged network. When trying to create new bond with modes 5 or 6 with non-VM vlan tagged network attached to the bond we fail with: vdsmd - 2017-10-29 09:45:37,729+0200 ERROR (jsonrpc/5) [vds] While adding vlan bond0.167 over bond bond0, the bond hwaddr was not in sync whith its slaves. (API:1509) Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/vdsm/API.py", line 1506, in setupNetworks supervdsm.getProxy().setupNetworks(networks, bondings, options) File "/usr/lib/python2.7/site-packages/vdsm/supervdsm.py", line 53, in __call__ return callMethod() File "/usr/lib/python2.7/site-packages/vdsm/supervdsm.py", line 51, in <lambda> **kwargs) File "<string>", line 2, in setupNetworks File "/usr/lib64/python2.7/multiprocessing/managers.py", line 773, in _callmethod raise convert_to_error(kind, result) ConfigNetworkError: (25, 'While adding vlan bond0.167 over bond bond0, the bond hwaddr was not in sync whith its slaves.') Supervdsmd - ainProcess|jsonrpc/5::ERROR::2017-10-29 09:45:37,728::supervdsm_server::94::SuperVdsm.ServerCallback::(wrapper) Error in setupNetworks Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/vdsm/supervdsm_server.py", line 92, in wrapper res = func(*args, **kwargs) File "/usr/lib/python2.7/site-packages/vdsm/network/api.py", line 204, in setupNetworks _setup_networks(networks, bondings, options) File "/usr/lib/python2.7/site-packages/vdsm/network/api.py", line 225, in _setup_networks netswitch.configurator.setup(networks, bondings, options, in_rollback) File "/usr/lib/python2.7/site-packages/vdsm/network/netswitch/configurator.py", line 139, in setup _setup_legacy(legacy_nets, legacy_bonds, options, in_rollback) File "/usr/lib/python2.7/site-packages/vdsm/network/netswitch/configurator.py", line 159, in _setup_legacy bondings, _netinfo) File "/usr/lib/python2.7/site-packages/vdsm/network/legacy_switch.py", line 422, in add_missing_networks _add_network(network, configurator, _netinfo, **attrs) File "/usr/lib/python2.7/site-packages/vdsm/network/legacy_switch.py", line 159, in wrapped return func(network, configurator, net_info, **kwargs) File "/usr/lib/python2.7/site-packages/vdsm/network/legacy_switch.py", line 215, in _add_network net_ent_to_configure.configure(**options) File "/usr/lib/python2.7/site-packages/vdsm/network/models.py", line 143, in configure self.configurator.configureVlan(self, **opts) File "/usr/lib/python2.7/site-packages/vdsm/network/configurators/ifcfg.py", line 123, in configureVlan Ifcfg._ifup_vlan_with_slave_bond_hwaddr_sync(vlan) File "/usr/lib/python2.7/site-packages/vdsm/network/configurators/ifcfg.py", line 406, in _ifup_vlan_with_slave_bond_hwaddr_sync 'whith its slaves.'.format(vlan.name, vlan.device.name)) ConfigNetworkError: (25, 'While adding vlan bond0.167 over bond bond0, the bond hwaddr was not in sync whith its slaves.') -Engine - 2017-10-29 10:14:08,882+02 ERROR [org.ovirt.engine.core.bll.network.host.HostSetupNetworksCommand] (default task-3) [01ea6f37-3ae8-4774-b034-4db7a6a27e9a] Command 'org.ovirt.engine.core.bll.network.host.HostSetupNetworksCommand' failed: EngineException: org.ovirt.engine.core.vdsbroker.vdsbroker.VDSErrorException: VDSGenericException: VDSErrorException: Failed to HostSetupNetworksVDS, error = While adding vlan bond0.167 over bond bond0, the bond hwaddr was not in sync whith its slaves., code = 25 (Failed with error ERR_BAD_BONDING and code 25) Version-Release number of selected component (if applicable): vdsm-4.20.4-12.git11d6d3d.el7.centos.x86_64 4.2.0-0.0.master.20171027213842.gitded437c.el7.centos How reproducible: 100% Steps to Reproduce: 1. Try to create bond mode 5 or 6 with non-VM vlan tagged network Actual results: Failed - 'Error while executing action HostSetupNetworks: Invalid Bonding definition' and error on vdsm side Expected results: Should work
Created attachment 1344977 [details] record1
The exploding code is new. I suppose that this is a regression?
(In reply to Dan Kenigsberg from comment #2) > The exploding code is new. I suppose that this is a regression? Yes it is a regression, setting the flag.
This bug report has Keywords: Regression or TestBlocker. Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.
(In reply to Michael Burman from comment #3) > (In reply to Dan Kenigsberg from comment #2) > > The exploding code is new. I suppose that this is a regression? > > Yes it is a regression, setting the flag. Regression compared to what? Just interested to understand if it is due to RHEL or RHV versions.
(In reply to Edward Haas from comment #5) > (In reply to Michael Burman from comment #3) > > (In reply to Dan Kenigsberg from comment #2) > > > The exploding code is new. I suppose that this is a regression? > > > > Yes it is a regression, setting the flag. > > Regression compared to what? > Just interested to understand if it is due to RHEL or RHV versions. Regression compared to 4.1.7-5
Is this a blocker for oVirt GA? If not, please re-target to 4.2.1.
(In reply to Yaniv Kaul from comment #7) > Is this a blocker for oVirt GA? If not, please re-target to 4.2.1. It is a regression, we need to look into it and understand the problem.
(In reply to Edward Haas from comment #8) > (In reply to Yaniv Kaul from comment #7) > > Is this a blocker for oVirt GA? If not, please re-target to 4.2.1. > > It is a regression, we need to look into it and understand the problem. No news for a week, moving to 4.2.1.
Edy, what is the vdsm version with the fix?
Verified on - vdsm-4.20.8-53.gitc3edfc0.el7.centos.x86_64
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017. Since the problem described in this bug report should be resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report.