Bug 1507772 - [v2v] add unit tests and enhance dialog code
Summary: [v2v] add unit tests and enhance dialog code
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Providers
Version: 5.9.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.10.0
Assignee: Shmuel Melamud
QA Contact: Yadnyawalk Tale
URL:
Whiteboard:
Depends On:
Blocks: 1525144
TreeView+ depends on / blocked
 
Reported: 2017-10-31 06:17 UTC by Oved Ourfali
Modified: 2019-04-25 15:54 UTC (History)
6 users (show)

Fixed In Version: 5.10.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1525144 (view as bug list)
Environment:
Last Closed: 2018-06-21 21:04:18 UTC
Category: ---
Cloudforms Team: RHEVM
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github ManageIQ manageiq-providers-ovirt pull 154 0 None None None 2017-12-04 14:16:24 UTC
Github ManageIQ manageiq-ui-classic pull 2613 0 None None None 2017-11-06 11:50:53 UTC

Description Oved Ourfali 2017-10-31 06:17:53 UTC
Recent PR [1] got merged, but we need to add:

1. Unit tests
2. "But as discussed with @smelamud on gitter: there's the prefered way to check for feature availability on a provider is to use the supports mixin https://github.com/ManageIQ/manageiq/blob/master/app/models/mixins/supports_feature_mixin.rb

This should be used in future PRs and code that is doing some other way of checking of availability of features should be using that.

If you use that then there is a generic button class that checks for the feature support presence.
"

Let's do both enhancements.

Comment 6 Shmuel Melamud 2017-12-04 14:16:25 UTC
Dialog code change merged.


Note You need to log in before you can comment on or make changes to this bug.