Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1507927

Summary: VDO modify --blockMapPeriod does not change the period
Product: Red Hat Enterprise Linux 7 Reporter: Jakub Krysl <jkrysl>
Component: vdoAssignee: Joe Shimkus <jshimkus>
Status: CLOSED ERRATA QA Contact: Jakub Krysl <jkrysl>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.5CC: awalsh, bgurney, bjohnsto, limershe
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 6.1.0.75 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-04-10 15:46:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jakub Krysl 2017-10-31 13:19:42 UTC
Description of problem:
Using "vdo modify" with argument "--blockMapPeriod" runs without error but does not change the block map period:

# vdo create --device /dev/sdc --name vdo --blockMapPeriod 10                       
Creating VDO vdo                                    
Starting VDO vdo                                    
Starting compression on VDO vdo                     
VDO instance 26 volume is ready at /dev/mapper/vdo  
VDO volume created at /dev/mapper/vdo               
# vdo status --all | grep "Block map period"                                                                                                                                                  
    Block map period: 10                           
# vdo modify --name vdo --blockMapPeriod 500                                        
# echo $?                      
0                                                   
# vdo status --all | grep "Block map period"                                        
    Block map period: 10                            

# vdo create --device /dev/sdc --name vdo                     
Creating VDO vdo                                    
Starting VDO vdo                                    
Starting compression on VDO vdo                     
VDO instance 27 volume is ready at /dev/mapper/vdo  
VDO volume created at /dev/mapper/vdo               
# vdo status --all | grep "Block map period"                                                                                                                                                  
    Block map period: 16380
# vdo modify --name vdo --blockMapPeriod 500                                        
# echo $?                      
0                                                   
# vdo status --all | grep "Block map period"                                        
    Block map period: 16380     

Version-Release number of selected component (if applicable):
6.1.0.0.6

How reproducible:
100%

Steps to Reproduce:
1. vdo create --device /dev/sdc --name vdo
2. vdo status --all | grep "Block map period"
3. vdo modify --name vdo --blockMapPeriod 500
4. vdo status --all | grep "Block map period"

Actual results:
No change of block map period value

Expected results:
Changed vdo block map period value

Additional info:

Comment 2 Bryan Gurney 2017-10-31 14:38:06 UTC
There is a workaround: edit the /etc/vdoconf.yml file, and change the value of the "blockMapPeriod" parameter.  After this, the "vdo status" command should reflect the newly configured value, which can then be enabled by running "vdo stop --name=<vdoname>", then "vdo start --name=<vdoname>".

I need to verify the valid range of the blockMapPeriod; I believe it's 1 to 16380, but in practice, the blockMapPeriod value should be adjusted down from its maximum, with testing to ensure that there's no significant performance degradation from the increased frequency of updates to disk from the block map cache.

Comment 3 bjohnsto 2017-10-31 20:11:48 UTC
(In reply to Bryan Gurney from comment #2)
> There is a workaround: edit the /etc/vdoconf.yml file, and change the value
> of the "blockMapPeriod" parameter.  After this, the "vdo status" command
> should reflect the newly configured value, which can then be enabled by
> running "vdo stop --name=<vdoname>", then "vdo start --name=<vdoname>".
> 
> I need to verify the valid range of the blockMapPeriod; I believe it's 1 to
> 16380, but in practice, the blockMapPeriod value should be adjusted down
> from its maximum, with testing to ensure that there's no significant
> performance degradation from the increased frequency of updates to disk from
> the block map cache.

We should never be telling people to manually edit that file. We even added in a comment at the top of the file to not manually edit. So I'm not sure this is a very good workaround to tell people to do.

Comment 5 Jakub Krysl 2017-12-14 11:00:06 UTC
vdo modify now changes block map period.

Comment 8 errata-xmlrpc 2018-04-10 15:46:34 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:0871