Bug 1507934 - [3.6] etcd_quota_backend_bytes undefined during etcd upgrade
Summary: [3.6] etcd_quota_backend_bytes undefined during etcd upgrade
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Cluster Version Operator
Version: 3.6.1
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 3.6.z
Assignee: Russell Teague
QA Contact: liujia
URL:
Whiteboard:
: 1546265 1546871 1546873 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-10-31 13:46 UTC by Scott Dodson
Modified: 2021-06-10 13:24 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
The default value for `etcd_quota_backend_bytes` was not available for `etcd_upgrade` role, causing an undefined variable error when running the `etcd_upgrade` role. This bug fix moved the `etcd_quota_backend_bytes` default from the `etcd` role to the `etcd_common` role, resulting in the `etcd_quota_backend_bytes` default variable being available for both `etcd` and `etcd_upgrade` roles.
Clone Of:
Environment:
Last Closed: 2017-11-21 05:41:46 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2017:3255 0 normal SHIPPED_LIVE OpenShift Container Platform atomic-openshift-utils bug fix and enhancement 2017-11-21 10:40:59 UTC

Description Scott Dodson 2017-10-31 13:46:54 UTC
In master and release-3.6

TASK [etcd_upgrade : lineinfile] ***********************************************
Tuesday 31 October 2017  04:41:58 +0000 (0:00:30.905)       0:05:38.953 ******* 
fatal: [master-23f3c]: FAILED! => {"failed": true, "msg": "the field 'args' has an invalid value, which appears to include a variable that is undefined. The error was: 'etcd_quota_backend_bytes' is undefined\n\nThe error appears to have been in '/home/opsmedic/aos-cd/git/openshift-tools/openshift/installer/vendored/openshift-ansible-3.6.173.0.59/roles/etcd_upgrade/tasks/upgrade_rpm.yml': line 22, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- lineinfile:\n  ^ here\n"}

Comment 1 Scott Dodson 2017-10-31 13:47:57 UTC
I think this is happening because the variable is defined in etcd role but that role is not required of etcd_upgrade. Perhaps when performing a complete upgrade the etcd role gets invoked before etcd_upgrade but only when running control_plane is it undefined?

Comment 4 Russell Teague 2017-11-03 16:01:30 UTC
Proposed: https://github.com/openshift/openshift-ansible/pull/6003

Comment 8 liujia 2017-11-16 06:53:11 UTC
@Scott @Russell

AFAIK, etcd will not be upgraded by default during upgrade or upgrade_control_plane from v3.5 to v3.6. So this error can only happened when running upgrade_etcd.yml to upgrade etcd manually. Moreover, due to bz1495486, running upgrade_etcd can not upgrade a 3.1 or newer version etcd. 

So QE just check the pr merged, and run upgrade_etcd.yml against an etcd-3.0.15 to ensure the issue has been fixed.

Version:
openshift-ansible-3.6.173.0.75-1.git.0.0a44128.el7.noarch

TASK [etcd_upgrade : lineinfile] ********************************************************************************************************************************************
changed: [x.x.x.x] => {
    "backup": "", 
    "changed": true, 
    "failed": false
}

MSG:

line added

Comment 9 Scott Dodson 2017-11-16 13:54:29 UTC
Yes that's fine, just need to ensure that this gets added.

Comment 12 errata-xmlrpc 2017-11-21 05:41:46 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:3255

Comment 13 Scott Dodson 2018-02-20 02:54:42 UTC
*** Bug 1546873 has been marked as a duplicate of this bug. ***

Comment 14 Scott Dodson 2018-02-20 02:57:34 UTC
*** Bug 1546871 has been marked as a duplicate of this bug. ***

Comment 15 Scott Dodson 2018-02-20 22:15:35 UTC
*** Bug 1546265 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.