Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/1455b41/toxcore.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/tox/fedora-rawhide-x86_64/00656446-toxcore/toxcore-0.1.10-2.fc28.src.rpm Description: Tox is a peer to peer (serverless) instant messenger aimed at making security and privacy easy to obtain for regular users. It uses NaCl for its encryption and authentication. Fedora Account System Username: eclipseo Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=22828842
Created attachment 1346390 [details] licensecheck.txt INSTALL_ROOT=%{buildroot} is usually only needed for qmake generated Makefiles and shouldn't be necessary here. Some files are BSD licensed, see licensecheck.txt attached.
Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/68026b4/toxcore.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/tox/fedora-rawhide-x86_64/00656750-toxcore/toxcore-0.1.10-2.fc28.src.rpm - Fixed licenses - Removed INSTALL_ROOT=%{buildroot} Thank you for all the reviews!
This also needs to be included in the license breakdown ISC --- c-toxcore-0.1.10/toxcore/crypto_core_mem.c These don't seem to actually be used so I guess it's okay to leave them out. MIT/X11 (BSD like) ------------------ c-toxcore-0.1.10/other/bootstrap_daemon/docker/get-nodes.py c-toxcore-0.1.10/other/fun/bootstrap_node_info.py
Fixed Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/3cd73a7/toxcore.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/tox/fedora-rawhide-x86_64/00656774-toxcore/toxcore-0.1.10-2.fc28.src.rpm
[!]: Package requires other packages for directories it uses. Note: No known owner of /usr/include/tox [!]: Package must own all directories that it creates. => Please fix this on import by using %{_includedir}/tox/ instead of %{_includedir}/tox/* Rest is good, approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL", "GPL (v3 or later)", "Unknown or generated", "MIT/X11 (BSD like)", "BSD (unspecified)", "ISC", "BSD (2 clause)", "FSF All Permissive". 142 files have unknown license. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/include/tox [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/include/tox [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: toxcore-0.1.10-2.fc28.x86_64.rpm toxcore-devel-0.1.10-2.fc28.x86_64.rpm toxcore-debuginfo-0.1.10-2.fc28.x86_64.rpm toxcore-debugsource-0.1.10-2.fc28.x86_64.rpm toxcore-0.1.10-2.fc28.src.rpm toxcore.x86_64: W: spelling-error %description -l en_US Tox -> Ox, Tex, Lox toxcore.x86_64: W: spelling-error %description -l en_US serverless -> server less, server-less, nerveless toxcore-devel.x86_64: W: spelling-error %description -l en_US Tox -> Ox, Tex, Lox toxcore-devel.x86_64: W: spelling-error %description -l en_US serverless -> server less, server-less, nerveless toxcore-devel.x86_64: W: only-non-binary-in-usr-lib toxcore-devel.x86_64: W: no-documentation toxcore-debugsource.x86_64: W: no-documentation toxcore.src: W: spelling-error %description -l en_US Tox -> Ox, Tex, Lox toxcore.src: W: spelling-error %description -l en_US serverless -> server less, server-less, nerveless 5 packages and 0 specfiles checked; 0 errors, 9 warnings. Rpmlint (debuginfo) ------------------- Checking: toxcore-debuginfo-0.1.10-2.fc28.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory toxcore-devel.x86_64: W: spelling-error %description -l en_US Tox -> Ox, Tex, Lox toxcore-devel.x86_64: W: spelling-error %description -l en_US serverless -> server less, server-less, nerveless toxcore-devel.x86_64: W: invalid-url URL: https://github.com/TokTok/c-toxcore <urlopen error [Errno -2] Name or service not known> toxcore-devel.x86_64: W: only-non-binary-in-usr-lib toxcore-devel.x86_64: W: no-documentation toxcore-debugsource.x86_64: W: invalid-url URL: https://github.com/TokTok/c-toxcore <urlopen error [Errno -2] Name or service not known> toxcore-debugsource.x86_64: W: no-documentation toxcore-debuginfo.x86_64: W: invalid-url URL: https://github.com/TokTok/c-toxcore <urlopen error [Errno -2] Name or service not known> toxcore.x86_64: W: spelling-error %description -l en_US Tox -> Ox, Tex, Lox toxcore.x86_64: W: spelling-error %description -l en_US serverless -> server less, server-less, nerveless toxcore.x86_64: W: invalid-url URL: https://github.com/TokTok/c-toxcore <urlopen error [Errno -2] Name or service not known> toxcore.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libtoxav.so.1.10.0 /lib64/librt.so.1 toxcore.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libtoxav.so.1.10.0 /lib64/libsodium.so.23 toxcore.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libtoxav.so.1.10.0 /lib64/libm.so.6 toxcore.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libtoxcore.so.1.10.0 /lib64/libm.so.6 toxcore.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libtoxdns.so.1.10.0 /lib64/libm.so.6 toxcore.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libtoxdns.so.1.10.0 /lib64/librt.so.1 toxcore.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libtoxdns.so.1.10.0 /lib64/libsodium.so.23 toxcore.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libtoxdns.so.1.10.0 /lib64/libpthread.so.0 toxcore.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libtoxencryptsave.so.1.10.0 /lib64/libm.so.6 toxcore.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libtoxencryptsave.so.1.10.0 /lib64/librt.so.1 toxcore.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libtoxencryptsave.so.1.10.0 /lib64/libpthread.so.0 4 packages and 0 specfiles checked; 0 errors, 22 warnings. Requires -------- toxcore-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libtoxav.so.1()(64bit) libtoxcore.so.1()(64bit) libtoxdns.so.1()(64bit) libtoxencryptsave.so.1()(64bit) pkgconfig(libtoxcore) toxcore(x86-64) toxcore-debugsource (rpmlib, GLIBC filtered): toxcore-debuginfo (rpmlib, GLIBC filtered): toxcore (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libm.so.6()(64bit) libopus.so.0()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libsodium.so.23()(64bit) libtoxcore.so.1()(64bit) libvpx.so.4()(64bit) rtld(GNU_HASH) Provides -------- toxcore-devel: pkgconfig(libtoxav) pkgconfig(libtoxcore) toxcore-devel toxcore-devel(x86-64) toxcore-debugsource: toxcore-debugsource toxcore-debugsource(x86-64) toxcore-debuginfo: debuginfo(build-id) toxcore-debuginfo toxcore-debuginfo(x86-64) toxcore: libtoxav.so.1()(64bit) libtoxcore.so.1()(64bit) libtoxdns.so.1()(64bit) libtoxencryptsave.so.1()(64bit) toxcore toxcore(x86-64) Source checksums ---------------- https://github.com/TokTok/c-toxcore/archive/v0.1.10/toxcore-0.1.10.tar.gz : CHECKSUM(SHA256) this package : 7ec99c71a31e612ba458d708e05174afb2852cfbb4504ccb9456bd706fc27bd1 CHECKSUM(SHA256) upstream package : 7ec99c71a31e612ba458d708e05174afb2852cfbb4504ccb9456bd706fc27bd1 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1507986 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/toxcore
toxcore-0.1.10-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-6d37ee9718
toxcore-0.1.10-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6d37ee9718
toxcore-0.1.10-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.