RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1508366 - docker agent ignores existing but stopped containers
Summary: docker agent ignores existing but stopped containers
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: resource-agents
Version: 7.4
Hardware: Unspecified
OS: Unspecified
unspecified
urgent
Target Milestone: rc
: ---
Assignee: Oyvind Albrigtsen
QA Contact: Udi Shkalim
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-11-01 10:14 UTC by Andrew Beekhof
Modified: 2018-04-10 12:10 UTC (History)
4 users (show)

Fixed In Version: resource-agents-3.9.5-111.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-04-10 12:09:28 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2018:0757 0 None None None 2018-04-10 12:10:40 UTC

Description Andrew Beekhof 2017-11-01 10:14:55 UTC
Description of problem:

When the 'reuse' parameter is false, the agent must treat the existence of a terminated container as an error.

Otherwise, a subsequent attempt to start it will result in an error because a container with the same name already exists.

Version-Release number of selected component (if applicable):

resource-agents-3.9.5-105.el7.x86_64

How reproducible:

100%

Steps to Reproduce:
1. Manually create a container named 'badContainer'
2. docker stop badContainer
3. Create a docker cluster resource called badContainer and arrange for it to start on the above node

Actual results:

monitor reports 'not running' and start fails

Expected results:

monitor detects an error, stop called, start succeeds
Additional info:

Comment 3 Andrew Beekhof 2017-11-01 10:54:37 UTC
Patch against 3.9.5-105.el7.x86_64:


--- docker	2017-11-01 21:50:21.423600738 +1100
+++ docker.beekhof	2017-11-01 21:48:10.570475949 +1100
 #######################################################################
 
@@ -234,16 +235,16 @@ docker_simple_status()
 
 	# retrieve the 'Running' attribute for the container
 	val=$(docker inspect --format {{.State.Running}} $CONTAINER 2>/dev/null)
-	if [ $? -ne 0 ]; then
-		#not running as a result of container not being found
-		return $OCF_NOT_RUNNING
-	fi
-
-	if ocf_is_true "$val"; then
+	if [ $? -eq 0 ]; then
+	    if ocf_is_true "$val" ; then
 		# container exists and is running
 		return $OCF_SUCCESS
 	fi
-
+	fi
+	# Known but in a stopped state
+	if ! ocf_is_true "$OCF_RESKEY_reuse"; then
+	    return $OCF_ERR_GENERIC
+	fi
 	return $OCF_NOT_RUNNING
 }

Comment 7 errata-xmlrpc 2018-04-10 12:09:28 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0757


Note You need to log in before you can comment on or make changes to this bug.