Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1508918

Summary:	Some vdo commands do not return missing argument error when run without needed options
Product:	Red Hat Enterprise Linux 7	Reporter:	Jakub Krysl <jkrysl>
Component:	vdo	Assignee:	Joe Shimkus <jshimkus>
Status:	CLOSED ERRATA	QA Contact:	Jakub Krysl <jkrysl>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	7.5	CC:	awalsh, bjohnsto, limershe
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	6.1.0.75	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-04-10 15:47:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jakub Krysl 2017-11-02 13:58:37 UTC

Description of problem:
When running vdo commands that should be run with options without them, they pass and do nothing. There should be a clear error (as is with --name/--all) that such option is required. Here is the list, I hope it is complete:
modify
changeWritePolicy
growLogical

The "vdo growLogical" actually is the same as calling "vdo growLogical --vdoLogicalSize=$SIZE_NOW" where $SIZE_NOW is the logical size of that vdo at that very moment. This leads to:
# vdo --name vdo growLogical
vdo: ERROR - Can't shrink a VDO volume (old size 5860522584K)
The other 2 complete without any failure but do nothing.


Version-Release number of selected component (if applicable):
6.1.0.0.6


How reproducible:
100%


Steps to Reproduce:
A)
1. # vdo --name $NAME modify
2. echo $?

B)
1. # vdo --name $NAME changeWritePolicy
2. echo $?

C)
1. # vdo --name $NAME growLogical


Actual results:
A), B)
No error, no change

C)
failure growing to the same logical size


Expected results:
A)
vdo: ERROR - Missing required argument $LIST_OF_MODIFY_ARGUMENTS

B)
vdo: ERROR - Missing required argument '--writePolicy'

C)
vdo: ERROR - Missing required argument '--vdoLogicalSize'


Additional info:

Comment 2 Jakub Krysl 2017-11-09 14:15:04 UTC

For searchability:
# vdo --name vdo growLogical
vdo: ERROR - Can't shrink a VDO volume (old size 5860522584K)

Comment 3 Joe Shimkus 2017-12-04 17:25:53 UTC

Note that the resolution to this issue involves the discussed switch to using python's argparse library and, as such, changes the operation of the vdo command so that the operation to perform must be the first thing specified; e.g.,

> vdo list --verbose

and not:

> vdo --verbose list

Comment 5 Joe Shimkus 2017-12-11 17:05:08 UTC

There are some python exceptions raised during option checking that end up resulting in a python stack trace.  This has been corrected in a subsequent change and will be included in 6.1.0.95 or later.

Comment 6 Jakub Krysl 2017-12-15 14:01:54 UTC

Now each option checks for required arguments:

# vdo modify --name vdo
usage: vdo modify [-h] (-a | -n <volume>) [--blockMapCacheSize <megabytes>]
                  [--blockMapPeriod <period>] [--readCache {disabled,enabled}]
                  [--readCacheSize <megabytes>]
                  [--vdoAckThreads <threadCount>]
                  [--vdoBioRotationInterval <ioCount>]
                  [--vdoBioThreads <threadCount>]
                  [--vdoCpuThreads <threadCount>]
                  [--vdoHashZoneThreads <threadCount>]
                  [--vdoLogicalThreads <threadCount>]
                  [--vdoPhysicalThreads <threadCount>] [-f <file>]
                  [--logfile <pathname>] [--verbose]
vdo modify: error: options must be specified from: --blockMapCacheSize, --blockMapPeriod, --readCache, --readCacheSize, --vdoAckThreads, --vdoBioRotationInterval, --vdoBioThreads, --vdoCpuThreads, --vdoHashZoneThreads, --vdoLogicalThreads, --vdoPhysicalThreads

# vdo changeWritePolicy --name vdo
usage: vdo changeWritePolicy [-h] (-a | -n <volume>) --writePolicy
                             {async,sync} [-f <file>] [--logfile <pathname>]
                             [--verbose]
vdo changeWritePolicy: error: argument --writePolicy is required

# vdo growLogical --name vdo
usage: vdo growLogical [-h] -n <volume> --vdoLogicalSize <megabytes>
                       [-f <file>] [--logfile <pathname>] [--verbose]
vdo growLogical: error: argument --vdoLogicalSize is required

Comment 9 errata-xmlrpc 2018-04-10 15:47:46 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:0871