Red Hat Bugzilla – Bug 1509079
Revise collected files for VDO plugin for SOS
Last modified: 2018-04-10 14:07:13 EDT
Description of problem: On a test, I found that the sosreport plugin was able to collect the output of "vdo status", but it did not collect the sysfs directories (or those directories weren't were we expected them to be). The following items need to be changed in vdo.py under the "files" section: '/sys/vdo': change to '/sys/kvdo' '/sys/albireo': change to '/sys/uds' Version-Release number of selected component (if applicable): sos-3.5-1.el7.noarch How reproducible: 100% reproducible Steps to Reproduce: 1. Create a VDO volume with "vdo create --name=vdo1 --device=/dev/sdb" (or an appropriate block device. 2. Run "sosreport". Enter the necessary information to allow the report to complete. 3. Extract the contents of the resulting sosreport tarball into a test directory. Actual results: There are no VDO-related sysfs subdirectories in the "./sys" subdirectory of the sosreport tarball. Expected results: The "kvdo" and "uds" directories appear in the "./sys" subdirectory of the sosreport tarball. Additional info:
(In reply to Bryan Gurney from comment #0) > The following items need to be changed in vdo.py under the "files" section: > > '/sys/vdo': change to '/sys/kvdo' > '/sys/albireo': change to '/sys/uds' Shall we collect only the new locations or both (i.e. if some older version of VDO uses the old paths)? Is this required since RHEL 7.5 already? (there will be quite probably a package re-spin where I can include this BZ)
As with bug 1491805: depends on whether we actually expect to find the old paths present on RHEL installations. We can also add this upstream is there may be users on other distributions running older versions.
We should collect only the new locations, '/sys/kvdo' and '/sys/uds'. It is required for RHEL 7.5. Most of the diagnostic info can be collected via the kernel logs and the "vdo status" command output, but there's some important info in the sysfs directories that are important in a support case.
(In reply to Bryn M. Reeves from comment #3) > As with bug 1491805: depends on whether we actually expect to find the old > paths present on RHEL installations. We can also add this upstream is there > may be users on other distributions running older versions. For older versions of VDO, only the '/sys/kvdo' path will be present.
Bryan, could you pls. (promise to) verify this BZ once a build will be enabled? To simplify QE work..
(In reply to Pavel Moravec from comment #6) > Bryan, could you pls. (promise to) verify this BZ once a build will be > enabled? To simplify QE work.. Oh yes, I'm definitely running sosreport with this new build once it's available. (That's exactly how I found out that the sysfs directories weren't being collected.)
Granting qa_ack based on OtherQE commitment in comment 7.
Steve, could you please pm_ack+ this BZ for RHEL7.5 as otherwise original https://bugzilla.redhat.com/show_bug.cgi?id=1491805 would have to fail QE? (this BZ fixes some defect in requirements of that BZ)
Looks good; I can see the files in /sys/kvdo and /sys/uds reflected in an sosreport.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2018:0963