Bug 1509204 - dlm: Add ability to set SO_MARK on DLM sockets
Summary: dlm: Add ability to set SO_MARK on DLM sockets
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: kernel
Version: 8.5
Hardware: Unspecified
OS: Unspecified
Target Milestone: rc
: 8.5
Assignee: Alexander Aring
QA Contact: cluster-qe@redhat.com
Depends On:
Blocks: 1509210
TreeView+ depends on / blocked
Reported: 2017-11-03 10:47 UTC by Steve Whitehouse
Modified: 2021-11-10 02:21 UTC (History)
8 users (show)

Fixed In Version: kernel-4.18.0-332.el8
Doc Type: Enhancement
Doc Text:
.Per mark routing now allowed by setting the `SO_MARK` socket option value on per `nodeid` basis With this enhancement, you can now set the `SO_MARK` socket option value on per `nodeid` basis to allow per mark routing or other skb mark networking hooks. For more information, see the `socket(7)` man page.
Clone Of:
Last Closed: 2021-11-09 18:56:07 UTC
Type: Bug
Target Upstream Version:

Attachments (Terms of Use)

System ID Private Priority Status Summary Last Updated
Gitlab redhat/rhel/src/kernel rhel-8 merge_requests 270 0 None None None 2021-03-30 18:49:08 UTC
Red Hat Product Errata RHSA-2021:4356 0 None None None 2021-11-09 18:57:02 UTC

Description Steve Whitehouse 2017-11-03 10:47:06 UTC
We require the ability to set the SO_MARK on DLM tcp sockets (we might as well do SCTP too while we are at it, but TCP is the main requirement here) so that DLM traffic can be filtered by SO_MARK/nfmark. There will need to be a new config option to allow us to set this, and a kernel modification to take this config option and apply it to the sockets.

This feature will allow routing rules and firewalling to special case DLM traffic which will be useful for certain kinds of networking configs.

We will likely need some userland changes too, but lets just track this under a kernel bug for now, and we can clone a userland bug later as/when required. We could perhaps make this option a module option, which would avoid the need for config/userland changes. I think it will need to be a node global thing, as it would likely be too complicated to make it per-lockspace.

Comment 4 Robert Peterson 2019-09-12 16:27:45 UTC
Moving to rhel8

Comment 8 RHEL Program Management 2021-01-08 07:25:08 UTC
After evaluating this issue, there are no plans to address it further or fix it in an upcoming release.  Therefore, it is being closed.  If plans change such that this issue will be fixed in an upcoming release, then the bug can be reopened.

Comment 9 Steve Whitehouse 2021-01-08 09:14:22 UTC
Actively being worked on, and patches are going upstream at the moment.

Comment 15 kernel-workflow-bot 2021-03-31 10:57:50 UTC
The following Merge Request has pipeline job artifacts available:

Title: net: sock: add sock_set_mark
MR: https://gitlab.com/redhat/rhel/src/kernel/rhel-8/-/merge_requests/270
Pipeline: https://gitlab.com/redhat/rhel/src/kernel/rhel-8/-/pipelines/279060345

This Repo URL is *not* accessible from a web browser! It only functions as a dnf or yum baseurl.
Repo URL: https://s3.upshift.redhat.com/DH-PROD-CKI/internal/279060367/$basearch/4.18.0-301.1.el8.mr270_210330_1858.$basearch

Job: https://gitlab.com/redhat/red-hat-ci-tools/kernel/cki-internal-pipelines/cki-internal-contributors/-/jobs/1141012621
Gitlab browser: https://gitlab.com/redhat/red-hat-ci-tools/kernel/cki-internal-pipelines/cki-internal-contributors/-/jobs/1141012621/artifacts/browse/artifacts/repo/4.18.0-301.1.el8.mr270_210330_1858.s390x/
Current automated test status: success

Job: https://gitlab.com/redhat/red-hat-ci-tools/kernel/cki-internal-pipelines/cki-internal-contributors/-/jobs/1141012607
Gitlab browser: https://gitlab.com/redhat/red-hat-ci-tools/kernel/cki-internal-pipelines/cki-internal-contributors/-/jobs/1141012607/artifacts/browse/artifacts/repo/4.18.0-301.1.el8.mr270_210330_1858.ppc64le/
Current automated test status: success

Job: https://gitlab.com/redhat/red-hat-ci-tools/kernel/cki-internal-pipelines/cki-internal-contributors/-/jobs/1141012603
Gitlab browser: https://gitlab.com/redhat/red-hat-ci-tools/kernel/cki-internal-pipelines/cki-internal-contributors/-/jobs/1141012603/artifacts/browse/artifacts/repo/4.18.0-301.1.el8.mr270_210330_1858.aarch64/
Current automated test status: success

Job: https://gitlab.com/redhat/red-hat-ci-tools/kernel/cki-internal-pipelines/cki-internal-contributors/-/jobs/1141012576
Gitlab browser: https://gitlab.com/redhat/red-hat-ci-tools/kernel/cki-internal-pipelines/cki-internal-contributors/-/jobs/1141012576/artifacts/browse/artifacts/repo/4.18.0-301.1.el8.mr270_210330_1858.x86_64/
Current automated test status: success

Comment 27 Nate Straz 2021-08-04 22:29:15 UTC
Ran through some manual testing with kernel-4.18.0-317.el8.mr270_210625_1254.x86_64 and the new feature is working as expected.

Comment 37 Nate Straz 2021-08-25 21:27:42 UTC
Verified with kernel-4.18.0-332.el8.x86_64

Comment 43 errata-xmlrpc 2021-11-09 18:56:07 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: kernel security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.