Hide Forgot
Spec URL: https://pagure.io/polarsys-b612-fonts/raw/master/f/polarsys-b612-fonts.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/mavit/polarsys-b612-fonts/fedora-rawhide-x86_64/00657690-polarsys-b612-fonts/polarsys-b612-fonts-1.002-1.20170320gitf4ce1fd.fc28.src.rpm Description: Commissioned by Airbus and designed by Intactile Design, B612 is a digital font intended to be used in an aeronautical context. B612 is built with legibility as it’s core: every character is designed to be highly recognizable even in critical reading conditions. B612 drawing has been optimized for screen display, and full hinting has been added to all sizes of alpha numeric characters. Fedora Account System Username: mavit
>Group: User Interface/X > [...] >%clean The "Group:" tag and "%clean" section should not be used. https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections >Source0: %{name}-%{version}-%{gitcommit}.tar.xz It's preferred for this to be a downloadable URL. https://fedoraproject.org/wiki/Packaging:SourceURL Please check if the following will work for Source0: http://git.polarsys.org/c/b612/b612.git/snapshot/b612-%{gitcommit}.tar.gz
(In reply to Iwicki Artur from comment #1) > The "Group:" tag and "%clean" section should not be used. > https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections Thanks. I have updated https://fedoraproject.org/wiki/Fonts_spec_template_for_multiple_fonts to reflect this, and notice that bug #1271620 is already open against /etc/rpmdevtools/spectemplate-fonts-partial-multi.spec. > Please check if the following will work for Source0: > http://git.polarsys.org/c/b612/b612.git/snapshot/b612-%{gitcommit}.tar.gz Indeed it does. Splendid! SRPM URL: https://copr-be.cloud.fedoraproject.org/results/mavit/polarsys-b612-fonts/fedora-rawhide-x86_64/00657824-polarsys-b612-fonts/polarsys-b612-fonts-1.002-2.20170320gitf4ce1fd.fc28.src.rpm
> %defattr(0644,root,root,0755) Most likely this is not needed. > rm -fr %{buildroot} Not needed [https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections].
Thanks. SRPM URL: https://copr-be.cloud.fedoraproject.org/results/mavit/polarsys-b612-fonts/fedora-rawhide-x86_64/00660490-polarsys-b612-fonts/polarsys-b612-fonts-1.002-3.20170320gitf4ce1fd.fc28.src.rpm
grammatical error: as it’s core should probably not be the contraction for: it is but rather: its
(In reply to R P Herrold from comment #5) > grammatical error: > as it’s core Fixed in Git master. Thanks.
Looks good in general, but I'm not sure about the licensing. > License: EPL and BSD It would seem that the fonts are under EPL. Please add a comment in the spec file explaining what is licensed under which license [see https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios].
I've added a comment regarding the licences. I updated to the latest version, 1.003, which has corrected metadata and a different file layout, allowing the packaging to be simplified a little. I've also included the leaflet explaining the development of the fonts, in a doc subpackage. SRPM URL: https://copr-be.cloud.fedoraproject.org/results/mavit/polarsys-b612-fonts/fedora-rawhide-x86_64/00685719-polarsys-b612-fonts/polarsys-b612-fonts-1.003-1.20171129gitbd14fde.fc28.src.rpm
+ package name is OK + latest version + license is acceptable for Fedora (EPL+BSD) + license is specified correctly + builds and installs OK + provides/requires/buildrequires look OK + rpmlint and fedora-review are OK with the result Package is APPROVED.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/polarsys-b612-fonts. You may commit to the branch "f27" in about 10 minutes.
polarsys-b612-fonts-1.003-1.20171129gitbd14fde.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-43123347f9
polarsys-b612-fonts-1.003-1.20171129gitbd14fde.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-3be157dd96
Thanks for the review!
Many thanks to everyone that contributed to the packaging of this font set !
polarsys-b612-fonts-1.003-1.20171129gitbd14fde.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-43123347f9
polarsys-b612-fonts-1.003-1.20171129gitbd14fde.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-3be157dd96
polarsys-b612-fonts-1.003-1.20171129gitbd14fde.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
polarsys-b612-fonts-1.003-1.20171129gitbd14fde.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.