Bug 1510095 - Label->Tag mapping doesn't unassign last tag(s)
Summary: Label->Tag mapping doesn't unassign last tag(s)
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Providers
Version: 5.9.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: GA
: 5.9.0
Assignee: Beni Paskin-Cherniavsky
QA Contact: Dave Johnson
URL:
Whiteboard: container
Depends On: 1508437
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-11-06 17:01 UTC by Satoe Imaishi
Modified: 2018-03-06 14:59 UTC (History)
7 users (show)

Fixed In Version: 5.9.0.7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1508437
Environment:
Last Closed: 2018-03-06 14:59:58 UTC
Category: ---
Cloudforms Team: Container Management
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Comment 2 Beni Paskin-Cherniavsky 2017-11-07 14:53:09 UTC
Gaprindashvili backport details:

$ git log -1
commit 6f186bec9b54602b940c406b700d7e89cc01c6ee
Author: Adam Grare <agrare>
Date:   Wed Nov 1 10:22:45 2017 -0400

    Merge pull request #16370 from cben/blank-mapped-tags
    
    Do unassign tags when mapped tags list becomes empty
    (cherry picked from commit 48675e0f108169ed19647194a3abae691c972fcf)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1510095


I hope to add some unit tests, and probably backport them too, but moving to POST to unblock this for QE.

Comment 3 Beni Paskin-Cherniavsky 2017-11-07 14:58:28 UTC
QE: this bug only affects the old refresh mode (inventory_object_refresh=false).
I don't know if you intend to test that mode at all.
Feel free to move to back to ON_DEV if not.

Under default settings, it's irrelevant at this moment because tag mapping doesn't work at all yet with graph refresh.  I'll notify you when that's implemented.

Comment 4 CFME Bot 2017-11-29 20:22:18 UTC
New commit detected on ManageIQ/manageiq/gaprindashvili:
https://github.com/ManageIQ/manageiq/commit/6f186bec9b54602b940c406b700d7e89cc01c6ee

commit 6f186bec9b54602b940c406b700d7e89cc01c6ee
Author:     Adam Grare <agrare>
AuthorDate: Wed Nov 1 10:22:45 2017 -0400
Commit:     Satoe Imaishi <simaishi>
CommitDate: Mon Nov 6 14:50:43 2017 -0500

    Merge pull request #16370 from cben/blank-mapped-tags
    
    Do unassign tags when mapped tags list becomes empty
    (cherry picked from commit 48675e0f108169ed19647194a3abae691c972fcf)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1510095

 app/models/ems_refresh/save_inventory.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 5 CFME Bot 2017-11-29 20:22:51 UTC
New commit detected on ManageIQ/manageiq/gaprindashvili:
https://github.com/ManageIQ/manageiq/commit/feb7ff3e5c3b043eb22569e3f9157ce65bdca5fd

commit feb7ff3e5c3b043eb22569e3f9157ce65bdca5fd
Author:     Adam Grare <agrare>
AuthorDate: Mon Nov 13 08:32:08 2017 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Tue Nov 14 17:28:32 2017 -0500

    Merge pull request #16453 from cben/mapping_with_category_factory
    
    Improve tag mapping tests
    (cherry picked from commit 66a5465d7360474aaae1315fd9f66e93484b34f4)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1510095

 spec/factories/container_label_tag_mapping.rb      | 17 ++++++++
 .../save_inventory/save_tags_inventory_spec.rb     | 51 ++++++++++++++++++----
 2 files changed, 60 insertions(+), 8 deletions(-)


Note You need to log in before you can comment on or make changes to this bug.