Note: This bug is displayed in read-only format because
the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Description of problem:
Mark "PrintScreen" untranslatable explicitly as "Ctrl+Alt+Fx" keys
Version-Release number of selected component (if applicable):
virt-viewer-5.0-8.el7.x86_64
How reproducible:
100%
Steps to Reproduce:
Now that PrintScreen key is not translatable, i think it's better to mark it as untranslatable explicitly as "Ctrl+Alt" keys.
So that other QAs will not have questions about this key.
virt-viewer-window.c:560: { { GDK_KEY_Print, GDK_KEY_VoidSymbol }, "_PrintScreen", NULL},
Aug 01 17:08:33 <xiaodwan> pgrunt, should "PrintScreen" be set to translatable?
Aug 01 17:19:07 <pgrunt> xiaodwan: I don't know, do you think so ?
Aug 01 17:20:01 <pgrunt> in the menu it refers to the PrintScreen button
Aug 01 17:20:39 <pgrunt> i would say that it is international, like "Alt", "Ctrl"...
Aug 01 17:22:46 <pgrunt> xiaodwan: if we are talking about "Send Key" menu, then I would keep it "PrintScreen"
Aug 01 17:25:11 <xiaodwan> pgrunt, yeah. i thought it was a menu item but a system key... then it's find to keep it.
Aug 01 17:25:25 <xiaodwan> s/find/fine
Aug 01 17:36:39 <teuf> pgrunt_afk: xiaodwan: I've seen PrintScreen translated on at least some French keyboards
Aug 01 17:36:48 <teuf> not sure how widespread it is these days
Aug 01 17:43:18 <xiaodwan> teuf, yeah. if 'PrintScreen' need translate, i think 'ctrl'&'alt' should be translated, too. :-)
Aug 01 17:45:31 <teuf> gtk+ marks all these keys as translatable wiw
Actual results:
None
Expected results:
None
Additional info:
None
Comment 2Christophe Fergeau
2017-11-07 13:26:20 UTC
Is this bug about marking the "PrintScreen" string as translatable in virt-viewer? (currently it cannot be translated, contrary to "Ctrl+Alt+f10")
Or is this about removing the translatable marker from "Ctrl+Alt+fxx"?
Imo we should go for the former:
diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c
index af3441f..6f07091 100644
--- a/src/virt-viewer-window.c
+++ b/src/virt-viewer-window.c
@@ -557,7 +557,7 @@ static const struct keyComboDef keyCombos[] = {
{ { GDK_KEY_Control_L, GDK_KEY_Alt_L, GDK_KEY_F11, GDK_KEY_VoidSymbol }, N_("Ctrl+Alt+F11"), NULL},
{ { GDK_KEY_Control_L, GDK_KEY_Alt_L, GDK_KEY_F12, GDK_KEY_VoidSymbol }, N_("Ctrl+Alt+F12"), NULL},
{ { GDK_KEY_VoidSymbol }, "" , NULL},
- { { GDK_KEY_Print, GDK_KEY_VoidSymbol }, "_PrintScreen", NULL},
+ { { GDK_KEY_Print, GDK_KEY_VoidSymbol }, N_("_PrintScreen"), NULL},
};
static guint
> - { { GDK_KEY_Print, GDK_KEY_VoidSymbol }, "_PrintScreen", NULL},
> + { { GDK_KEY_Print, GDK_KEY_VoidSymbol }, N_("_PrintScreen"), NULL},
> };
>
> static guint
Yes, i want to mark as above. I used to misunderstand the meaning of N_().
Comment 4Christophe Fergeau
2018-01-09 14:23:13 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.
https://access.redhat.com/errata/RHSA-2019:2229
Description of problem: Mark "PrintScreen" untranslatable explicitly as "Ctrl+Alt+Fx" keys Version-Release number of selected component (if applicable): virt-viewer-5.0-8.el7.x86_64 How reproducible: 100% Steps to Reproduce: Now that PrintScreen key is not translatable, i think it's better to mark it as untranslatable explicitly as "Ctrl+Alt" keys. So that other QAs will not have questions about this key. virt-viewer-window.c:560: { { GDK_KEY_Print, GDK_KEY_VoidSymbol }, "_PrintScreen", NULL}, Aug 01 17:08:33 <xiaodwan> pgrunt, should "PrintScreen" be set to translatable? Aug 01 17:19:07 <pgrunt> xiaodwan: I don't know, do you think so ? Aug 01 17:20:01 <pgrunt> in the menu it refers to the PrintScreen button Aug 01 17:20:39 <pgrunt> i would say that it is international, like "Alt", "Ctrl"... Aug 01 17:22:46 <pgrunt> xiaodwan: if we are talking about "Send Key" menu, then I would keep it "PrintScreen" Aug 01 17:25:11 <xiaodwan> pgrunt, yeah. i thought it was a menu item but a system key... then it's find to keep it. Aug 01 17:25:25 <xiaodwan> s/find/fine Aug 01 17:36:39 <teuf> pgrunt_afk: xiaodwan: I've seen PrintScreen translated on at least some French keyboards Aug 01 17:36:48 <teuf> not sure how widespread it is these days Aug 01 17:43:18 <xiaodwan> teuf, yeah. if 'PrintScreen' need translate, i think 'ctrl'&'alt' should be translated, too. :-) Aug 01 17:45:31 <teuf> gtk+ marks all these keys as translatable wiw Actual results: None Expected results: None Additional info: None