Red Hat Bugzilla – Bug 1510499
With RHV Graph refresh template numbers in Provider inventory does not get updated correctly.
Last modified: 2018-05-07 16:43:03 EDT
Gaprindashvili backport details: $ git log -1 commit 14d59826582802cbf7f9eeca538ecd83209bc246 Author: Moti Asayag <masayag@redhat.com> Date: Mon Nov 6 13:40:34 2017 +0200 Merge pull request #128 from jhernand/dont_close_connections_explicitly Don't close connection explicitly (cherry picked from commit 18e76e3109420cb9bfaee3117ab43a438138d142) https://bugzilla.redhat.com/show_bug.cgi?id=1510499
New commit detected on ManageIQ/manageiq-providers-ovirt/gaprindashvili: https://github.com/ManageIQ/manageiq-providers-ovirt/commit/f7f7ad5526d6f8b8a1b799a6eaa156689c03014e commit f7f7ad5526d6f8b8a1b799a6eaa156689c03014e Author: Moti Asayag <masayag@redhat.com> AuthorDate: Mon Nov 6 11:51:43 2017 +0200 Commit: Satoe Imaishi <simaishi@redhat.com> CommitDate: Tue Nov 7 10:04:03 2017 -0500 Merge pull request #129 from pkliczewski/graph_update Handle partial vm entity during creation (cherry picked from commit 3c1c04022220bfe8b64cac3775b58c7692ea0ea7) https://bugzilla.redhat.com/show_bug.cgi?id=1510499 .../providers/redhat/inventory/collector/target_collection.rb | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
New commit detected on ManageIQ/manageiq-providers-ovirt/gaprindashvili: https://github.com/ManageIQ/manageiq-providers-ovirt/commit/14d59826582802cbf7f9eeca538ecd83209bc246 commit 14d59826582802cbf7f9eeca538ecd83209bc246 Author: Moti Asayag <masayag@redhat.com> AuthorDate: Mon Nov 6 13:40:34 2017 +0200 Commit: Satoe Imaishi <simaishi@redhat.com> CommitDate: Tue Nov 7 10:05:27 2017 -0500 Merge pull request #128 from jhernand/dont_close_connections_explicitly Don't close connection explicitly (cherry picked from commit 18e76e3109420cb9bfaee3117ab43a438138d142) https://bugzilla.redhat.com/show_bug.cgi?id=1510499 .../redhat/infra_manager/api_integration.rb | 2 -- .../redhat/infra_manager/vm/operations/snapshot.rb | 24 ++-------------------- .../infra_manager/operations/snapshot_spec.rb | 9 ++++---- 3 files changed, 6 insertions(+), 29 deletions(-)
Tested on CFME-5.9.0.10+RHV Graph refresh ON/RHV-4.1.8: 1. "Hosts & Clusters", "Vms & Templates" fields are not populated: Contain 'N/A' => Now solved. Those 2 fields show "Available" 2. Templates number do not get updated, though several templates were added on the RHV side, and though a target refresh was triggered, on CFME side. => Problem still exist. Piotr, Can you please take a check? Thanks.
It seems that recent fixes for BZ #1517852 caused regressions since they were implemented only for regular refresh. I suggest to handle the issue there since this BZ was fixed first.
Further to comment 6, This bug cannot be fully verified on CFME-5.9.0.12. It depends on bug 1525254 (5.9 clone of BZ #1517852)
I can see that the problem exists on master as well.
(In reply to Piotr Kliczewski from comment #8) > I can see that the problem exists on master as well. Is the bug ready for verification?
It looks like BZ #1525254 is verified so I think it is ready. There was a regression introduced when fixing it but hopefully it was removed.
Tested on CFME-5.9.0.15+RHV Graph refresh/RHV-4.1.8: Templates added on RHV side, trigger targeted refresh on CFME side, however, the templates are not displayed on CFME side: Nor on the total count in the RHV provider page, neither on the VMs & Templates page. Seems this Bug is yet fixed. Piotr, Can you please take a look? thanks.
Ilanit, As I mentioned comment #6 and comment #10 that I saw this regression. It seems that BZ #1525254 fixed regular refresh and broke graph.
Based on comments 11, 12, moving back to ASSIGNED.
We won't be able to make it for 5.9.0, so moving to 5.9.1
This was fixed by: https://github.com/ManageIQ/manageiq-providers-ovirt/pull/203
(In reply to Boriso from comment #15) > This was fixed by: > https://github.com/ManageIQ/manageiq-providers-ovirt/pull/203 Waiting for above to be backported. Once backport merged, we can move to MODIFIED
New commit detected on ManageIQ/manageiq-providers-ovirt/gaprindashvili: https://github.com/ManageIQ/manageiq-providers-ovirt/commit/7956b9b91e4ae61df86e3bb27e0405106f020c8c commit 7956b9b91e4ae61df86e3bb27e0405106f020c8c Author: Piotr Kliczewski <piotr.kliczewski@gmail.com> AuthorDate: Tue Feb 6 06:22:24 2018 -0500 Commit: Piotr Kliczewski <piotr.kliczewski@gmail.com> CommitDate: Tue Feb 6 06:22:24 2018 -0500 Merge pull request #203 from borod108/add_specs_for_targeted Add fix and add specs for graph targeted refresh (cherry picked from commit 744559cf973bc42b71fcaabae35759e314561797) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1510499 app/models/manageiq/providers/redhat/inventory/collector/target_collection.rb | 29 +- app/models/manageiq/providers/redhat/inventory_collection_default/infra_manager.rb | 55 + spec/models/manageiq/providers/redhat/infra_manager/refresh/refresher_graph_target_template_spec.rb | 57 + spec/models/manageiq/providers/redhat/infra_manager/refresh/refresher_graph_target_vm_spec.rb | 57 + spec/models/manageiq/providers/redhat/infra_manager/refresh/refresher_target_template_disconnect_spec.rb | 47 + spec/models/manageiq/providers/redhat/infra_manager/refresh/refresher_target_template_spec.rb | 47 - spec/vcr_cassettes/manageiq/providers/redhat/infra_manager/refresh/ovirt_sdk_refresh_graph_target_template.yml | 3759 + spec/vcr_cassettes/manageiq/providers/redhat/infra_manager/refresh/ovirt_sdk_refresh_graph_target_vm.yml | 4122 + spec/vcr_cassettes/manageiq/providers/redhat/infra_manager/refresh/ovirt_sdk_target_template_disconnect.yml | 9326 + spec/vcr_cassettes/manageiq/providers/redhat/infra_manager/refresh/ovirt_sdk_targeted_template.yml | 6398 - 10 files changed, 17442 insertions(+), 6455 deletions(-)
Verified on CFME-5.9.2.0/RHV-4.2.2. 1. "Hosts & Clusters", "Vms & Templates" fields contain 'available' 2. Templates number gets updated, when template is added on the RHV side.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2018:1328